implement feedback

Author: kvz

src/cli.ts

@@ -1,5 +1,6 @@
 #!/usr/bin/env node
 
+import { realpathSync } from 'node:fs'
 import path from 'node:path'
 import process from 'node:process'
 import { fileURLToPath } from 'node:url'
@@ -129,11 +130,29 @@ export async function main(args = process.argv.slice(2)): Promise<void> {
   }
 }
 
-const currentFile = path.resolve(fileURLToPath(import.meta.url))
-const invokedFile = typeof process.argv[1] === 'string' ? path.resolve(process.argv[1]) : ''
+const currentFile = realpathSync(fileURLToPath(import.meta.url))
+
+function resolveInvokedPath(invoked?: string): string | null {
+  if (invoked == null) return null
+  try {
+    return realpathSync(invoked)
+  } catch {
+    return path.resolve(invoked)
+  }
+}
+
+export function shouldRunCli(invoked?: string): boolean {
+  const resolved = resolveInvokedPath(invoked)
+  if (resolved == null) return false
+  return resolved === currentFile
+}
+
+export function runCliWhenExecuted(): void {
+  if (!shouldRunCli(process.argv[1])) return
 
-if (currentFile === invokedFile) {
   void main().catch((error) => {
     fail((error as Error).message)
   })
 }
+
+runCliWhenExecuted()

test/unit/test-cli.test.ts

@@ -1,5 +1,9 @@
+import { mkdtempSync, rmSync, symlinkSync } from 'node:fs'
+import path from 'node:path'
+import { tmpdir } from 'node:os'
+import { fileURLToPath } from 'node:url'
 import { afterEach, describe, expect, it, vi } from 'vitest'
-import { main, runSmartSig } from '../../src/cli.ts'
+import { main, runSmartSig, shouldRunCli } from '../../src/cli.ts'
 import { Transloadit } from '../../src/Transloadit.ts'
 
 const mockedExpiresDate = '2025-01-01T00:00:00.000Z'
@@ -19,6 +23,20 @@ afterEach(() => {
 })
 
 describe('cli smart_sig', () => {
+  it('recognizes symlinked invocation paths', () => {
+    const tmpDir = mkdtempSync(path.join(tmpdir(), 'transloadit-cli-'))
+    const symlinkTarget = fileURLToPath(new URL('../../src/cli.ts', import.meta.url))
+    const symlinkPath = path.join(tmpDir, 'transloadit')
+
+    symlinkSync(symlinkTarget, symlinkPath)
+    try {
+      expect(shouldRunCli(symlinkPath)).toBe(true)
+    } finally {
+      rmSync(symlinkPath)
+      rmSync(tmpDir, { recursive: true, force: true })
+    }
+  })
+
   it('overwrites auth key with env credentials', async () => {
     mockExpires()
     vi.stubEnv('TRANSLOADIT_KEY', 'key')