fix: CLI exits with code 1 when jobs fail, fix AbortSignal listener leak

- Add hasFailures tracking to JobsPromise so CLI can detect failures
- CLI assemblies create now returns exit code 1 when any job fails
- Fix memory leak in awaitAssemblyCompletion: remove abort listener
  when sleep timeout resolves normally
- Update CHANGELOG with better onPoll description

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: kvz

CHANGELOG.md

@@ -5,7 +5,7 @@ You may also want to refer to [GitHub releases](https://github.com/transloadit/n
 ## Unreleased
 
 - Add `signal` option to `createAssembly()` for cancelling in-flight HTTP requests and TUS uploads via `AbortController`
-- Add `signal` and `onPoll` options to `awaitAssemblyCompletion()` for cancellation and custom polling control
+- Add `signal` and `onPoll` options to `awaitAssemblyCompletion()` for cancellation and early termination (useful for custom progress reporting or superseding assemblies in watch mode)
 - Integrate transloadify CLI into the SDK, providing `assemblies`, `templates`, `bills`, and `assembly-notifications` commands
 - Add `--log-level (-l)` CLI option using syslog severity levels (err=3, warn=4, notice=5, info=6, debug=7, trace=8)
 - Apply stricter biome lint rules (noExplicitAny, useAwait, noForEach, noNonNullAssertion)

src/Transloadit.ts

@@ -422,17 +422,19 @@ export class Transloadit {
         throw new PollingTimeoutError('Polling timed out')
       }
 
-      // Make the sleep abortable
+      // Make the sleep abortable, ensuring listener cleanup to prevent memory leaks
       await new Promise<void>((resolve, reject) => {
-        const timeoutId = setTimeout(resolve, interval)
-        signal?.addEventListener(
-          'abort',
-          () => {
-            clearTimeout(timeoutId)
-            reject(signal.reason ?? new DOMException('Aborted', 'AbortError'))
-          },
-          { once: true },
-        )
+        const timeoutId = setTimeout(() => {
+          signal?.removeEventListener('abort', onAbort)
+          resolve()
+        }, interval)
+
+        function onAbort() {
+          clearTimeout(timeoutId)
+          reject(signal?.reason ?? new DOMException('Aborted', 'AbortError'))
+        }
+
+        signal?.addEventListener('abort', onAbort, { once: true })
       })
     }
   }

src/cli/JobsPromise.ts

@@ -3,10 +3,12 @@
  * Used to run multiple async operations in parallel while:
  * 1. Reporting errors as they happen (via onError callback)
  * 2. Waiting for all operations to complete at the end
+ * 3. Tracking whether any failures occurred
  */
 export default class JobsPromise {
   private promises: Set<Promise<unknown>> = new Set()
   private onError: ((err: unknown) => void) | null = null
+  private _hasFailures = false
 
   /**
    * Set the error handler for individual promise rejections.
@@ -29,13 +31,21 @@ export default class JobsPromise {
     const errorHandler = this.onError
     promise
       .catch((err: unknown) => {
+        this._hasFailures = true
         errorHandler(err)
       })
       .finally(() => {
         this.promises.delete(promise)
       })
   }
 
+  /**
+   * Returns true if any tracked promise has rejected.
+   */
+  get hasFailures(): boolean {
+    return this._hasFailures
+  }
+
   /**
    * Wait for all tracked promises to settle.
    * Returns array of fulfilled values (rejects are filtered out

src/cli/assemblies-create.ts

@@ -615,7 +615,7 @@ export default async function run(
     del,
     reprocessStale,
   }: AssembliesCreateOptions,
-): Promise<unknown[]> {
+): Promise<{ results: unknown[]; hasFailures: boolean }> {
   // Quick fix for https://github.com/transloadit/transloadify/issues/13
   // Only default to stdout when output is undefined (not provided), not when explicitly null
   let resolvedOutput = output
@@ -811,8 +811,9 @@ export default async function run(
       reject(err)
     })
 
-    emitter.on('end', () => {
-      resolve(jobsPromise.allSettled())
+    emitter.on('end', async () => {
+      const results = await jobsPromise.allSettled()
+      resolve({ results, hasFailures: jobsPromise.hasFailures })
     })
   })
 }

src/cli/commands/assemblies.ts

@@ -104,7 +104,7 @@ export class AssembliesCreateCommand extends AuthenticatedCommand {
       fieldsMap[key] = value
     }
 
-    await assembliesCreate(this.output, this.client, {
+    const { hasFailures } = await assembliesCreate(this.output, this.client, {
       steps: this.steps,
       template: this.template,
       fields: fieldsMap,
@@ -115,7 +115,7 @@ export class AssembliesCreateCommand extends AuthenticatedCommand {
       del: this.deleteAfterProcessing,
       reprocessStale: this.reprocessStale,
     })
-    return undefined
+    return hasFailures ? 1 : undefined
   }
 }
 

test/unit/cli/JobsPromise.test.ts

@@ -43,4 +43,30 @@ describe('JobsPromise', () => {
       'JobsPromise: error handler must be set before adding promises',
     )
   })
+
+  it('should track hasFailures when promise rejects', async () => {
+    const jobs = new JobsPromise()
+    jobs.setErrorHandler(() => {})
+
+    expect(jobs.hasFailures).toBe(false)
+
+    jobs.add(Promise.resolve('ok'))
+    jobs.add(Promise.reject(new Error('fail')))
+
+    await jobs.allSettled()
+
+    expect(jobs.hasFailures).toBe(true)
+  })
+
+  it('should have hasFailures false when all succeed', async () => {
+    const jobs = new JobsPromise()
+    jobs.setErrorHandler(() => {})
+
+    jobs.add(Promise.resolve('a'))
+    jobs.add(Promise.resolve('b'))
+
+    await jobs.allSettled()
+
+    expect(jobs.hasFailures).toBe(false)
+  })
 })