remove stack hack

#211 (comment)

Author: mifi

src/ApiError.ts

@@ -21,10 +21,9 @@ export class ApiError extends Error {
 
   constructor(params: {
     cause?: HTTPError
-    appendStack?: string
     body: TransloaditErrorResponseBody | undefined
   }) {
-    const { cause, body = {}, appendStack } = params
+    const { cause, body = {} } = params
 
     const parts = ['API error']
     if (cause?.response.statusCode) parts.push(`(HTTP ${cause.response.statusCode})`)
@@ -35,19 +34,6 @@ export class ApiError extends Error {
     const message = parts.join(' ')
 
     super(message)
-
-    // if we have a cause, use the stack trace from it instead
-    if (cause != null && typeof cause.stack === 'string') {
-      const indexOfMessageEnd = cause.stack.indexOf(cause.message) + cause.message.length
-      const gotStacktrace = cause.stack.slice(indexOfMessageEnd)
-      this.stack = `${message}${gotStacktrace}`
-    }
-
-    // If we have an original stack, append it to the bottom, because `got`s stack traces are not very good
-    if (this.stack != null && appendStack != null) {
-      this.stack += `\n${appendStack.replace(/^([^\n]+\n)/, '')}`
-    }
-
     this.rawMessage = body.message
     this.assemblyId = body.assembly_id
     this.assemblySslUrl = body.assembly_ssl_url

src/Transloadit.ts

@@ -732,10 +732,6 @@ export class Transloadit {
         responseType: 'json',
       }
 
-      // `got` stacktraces are very lacking, so we capture our own
-      // https://github.com/sindresorhus/got/blob/main/documentation/async-stack-traces.md
-      const stack = new Error().stack
-
       try {
         const request = got[method]<T>(url, requestOpts)
         const { body } = await request
@@ -766,7 +762,6 @@ export class Transloadit {
         ) {
           throw new ApiError({
             cause: err,
-            appendStack: stack,
             body: body as TransloaditErrorResponseBody,
           }) // todo don't assert type
         }

test/unit/mock-http.test.ts

@@ -133,21 +133,16 @@ describe('Mocked API tests', () => {
         ),
         expect.stringMatching(`    at .+`),
         expect.stringMatching(`    at .+`),
-        expect.stringMatching(
-          `    at Transloadit\\._remoteJson \\(.+\\/src\\/Transloadit\\.ts:\\d+:\\d+\\)`
-        ),
         expect.stringMatching(
           `    at createAssemblyAndUpload \\(.+\\/src\\/Transloadit\\.ts:\\d+:\\d+\\)`
         ),
-        expect.stringMatching(`    at .+\\/src\\/Transloadit\\.ts:\\d+:\\d+`),
-        expect.stringMatching(`    at .+`),
         expect.stringMatching(`    at .+\\/test\\/unit\\/mock-http\\.test\\.ts:\\d+:\\d+`),
         expect.stringMatching(`    at .+`),
         expect.stringMatching(`    at .+`),
         expect.stringMatching(`    at .+`),
         expect.stringMatching(`    at .+`),
         expect.stringMatching(`    at .+`),
-        expect.stringMatching(`  name: 'ApiError',`),
+        expect.stringMatching(`    at .+`),
         expect.stringMatching(`  rawMessage: 'Invalid file metadata',`),
         expect.stringMatching(`  assemblyId: '123',`),
         expect.stringMatching(