On TaskRunProcess, set max old space and deduplicate the flags with priority order

Author: matt-aitken

packages/cli-v3/src/executions/taskRunProcess.ts

@@ -19,6 +19,7 @@ import { ChildProcess, fork } from "node:child_process";
 import { chalkError, chalkGrey, chalkRun, prettyPrintDate } from "../utilities/cliOutput.js";
 
 import { execOptionsForRuntime, execPathForRuntime } from "@trigger.dev/core/v3/build";
+import { nodeOptionsWithMaxOldSpaceSize } from "@trigger.dev/core/v3/machines";
 import { InferSocketMessageSchema } from "@trigger.dev/core/v3/zodSocket";
 import { logger } from "../utilities/logger.js";
 import {
@@ -117,14 +118,16 @@ export class TaskRunProcess {
   }
 
   async initialize() {
-    const { env: $env, workerManifest, cwd, messageId } = this.options;
+    const { env: $env, workerManifest, cwd, messageId, payload } = this.options;
+
+    const maxOldSpaceSize = nodeOptionsWithMaxOldSpaceSize(undefined, payload.execution.machine);
 
     const fullEnv = {
       ...(this.isTest ? { TRIGGER_LOG_LEVEL: "debug" } : {}),
       ...$env,
       OTEL_IMPORT_HOOK_INCLUDES: workerManifest.otelImportHook?.include?.join(","),
       // TODO: this will probably need to use something different for bun (maybe --preload?)
-      NODE_OPTIONS: execOptionsForRuntime(workerManifest.runtime, workerManifest),
+      NODE_OPTIONS: execOptionsForRuntime(workerManifest.runtime, workerManifest, maxOldSpaceSize),
       PATH: process.env.PATH,
       TRIGGER_PROCESS_FORK_START_TIME: String(Date.now()),
     };

packages/core/src/v3/build/runtime.ts

@@ -1,6 +1,7 @@
 import { join } from "node:path";
 import { pathToFileURL } from "url";
 import { BuildRuntime } from "../schemas/build.js";
+import { dedupFlags } from "./flags.js";
 
 export const DEFAULT_RUNTIME = "node" satisfies BuildRuntime;
 
@@ -41,7 +42,11 @@ export type ExecOptions = {
   customConditions?: string[];
 };
 
-export function execOptionsForRuntime(runtime: BuildRuntime, options: ExecOptions): string {
+export function execOptionsForRuntime(
+  runtime: BuildRuntime,
+  options: ExecOptions,
+  additionalNodeOptions?: string
+): string {
   switch (runtime) {
     case "node":
     case "node-22": {
@@ -51,15 +56,19 @@ export function execOptionsForRuntime(runtime: BuildRuntime, options: ExecOption
 
       const conditions = options.customConditions?.map((condition) => `--conditions=${condition}`);
 
-      return [
+      //later flags will win (after the dedupe)
+      const flags = [
+        process.env.NODE_OPTIONS,
+        additionalNodeOptions,
         importEntryPoint,
         conditions,
-        process.env.NODE_OPTIONS,
         nodeRuntimeNeedsGlobalWebCryptoFlag() ? "--experimental-global-webcrypto" : undefined,
       ]
         .filter(Boolean)
         .flat()
         .join(" ");
+
+      return dedupFlags(flags);
     }
     case "bun": {
       return "";

packages/core/src/v3/schemas/common.ts

@@ -308,7 +308,7 @@ export const TaskRunExecution = z.object({
   organization: TaskRunExecutionOrganization,
   project: TaskRunExecutionProject,
   batch: TaskRunExecutionBatch.optional(),
-  machine: MachinePreset.optional(),
+  machine: MachinePreset,
 });
 
 export type TaskRunExecution = z.infer<typeof TaskRunExecution>;