Better error when failing to creating a manual waitpoint after X attempts

matt-aitken · matt-aitken · commit 0e4a759616f7 · 2025-03-26T17:48:14.000Z
diff --git a/internal-packages/run-engine/src/engine/systems/waitpointSystem.ts b/internal-packages/run-engine/src/engine/systems/waitpointSystem.ts
@@ -334,7 +334,7 @@ export class WaitpointSystem {
           attempts++;
           if (attempts >= maxRetries) {
             throw new Error(
-              `Failed to create waitpoint tag after ${maxRetries} attempts due to conflicts.`
+              `Failed to create waitpoint after ${maxRetries} attempts due to conflicts.`
             );
           }
         } else {
@@ -343,9 +343,7 @@ export class WaitpointSystem {
       }
     }
 
-    throw new Error(
-      `Failed to create waitpoint tag after ${maxRetries} attempts due to conflicts.`
-    );
+    throw new Error(`Failed to create waitpoint after ${maxRetries} attempts due to conflicts.`);
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ export class WaitpointSystem {`
`334`	`334`	`attempts++;`
`335`	`335`	`if (attempts >= maxRetries) {`
`336`	`336`	`throw new Error(`
`337`		- `Failed to create waitpoint tag after ${maxRetries} attempts due to conflicts.`
	`337`	+ `Failed to create waitpoint after ${maxRetries} attempts due to conflicts.`
`338`	`338`	`);`
`339`	`339`	`}`
`340`	`340`	`} else {`
`@@ -343,9 +343,7 @@ export class WaitpointSystem {`
`343`	`343`	`}`
`344`	`344`	`}`
`345`	`345`
`346`		`- throw new Error(`
`347`		- `Failed to create waitpoint tag after ${maxRetries} attempts due to conflicts.`
`348`		`- );`
	`346`	+ throw new Error(`Failed to create waitpoint after ${maxRetries} attempts due to conflicts.`);
`349`	`347`	`}`
`350`	`348`
`351`	`349`	`/**`