Skip to content

Commit 0f217e8

Browse files
committed
Consolidate TypeScript and @types/node versions across monorepo
- Add @types/node override (20.14.14) in root package.json to prevent version drift. Previously @remix-run/dev was pulling in @types/node@22 which conflicted with the rest of the codebase expecting @types/node@20 - Add "node" to webapp tsconfig.json types array to fix Buffer and other Node.js type errors in local typecheck (types: ["vitest/globals"] was restricting automatic type inclusion) - Update e2e fixture emit-decorator-metadata to use @types/node 20.14.14 instead of 22.5.4 This addresses local typecheck giving false errors about Buffer etc. while CI passes (different @types/node versions being resolved). https://claude.ai/code/session_018eqp2LvvErkFSN9oK5xBh1
1 parent 72c3571 commit 0f217e8

File tree

4 files changed

+47
-83
lines changed

4 files changed

+47
-83
lines changed

apps/webapp/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"exclude": ["./cypress", "./cypress.config.ts"],
33
"include": ["remix.env.d.ts", "global.d.ts", "**/*.ts", "**/*.tsx"],
44
"compilerOptions": {
5-
"types": ["vitest/globals"],
5+
"types": ["vitest/globals", "node"],
66
"lib": ["DOM", "DOM.Iterable", "DOM.AsyncIterable", "ES2020"],
77
"isolatedModules": true,
88
"esModuleInterop": true,

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
},
8686
"overrides": {
8787
"typescript": "5.5.4",
88+
"@types/node": "20.14.14",
8889
"express@^4>body-parser": "1.20.3",
8990
"@remix-run/dev@2.1.0>tar-fs": "2.1.3",
9091
"testcontainers@10.28.0>tar-fs": "3.0.9",

packages/cli-v3/e2e/fixtures/emit-decorator-metadata/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
},
1616
"devDependencies": {
1717
"@trigger.dev/build": "0.0.0-prerelease-20250321122618",
18-
"@types/node": "22.5.4",
18+
"@types/node": "20.14.14",
1919
"typescript": "5.5.4"
2020
}
2121
}

0 commit comments

Comments
 (0)