WIP on waitpoint inspector

Author: matt-aitken

apps/webapp/app/presenters/v3/SpanPresenter.server.ts

@@ -423,12 +423,41 @@ export class SpanPresenter extends BasePresenter {
       },
     });
 
-    return {
+    const data = {
       ...span,
       events: span.events,
       properties: span.properties ? JSON.stringify(span.properties, null, 2) : undefined,
       triggeredRuns,
       showActionBar: span.show?.actions === true,
     };
+
+    switch (span.entity.type) {
+      case "waitpoint":
+        const waitpoint = await this._replica.waitpoint.findFirst({
+          where: {
+            friendlyId: span.entity.id,
+          },
+          select: {
+            friendlyId: true,
+            type: true,
+            status: true,
+            idempotencyKey: true,
+            userProvidedIdempotencyKey: true,
+            idempotencyKeyExpiresAt: true,
+            output: true,
+            outputType: true,
+            outputIsError: true,
+          },
+        });
+
+        return {
+          ...data,
+          entityType: "waitpoint" as const,
+          waitpoint,
+        };
+
+      default:
+        return { ...data, entityType: "span" as const };
+    }
   }
 }

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam.spans.$spanParam/route.tsx

@@ -188,7 +188,7 @@ function SpanBody({
             className="h-4 min-h-4 w-4 min-w-4"
           />
           <Header2 className={cn("overflow-x-hidden")}>
-            <SpanTitle {...span} size="large" />
+            <SpanTitle {...span} size="large" hideAccessory />
           </Header2>
         </div>
         {runParam && closePanel && (
@@ -385,14 +385,7 @@ function SpanBody({
                 )}
               </Property.Table>
               {span.events.length > 0 && <SpanEvents spanEvents={span.events} />}
-              {span.properties !== undefined && (
-                <CodeBlock
-                  rowTitle="Properties"
-                  code={span.properties}
-                  maxLines={20}
-                  showLineNumbers={false}
-                />
-              )}
+              <SpanEntity span={span} />
             </div>
           )}
         </div>
@@ -1217,3 +1210,81 @@ function SpanLinkElement({ link }: { link: SpanLink }) {
 
   return null;
 }
+
+function SpanEntity({ span }: { span: Span }) {
+  switch (span.entityType) {
+    case "waitpoint": {
+      if (!span.waitpoint) {
+        return <Paragraph>No waitpoint found: {span.entity.id}</Paragraph>;
+      }
+
+      return (
+        <>
+          <Property.Table>
+            <Property.Item>
+              <Property.Label>Waitpoint ID</Property.Label>
+              <Property.Value className="whitespace-pre-wrap">
+                {span.waitpoint?.friendlyId}
+              </Property.Value>
+            </Property.Item>
+            <Property.Item>
+              <Property.Label>Waitpoint status</Property.Label>
+              <Property.Value>
+                <TaskRunAttemptStatusCombo
+                  status={
+                    span.waitpoint.status === "PENDING"
+                      ? "EXECUTING"
+                      : span.waitpoint.outputIsError
+                      ? "FAILED"
+                      : "COMPLETED"
+                  }
+                  className="text-sm"
+                />
+              </Property.Value>
+            </Property.Item>
+            <Property.Item>
+              <Property.Label>Waitpoint idempotency key</Property.Label>
+              <Property.Value>
+                {span.waitpoint.userProvidedIdempotencyKey ? span.waitpoint.idempotencyKey : "–"}
+              </Property.Value>
+            </Property.Item>
+            <Property.Item>
+              <Property.Label>Waitpoint idempotency key expires at</Property.Label>
+              <Property.Value>
+                {span.waitpoint.idempotencyKeyExpiresAt ? (
+                  <DateTime date={span.waitpoint.idempotencyKeyExpiresAt} />
+                ) : (
+                  "–"
+                )}
+              </Property.Value>
+            </Property.Item>
+          </Property.Table>
+          {span.waitpoint.status === "PENDING" ? (
+            <div>Manually complete waitpoint</div>
+          ) : span.waitpoint.output ? (
+            <PacketDisplay
+              title="Waitpoint output"
+              data={span.waitpoint.output}
+              dataType={span.waitpoint.outputType}
+            />
+          ) : (
+            "No output"
+          )}
+        </>
+      );
+    }
+    default: {
+      if (span.properties !== undefined)
+        return (
+          <CodeBlock
+            rowTitle="Properties"
+            code={span.properties}
+            maxLines={20}
+            showLineNumbers={false}
+          />
+        );
+    }
+  }
+
+  return <></>;
+}

apps/webapp/app/v3/eventRepository.server.ts

@@ -624,6 +624,14 @@ export class EventRepository {
         SemanticInternalAttributes.ORIGINAL_RUN_ID
       );
 
+      const entity = {
+        type: rehydrateAttribute<string>(
+          spanEvent.properties,
+          SemanticInternalAttributes.ENTITY_TYPE
+        ),
+        id: rehydrateAttribute<string>(spanEvent.properties, SemanticInternalAttributes.ENTITY_ID),
+      };
+
       return {
         ...spanEvent,
         ...span.data,
@@ -634,6 +642,7 @@ export class EventRepository {
         show,
         links,
         originalRun,
+        entity,
       };
     });
   }

packages/core/src/v3/semanticInternalAttributes.ts

@@ -25,6 +25,8 @@ export const SemanticInternalAttributes = {
   MACHINE_PRESET_CENTS_PER_MS: "ctx.machine.centsPerMs",
   SPAN_PARTIAL: "$span.partial",
   SPAN_ID: "$span.span_id",
+  ENTITY_TYPE: "$entity.type",
+  ENTITY_ID: "$entity.id",
   OUTPUT: "$output",
   OUTPUT_TYPE: "$mime_type_output",
   STYLE: "$style",

packages/trigger-sdk/src/v3/wait.ts

@@ -206,6 +206,8 @@ export const wait = {
       {
         attributes: {
           [SemanticInternalAttributes.STYLE_ICON]: "wait-token",
+          [SemanticInternalAttributes.ENTITY_TYPE]: "waitpoint",
+          [SemanticInternalAttributes.ENTITY_ID]: tokenId,
           id: tokenId,
           ...accessoryAttributes({
             items: [