Skip to content

Commit 3b0e6d4

Browse files
samejrsamejr
committed
Removed more unnecessary header table rows to prevent them being selectable
1 parent f97c60d commit 3b0e6d4

File tree

7 files changed

+110
-124
lines changed
  • apps/webapp/app/routes
    • _app.orgs.$organizationSlug.projects.v3.$projectParam.alerts
    • _app.orgs.$organizationSlug.projects.v3.$projectParam.apikeys
    • _app.orgs.$organizationSlug.projects.v3.$projectParam.concurrency
    • _app.orgs.$organizationSlug.projects.v3.$projectParam.deployments
    • _app.orgs.$organizationSlug.projects.v3.$projectParam.environment-variables
    • _app.orgs.$organizationSlug.projects.v3.$projectParam.schedules
    • _app.orgs.$organizationSlug.v3.usage

7 files changed

+110
-124
lines changed

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.alerts/route.tsx‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -187,14 +187,12 @@ export default function Page() {
187187
</div>
188188
<Table>
189189
<TableHeader>
190-
<TableRow>
191-
<TableHeaderCell>Name</TableHeaderCell>
192-
<TableHeaderCell>Alert types</TableHeaderCell>
193-
<TableHeaderCell>Environments</TableHeaderCell>
194-
<TableHeaderCell>Channel</TableHeaderCell>
195-
<TableHeaderCell>Enabled</TableHeaderCell>
196-
<TableHeaderCell hiddenLabel>Actions</TableHeaderCell>
197-
</TableRow>
190+
<TableHeaderCell>Name</TableHeaderCell>
191+
<TableHeaderCell>Alert types</TableHeaderCell>
192+
<TableHeaderCell>Environments</TableHeaderCell>
193+
<TableHeaderCell>Channel</TableHeaderCell>
194+
<TableHeaderCell>Enabled</TableHeaderCell>
195+
<TableHeaderCell hiddenLabel>Actions</TableHeaderCell>
198196
</TableHeader>
199197
<TableBody>
200198
{alertChannels.length > 0 ? (

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.apikeys/route.tsx‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,12 @@ export default function Page() {
8585
<div className="flex flex-col">
8686
<Table containerClassName="border-t-0">
8787
<TableHeader>
88-
<TableRow>
89-
<TableHeaderCell>Environment</TableHeaderCell>
90-
<TableHeaderCell>Secret key</TableHeaderCell>
91-
<TableHeaderCell>Key generated</TableHeaderCell>
92-
<TableHeaderCell>Latest version</TableHeaderCell>
93-
<TableHeaderCell>Env vars</TableHeaderCell>
94-
<TableHeaderCell hiddenLabel>Actions</TableHeaderCell>
95-
</TableRow>
88+
<TableHeaderCell>Environment</TableHeaderCell>
89+
<TableHeaderCell>Secret key</TableHeaderCell>
90+
<TableHeaderCell>Key generated</TableHeaderCell>
91+
<TableHeaderCell>Latest version</TableHeaderCell>
92+
<TableHeaderCell>Env vars</TableHeaderCell>
93+
<TableHeaderCell hiddenLabel>Actions</TableHeaderCell>
9694
</TableHeader>
9795
<TableBody>
9896
{environments.map((environment) => (

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.concurrency/route.tsx‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,10 @@ export default function Page() {
8080
<div className="flex flex-col">
8181
<Table containerClassName="border-t-0">
8282
<TableHeader>
83-
<TableRow>
84-
<TableHeaderCell>Environment</TableHeaderCell>
85-
<TableHeaderCell alignment="right">Queued</TableHeaderCell>
86-
<TableHeaderCell alignment="right">Running</TableHeaderCell>
87-
<TableHeaderCell alignment="right">Concurrency limit</TableHeaderCell>
88-
</TableRow>
83+
<TableHeaderCell>Environment</TableHeaderCell>
84+
<TableHeaderCell alignment="right">Queued</TableHeaderCell>
85+
<TableHeaderCell alignment="right">Running</TableHeaderCell>
86+
<TableHeaderCell alignment="right">Concurrency limit</TableHeaderCell>
8987
</TableHeader>
9088
<TableBody>
9189
<Suspense fallback={<Spinner />}>

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.deployments/route.tsx‎

Lines changed: 30 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -120,39 +120,37 @@ export default function Page() {
120120
<div className="grid max-h-full grid-rows-[1fr_auto]">
121121
<Table containerClassName="border-t-0">
122122
<TableHeader>
123-
<TableRow>
124-
<TableHeaderCell>Deploy</TableHeaderCell>
125-
<TableHeaderCell>Env</TableHeaderCell>
126-
<TableHeaderCell>Version</TableHeaderCell>
127-
<TableHeaderCell
128-
tooltip={
129-
<div className="flex flex-col divide-y divide-grid-dimmed">
130-
{deploymentStatuses.map((status) => (
131-
<div
132-
key={status}
133-
className="grid grid-cols-[8rem_1fr] gap-x-2 py-2 first:pt-1 last:pb-1"
134-
>
135-
<div className="mb-0.5 flex items-center gap-1.5 whitespace-nowrap">
136-
<DeploymentStatus status={status} isBuilt={false} />
137-
</div>
138-
<Paragraph
139-
variant="extra-small"
140-
className="!text-wrap text-text-dimmed"
141-
>
142-
{deploymentStatusDescription(status)}
143-
</Paragraph>
123+
<TableHeaderCell>Deploy</TableHeaderCell>
124+
<TableHeaderCell>Env</TableHeaderCell>
125+
<TableHeaderCell>Version</TableHeaderCell>
126+
<TableHeaderCell
127+
tooltip={
128+
<div className="flex flex-col divide-y divide-grid-dimmed">
129+
{deploymentStatuses.map((status) => (
130+
<div
131+
key={status}
132+
className="grid grid-cols-[8rem_1fr] gap-x-2 py-2 first:pt-1 last:pb-1"
133+
>
134+
<div className="mb-0.5 flex items-center gap-1.5 whitespace-nowrap">
135+
<DeploymentStatus status={status} isBuilt={false} />
144136
</div>
145-
))}
146-
</div>
147-
}
148-
>
149-
Status
150-
</TableHeaderCell>
151-
<TableHeaderCell>Tasks</TableHeaderCell>
152-
<TableHeaderCell>Deployed at</TableHeaderCell>
153-
<TableHeaderCell>Deployed by</TableHeaderCell>
154-
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
155-
</TableRow>
137+
<Paragraph
138+
variant="extra-small"
139+
className="!text-wrap text-text-dimmed"
140+
>
141+
{deploymentStatusDescription(status)}
142+
</Paragraph>
143+
</div>
144+
))}
145+
</div>
146+
}
147+
>
148+
Status
149+
</TableHeaderCell>
150+
<TableHeaderCell>Tasks</TableHeaderCell>
151+
<TableHeaderCell>Deployed at</TableHeaderCell>
152+
<TableHeaderCell>Deployed by</TableHeaderCell>
153+
<TableHeaderCell hiddenLabel>Go to page</TableHeaderCell>
156154
</TableHeader>
157155
<TableBody>
158156
{deployments.length > 0 ? (

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.environment-variables/route.tsx‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -214,15 +214,13 @@ export default function Page() {
214214
)}
215215
<Table containerClassName={cn(environmentVariables.length === 0 && "border-t-0")}>
216216
<TableHeader>
217-
<TableRow>
218-
<TableHeaderCell>Key</TableHeaderCell>
219-
{environments.map((environment) => (
220-
<TableHeaderCell key={environment.id}>
221-
<EnvironmentLabel environment={environment} />
222-
</TableHeaderCell>
223-
))}
224-
<TableHeaderCell hiddenLabel>Actions</TableHeaderCell>
225-
</TableRow>
217+
<TableHeaderCell>Key</TableHeaderCell>
218+
{environments.map((environment) => (
219+
<TableHeaderCell key={environment.id}>
220+
<EnvironmentLabel environment={environment} />
221+
</TableHeaderCell>
222+
))}
223+
<TableHeaderCell hiddenLabel>Actions</TableHeaderCell>
226224
</TableHeader>
227225
<TableBody>
228226
{environmentVariables.length > 0 ? (

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.schedules/route.tsx‎

Lines changed: 51 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -385,64 +385,62 @@ function SchedulesTable({
385385
return (
386386
<Table>
387387
<TableHeader>
388-
<TableRow>
389-
<TableHeaderCell>ID</TableHeaderCell>
390-
<TableHeaderCell>Task ID</TableHeaderCell>
391-
<TableHeaderCell
392-
tooltip={
393-
<div className="flex max-w-xs flex-col gap-4 p-1">
394-
<div>
395-
<div className="mb-0.5 flex items-center gap-1.5 text-sm">
396-
<div className={"flex items-center space-x-1"}>
397-
<ScheduleTypeIcon type={"DECLARATIVE"} className="text-sky-500" />
398-
<span className="font-medium">{scheduleTypeName("DECLARATIVE")}</span>
399-
</div>
388+
<TableHeaderCell>ID</TableHeaderCell>
389+
<TableHeaderCell>Task ID</TableHeaderCell>
390+
<TableHeaderCell
391+
tooltip={
392+
<div className="flex max-w-xs flex-col gap-4 p-1">
393+
<div>
394+
<div className="mb-0.5 flex items-center gap-1.5 text-sm">
395+
<div className={"flex items-center space-x-1"}>
396+
<ScheduleTypeIcon type={"DECLARATIVE"} className="text-sky-500" />
397+
<span className="font-medium">{scheduleTypeName("DECLARATIVE")}</span>
400398
</div>
401-
<Paragraph variant="small" className="!text-wrap text-text-dimmed">
402-
Declarative schedules are defined in a{" "}
403-
<InlineCode variant="extra-small">schedules.task</InlineCode> with the{" "}
404-
<InlineCode variant="extra-small">cron</InlineCode>
405-
property. They sync when you update your{" "}
406-
<InlineCode variant="extra-small">schedules.task</InlineCode> definition and run
407-
the CLI dev or deploy commands.
408-
</Paragraph>
409399
</div>
410-
<div>
411-
<div className="mb-0.5 flex items-center gap-1.5 text-sm">
412-
<div className={"flex items-center space-x-1"}>
413-
<ScheduleTypeIcon type={"IMPERATIVE"} className="text-teal-500" />
414-
<span className="font-medium">{scheduleTypeName("IMPERATIVE")}</span>
415-
</div>
400+
<Paragraph variant="small" className="!text-wrap text-text-dimmed">
401+
Declarative schedules are defined in a{" "}
402+
<InlineCode variant="extra-small">schedules.task</InlineCode> with the{" "}
403+
<InlineCode variant="extra-small">cron</InlineCode>
404+
property. They sync when you update your{" "}
405+
<InlineCode variant="extra-small">schedules.task</InlineCode> definition and run
406+
the CLI dev or deploy commands.
407+
</Paragraph>
408+
</div>
409+
<div>
410+
<div className="mb-0.5 flex items-center gap-1.5 text-sm">
411+
<div className={"flex items-center space-x-1"}>
412+
<ScheduleTypeIcon type={"IMPERATIVE"} className="text-teal-500" />
413+
<span className="font-medium">{scheduleTypeName("IMPERATIVE")}</span>
416414
</div>
417-
<Paragraph variant="small" className="!text-wrap text-text-dimmed">
418-
Imperative schedules are defined here in the dashboard or by using the SDK
419-
functions to create or delete them. They can be created, updated, disabled, and
420-
deleted from the dashboard or using the SDK.
421-
</Paragraph>
422415
</div>
423-
<LinkButton
424-
variant="docs/small"
425-
to={docsPath("v3/tasks-scheduled")}
426-
LeadingIcon={BookOpenIcon}
427-
className="mb-1"
428-
>
429-
View the docs
430-
</LinkButton>
416+
<Paragraph variant="small" className="!text-wrap text-text-dimmed">
417+
Imperative schedules are defined here in the dashboard or by using the SDK
418+
functions to create or delete them. They can be created, updated, disabled, and
419+
deleted from the dashboard or using the SDK.
420+
</Paragraph>
431421
</div>
432-
}
433-
>
434-
Type
435-
</TableHeaderCell>
436-
<TableHeaderCell>External ID</TableHeaderCell>
437-
<TableHeaderCell>CRON</TableHeaderCell>
438-
<TableHeaderCell hiddenLabel>CRON description</TableHeaderCell>
439-
<TableHeaderCell>Timezone</TableHeaderCell>
440-
<TableHeaderCell>Next run</TableHeaderCell>
441-
<TableHeaderCell>Last run</TableHeaderCell>
442-
<TableHeaderCell>Deduplication key</TableHeaderCell>
443-
<TableHeaderCell>Environments</TableHeaderCell>
444-
<TableHeaderCell>Enabled</TableHeaderCell>
445-
</TableRow>
422+
<LinkButton
423+
variant="docs/small"
424+
to={docsPath("v3/tasks-scheduled")}
425+
LeadingIcon={BookOpenIcon}
426+
className="mb-1"
427+
>
428+
View the docs
429+
</LinkButton>
430+
</div>
431+
}
432+
>
433+
Type
434+
</TableHeaderCell>
435+
<TableHeaderCell>External ID</TableHeaderCell>
436+
<TableHeaderCell>CRON</TableHeaderCell>
437+
<TableHeaderCell hiddenLabel>CRON description</TableHeaderCell>
438+
<TableHeaderCell>Timezone</TableHeaderCell>
439+
<TableHeaderCell>Next run</TableHeaderCell>
440+
<TableHeaderCell>Last run</TableHeaderCell>
441+
<TableHeaderCell>Deduplication key</TableHeaderCell>
442+
<TableHeaderCell>Environments</TableHeaderCell>
443+
<TableHeaderCell>Enabled</TableHeaderCell>
446444
</TableHeader>
447445
<TableBody>
448446
{schedules.length === 0 ? (

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.v3.usage/route.tsx‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -207,14 +207,12 @@ export default function Page() {
207207
<>
208208
<Table>
209209
<TableHeader>
210-
<TableRow>
211-
<TableHeaderCell>Task</TableHeaderCell>
212-
<TableHeaderCell alignment="right">Runs</TableHeaderCell>
213-
<TableHeaderCell alignment="right">Average duration</TableHeaderCell>
214-
<TableHeaderCell alignment="right">Average cost</TableHeaderCell>
215-
<TableHeaderCell alignment="right">Total duration</TableHeaderCell>
216-
<TableHeaderCell alignment="right">Total cost</TableHeaderCell>
217-
</TableRow>
210+
<TableHeaderCell>Task</TableHeaderCell>
211+
<TableHeaderCell alignment="right">Runs</TableHeaderCell>
212+
<TableHeaderCell alignment="right">Average duration</TableHeaderCell>
213+
<TableHeaderCell alignment="right">Average cost</TableHeaderCell>
214+
<TableHeaderCell alignment="right">Total duration</TableHeaderCell>
215+
<TableHeaderCell alignment="right">Total cost</TableHeaderCell>
218216
</TableHeader>
219217
<TableBody>
220218
{tasks.length === 0 ? (

0 commit comments

Comments
 (0)