Skip to content

Commit 6c921c5

Browse files
committed
fix(webapp): Fix prop naming semantics
1 parent 227fc2d commit 6c921c5

File tree

1 file changed

+14
-14
lines changed
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam

1 file changed

+14
-14
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -959,7 +959,7 @@ function TimelineView({
959959
const initialTimelineDimensions = useInitialDimensions(timelineContainerRef);
960960
const minTimelineWidth = initialTimelineDimensions?.width ?? 300;
961961
const maxTimelineWidth = minTimelineWidth * 10;
962-
const disableSpansAnimations = rootSpanStatus === "executing";
962+
const disableSpansAnimations = rootSpanStatus !== "executing";
963963

964964
//we want to live-update the duration if the root span is still executing
965965
const [duration, setDuration] = useState(queueAdjustedNs(totalDuration, queuedDuration));
@@ -1131,8 +1131,8 @@ function TimelineView({
11311131
"-ml-[0.5px] h-[0.5625rem] w-px rounded-none",
11321132
eventBackgroundClassName(node.data)
11331133
)}
1134-
layoutId={disableSpansAnimations ? `${node.id}-${event.name}` : undefined}
1135-
animate={disableSpansAnimations ? undefined : false}
1134+
layoutId={disableSpansAnimations ? undefined : `${node.id}-${event.name}`}
1135+
animate={disableSpansAnimations ? false : undefined}
11361136
/>
11371137
)}
11381138
</Timeline.Point>
@@ -1150,8 +1150,8 @@ function TimelineView({
11501150
"-ml-[0.1562rem] size-[0.3125rem] rounded-full border bg-background-bright",
11511151
eventBorderClassName(node.data)
11521152
)}
1153-
layoutId={disableSpansAnimations ? `${node.id}-${event.name}` : undefined}
1154-
animate={disableSpansAnimations ? undefined : false}
1153+
layoutId={disableSpansAnimations ? undefined : `${node.id}-${event.name}`}
1154+
animate={disableSpansAnimations ? false : undefined}
11551155
/>
11561156
)}
11571157
</Timeline.Point>
@@ -1170,8 +1170,8 @@ function TimelineView({
11701170
>
11711171
<motion.div
11721172
className={cn("h-px w-full", eventBackgroundClassName(node.data))}
1173-
layoutId={disableSpansAnimations ? `mark-${node.id}` : undefined}
1174-
animate={disableSpansAnimations ? undefined : false}
1173+
layoutId={disableSpansAnimations ? undefined : `mark-${node.id}`}
1174+
animate={disableSpansAnimations ? false : undefined}
11751175
/>
11761176
</Timeline.Span>
11771177
) : null}
@@ -1209,8 +1209,8 @@ function TimelineView({
12091209
"-ml-0.5 size-3 rounded-full border-2 border-background-bright",
12101210
eventBackgroundClassName(node.data)
12111211
)}
1212-
layoutId={disableSpansAnimations ? node.id : undefined}
1213-
animate={disableSpansAnimations ? undefined : false}
1212+
layoutId={disableSpansAnimations ? undefined : node.id}
1213+
animate={disableSpansAnimations ? false : undefined}
12141214
/>
12151215
)}
12161216
</Timeline.Point>
@@ -1454,8 +1454,8 @@ function SpanWithDuration({
14541454
fadeLeft ? "rounded-r-sm bg-gradient-to-r from-black/50 to-transparent" : "rounded-sm"
14551455
)}
14561456
style={{ backgroundSize: "20px 100%", backgroundRepeat: "no-repeat" }}
1457-
layoutId={disableAnimations ? node.id : undefined}
1458-
animate={disableAnimations ? undefined : false}
1457+
layoutId={disableAnimations ? undefined : node.id}
1458+
animate={disableAnimations ? false : undefined}
14591459
>
14601460
{node.data.isPartial && (
14611461
<div
@@ -1468,12 +1468,12 @@ function SpanWithDuration({
14681468
"sticky left-0 z-10 transition-opacity group-hover:opacity-100",
14691469
!showDuration && "opacity-0"
14701470
)}
1471-
animate={disableAnimations ? undefined : false}
1471+
animate={disableAnimations ? false : undefined}
14721472
>
14731473
<motion.div
14741474
className="whitespace-nowrap rounded-sm px-1 py-0.5 text-xxs text-text-bright text-shadow-custom"
1475-
layout={disableAnimations ? "position" : undefined}
1476-
animate={disableAnimations ? undefined : false}
1475+
layout={disableAnimations ? undefined : "position"}
1476+
animate={disableAnimations ? false : undefined}
14771477
>
14781478
{formatDurationMilliseconds(props.durationMs, {
14791479
style: "short",

0 commit comments

Comments
 (0)