fix(webapp): treat EXPIRED runs as failed in trace reconciliation

Author: bharathkumar39293

apps/webapp/app/presenters/v3/reconcileTrace.server.test.ts

@@ -90,6 +90,16 @@ describe("reconcileTraceWithRunLifecycle", () => {
         expect(rootEvent?.data.isPartial).toBe(false);
     });
 
+    it("should reconcile expired runs correctly", () => {
+        const expiredRun = { ...runData, status: "EXPIRED" };
+        const result = reconcileTraceWithRunLifecycle(expiredRun, rootSpanId, initialEvents as any, millisecondsToNanoseconds(1000));
+
+        expect(result.rootSpanStatus).toBe("failed");
+        const rootEvent = result.events.find((e: any) => e.id === rootSpanId);
+        expect(rootEvent?.data.isError).toBe(true);
+        expect(rootEvent?.data.isPartial).toBe(false);
+    });
+
     it("should use rootTaskRun createdAt if available for duration calculation", () => {
         const rootTaskCreatedAt = new Date("2023-12-31T23:59:50Z"); // 10s before run.createdAt
         const runDataWithRoot: any = {

apps/webapp/app/presenters/v3/reconcileTrace.server.ts

@@ -61,6 +61,8 @@ export function reconcileTraceWithRunLifecycle(
 
     const updatedTotalDuration = Math.max(totalDuration, postgresRunDuration);
 
+    const isError = isFailedRunStatus(runData.status) || runData.status === "EXPIRED";
+
     // We only need to potentially update the root event (the first one) if it matches our ID
     if (isActualRoot && rootEvent && rootEvent.data.isPartial) {
         const updatedEvents = [...events];
@@ -70,20 +72,20 @@ export function reconcileTraceWithRunLifecycle(
                 ...rootEvent.data,
                 isPartial: false,
                 duration: Math.max(rootEvent.data.duration ?? 0, postgresRunDuration),
-                isError: isFailedRunStatus(runData.status),
+                isError,
             },
         };
 
         return {
             events: updatedEvents,
             totalDuration: updatedTotalDuration,
-            rootSpanStatus: isFailedRunStatus(runData.status) ? "failed" : "completed",
+            rootSpanStatus: isError ? "failed" : "completed",
         };
     }
 
     return {
         events,
         totalDuration: updatedTotalDuration,
-        rootSpanStatus: isFailedRunStatus(runData.status) ? "failed" : "completed",
+        rootSpanStatus: isError ? "failed" : "completed",
     };
 }