crashEvent isn't used anymore

Author: ericallam

apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts

@@ -810,14 +810,6 @@ export class ClickhouseEventRepository implements IEventRepository {
     this.addToBatch(event);
   }
 
-  async crashEvent(params: {
-    event: TaskEventRecord;
-    crashedAt: Date;
-    exception: ExceptionEventProperties;
-  }): Promise<void> {
-    throw new Error("ClickhouseEventRepository.crashEvent not implemented");
-  }
-
   // Query methods
   async getTraceSummary(
     storeTable: TaskEventStoreTable,
@@ -847,6 +839,8 @@ export class ClickhouseEventRepository implements IEventRepository {
       queryBuilder.where("kind != {kind: String}", { kind: "DEBUG_EVENT" });
     }
 
+    queryBuilder.orderBy("start_time ASC");
+
     const { query, params } = queryBuilder.build();
 
     logger.debug("ClickhouseEventRepository.getTraceSummary query", {

apps/webapp/app/v3/eventRepository/eventRepository.server.ts

@@ -415,42 +415,6 @@ export class EventRepository implements IEventRepository {
     });
   }
 
-  async crashEvent({
-    event,
-    crashedAt,
-    exception,
-  }: {
-    event: TaskEventRecord;
-    crashedAt: Date;
-    exception: ExceptionEventProperties;
-  }) {
-    if (!event.isPartial) {
-      return;
-    }
-
-    await this.insertImmediate({
-      ...omit(event, "id"),
-      isPartial: false,
-      isError: true,
-      isCancelled: false,
-      status: "ERROR",
-      events: [
-        {
-          name: "exception",
-          time: crashedAt,
-          properties: {
-            exception,
-          },
-        } satisfies ExceptionSpanEvent,
-        ...((event.events as any[]) ?? []),
-      ],
-      duration: calculateDurationFromStart(event.startTime, crashedAt),
-      properties: event.properties as Attributes,
-      metadata: event.metadata as Attributes,
-      style: event.style as Attributes,
-    });
-  }
-
   public async getTraceSummary(
     storeTable: TaskEventStoreTable,
     environmentId: string,

apps/webapp/app/v3/eventRepository/eventRepository.types.ts

@@ -326,12 +326,6 @@ export interface IEventRepository {
     cancelledAt: Date;
   }): Promise<void>;
 
-  crashEvent(params: {
-    event: TaskEventRecord;
-    crashedAt: Date;
-    exception: ExceptionEventProperties;
-  }): Promise<void>;
-
   // Query methods
   getTraceSummary(
     storeTable: TaskEventStoreTable,

references/hello-world/src/trigger/init.ts

@@ -1,10 +1,10 @@
 import { logger, tasks } from "@trigger.dev/sdk";
 // import { setDb } from "../db.js";
 
-tasks.middleware("db", ({ ctx, payload, next }) => {
-  logger.info("Hello, world from the middleware", { ctx, payload });
-  return next();
-});
+// tasks.middleware("db", ({ ctx, payload, next }) => {
+//   logger.info("Hello, world from the middleware", { ctx, payload });
+//   return next();
+// });
 
 tasks.onCancel(async ({ ctx, payload }) => {
   logger.info("Hello, world from the global cancel", { ctx, payload });

references/hello-world/src/trigger/telemetry.ts

@@ -4,14 +4,30 @@ import { setTimeout } from "timers/promises";
 export const simpleSuccessTask = task({
   id: "otel/simple-success-task",
   run: async (payload: any, { ctx }) => {
-    logger.debug("Hello debug");
-    logger.log("Hello log");
-    logger.info("Hello info");
-    logger.warn("Hello warn");
-    logger.error("Hello error");
+    logger.log("Hello log 1");
+    logger.info("Hello info 1");
+    logger.warn("Hello warn 1");
+    logger.error("Hello error 1");
 
     await setTimeout(5000);
 
+    logger.log("Hello log 2");
+    logger.info("Hello info 2");
+    logger.warn("Hello warn 2");
+    logger.error("Hello error 2");
+
     return { message: "Hello, world!" };
   },
 });
+
+export const simpleFailureTask = task({
+  id: "otel/simple-failure-task",
+  retry: {
+    maxAttempts: 1,
+  },
+  run: async (payload: any, { ctx }) => {
+    await setTimeout(5000);
+
+    throw new Error("Hello error");
+  },
+});