support debug logs

Author: ericallam

apps/webapp/app/env.server.ts

@@ -1121,6 +1121,7 @@ const EnvironmentSchema = z
     EVENTS_CLICKHOUSE_BATCH_SIZE: z.coerce.number().int().default(1000),
     EVENTS_CLICKHOUSE_FLUSH_INTERVAL_MS: z.coerce.number().int().default(1000),
     EVENT_REPOSITORY_DEFAULT_STORE: z.enum(["postgres", "clickhouse"]).default("postgres"),
+    EVENTS_CLICKHOUSE_MAX_TRACE_SUMMARY_VIEW_COUNT: z.coerce.number().int().default(250_000),
 
     // Bootstrap
     TRIGGER_BOOTSTRAP_ENABLED: z.string().default("0"),

apps/webapp/app/presenters/v3/RunPresenter.server.ts

@@ -3,7 +3,7 @@ import { createTreeFromFlatItems, flattenTree } from "~/components/primitives/Tr
 import { prisma, type PrismaClient } from "~/db.server";
 import { createTimelineSpanEventsFromSpanEvents } from "~/utils/timelineSpanEvents";
 import { getUsername } from "~/utils/username";
-import { resolveEventRepositoryForStore } from "~/v3/eventRepository";
+import { resolveEventRepositoryForStore } from "~/v3/eventRepository/index.server";
 import { SpanSummary } from "~/v3/eventRepository/eventRepository.types";
 import { getTaskEventStoreTableForRun } from "~/v3/taskEventStore.server";
 import { isFinalRunStatus } from "~/v3/taskStatus";

apps/webapp/app/presenters/v3/SpanPresenter.server.ts

@@ -17,7 +17,7 @@ import { isFailedRunStatus, isFinalRunStatus } from "~/v3/taskStatus";
 import { BasePresenter } from "./basePresenter.server";
 import { WaitpointPresenter } from "./WaitpointPresenter.server";
 import { engine } from "~/v3/runEngine.server";
-import { resolveEventRepositoryForStore } from "~/v3/eventRepository";
+import { resolveEventRepositoryForStore } from "~/v3/eventRepository/index.server";
 import { IEventRepository, SpanDetail } from "~/v3/eventRepository/eventRepository.types";
 
 type Result = Awaited<ReturnType<SpanPresenter["call"]>>;
@@ -492,7 +492,6 @@ export class SpanPresenter extends BasePresenter {
       isPartial: span.isPartial,
       isCancelled: span.isCancelled,
       level: span.level,
-      kind: span.kind,
       startTime: span.startTime,
       duration: span.duration,
       events: span.events,

apps/webapp/app/routes/engine.v1.dev.runs.$runFriendlyId.logs.debug.ts

@@ -1,79 +1,3 @@
-import { TypedResponse } from "@remix-run/server-runtime";
-import { assertExhaustive } from "@trigger.dev/core/utils";
-import { RunId } from "@trigger.dev/core/v3/isomorphic";
-import {
-  WorkerApiDebugLogBody,
-  WorkerApiRunAttemptStartResponseBody,
-} from "@trigger.dev/core/v3/workers";
-import { z } from "zod";
-import { prisma } from "~/db.server";
-import { logger } from "~/services/logger.server";
-import { createActionApiRoute } from "~/services/routeBuilders/apiBuilder.server";
-import { recordRunDebugLog } from "~/v3/eventRepository/eventRepository.server";
-
-// const { action } = createActionApiRoute(
-//   {
-//     params: z.object({
-//       runFriendlyId: z.string(),
-//     }),
-//     body: WorkerApiDebugLogBody,
-//     method: "POST",
-//   },
-//   async ({
-//     authentication,
-//     body,
-//     params,
-//   }): Promise<TypedResponse<WorkerApiRunAttemptStartResponseBody>> => {
-//     const { runFriendlyId } = params;
-
-//     try {
-//       const run = await prisma.taskRun.findFirst({
-//         where: {
-//           friendlyId: params.runFriendlyId,
-//           runtimeEnvironmentId: authentication.environment.id,
-//         },
-//       });
-
-//       if (!run) {
-//         throw new Response("You don't have permissions for this run", { status: 401 });
-//       }
-
-//       const eventResult = await recordRunDebugLog(
-//         RunId.fromFriendlyId(runFriendlyId),
-//         body.message,
-//         {
-//           attributes: {
-//             properties: body.properties,
-//           },
-//           startTime: body.time,
-//         }
-//       );
-
-//       if (eventResult.success) {
-//         return new Response(null, { status: 204 });
-//       }
-
-//       switch (eventResult.code) {
-//         case "FAILED_TO_RECORD_EVENT":
-//           return new Response(null, { status: 400 }); // send a 400 to prevent retries
-//         case "RUN_NOT_FOUND":
-//           return new Response(null, { status: 404 });
-//         default:
-//           return assertExhaustive(eventResult.code);
-//       }
-//     } catch (error) {
-//       logger.error("Failed to record dev log", {
-//         environmentId: authentication.environment.id,
-//         error,
-//       });
-//       throw error;
-//     }
-//   }
-// );
-
-// export { action };
-
-// Create a generic JSON action in remix
 export function action() {
   return new Response(null, { status: 204 });
 }

apps/webapp/app/routes/engine.v1.worker-actions.runs.$runFriendlyId.logs.debug.ts

@@ -3,7 +3,7 @@ import { RunId } from "@trigger.dev/core/v3/isomorphic";
 import { WorkerApiDebugLogBody } from "@trigger.dev/core/v3/runEngineWorker";
 import { z } from "zod";
 import { createActionWorkerApiRoute } from "~/services/routeBuilders/apiBuilder.server";
-import { recordRunDebugLog } from "~/v3/eventRepository/eventRepository.server";
+import { recordRunDebugLog } from "~/v3/eventRepository/index.server";
 
 export const action = createActionWorkerApiRoute(
   {

apps/webapp/app/v3/eventRepository/clickhouseEventRepository.server.ts

@@ -62,6 +62,7 @@ export type ClickhouseEventRepositoryConfig = {
   batchSize?: number;
   flushInterval?: number;
   tracer?: Tracer;
+  maximumTraceSummaryViewCount?: number;
 };
 
 /**
@@ -886,6 +887,10 @@ export class ClickhouseEventRepository implements IEventRepository {
 
     queryBuilder.orderBy("start_time ASC");
 
+    if (this._config.maximumTraceSummaryViewCount) {
+      queryBuilder.limit(this._config.maximumTraceSummaryViewCount);
+    }
+
     const { query, params } = queryBuilder.build();
 
     logger.debug("ClickhouseEventRepository.getTraceSummary query", {

apps/webapp/app/v3/eventRepository/clickhouseEventRepositoryInstance.server.ts

@@ -39,6 +39,7 @@ function initializeClickhouseRepository() {
     clickhouse: clickhouse,
     batchSize: env.EVENTS_CLICKHOUSE_BATCH_SIZE,
     flushInterval: env.EVENTS_CLICKHOUSE_FLUSH_INTERVAL_MS,
+    maximumTraceSummaryViewCount: env.EVENTS_CLICKHOUSE_MAX_TRACE_SUMMARY_VIEW_COUNT,
   });
 
   return repository;

apps/webapp/app/v3/eventRepository/eventRepository.server.ts

@@ -1822,119 +1822,6 @@ export function rehydrateAttribute<T extends AttributeValue>(
   return value as T;
 }
 
-export async function findRunForEventCreation(runId: string) {
-  return prisma.taskRun.findFirst({
-    where: {
-      id: runId,
-    },
-    select: {
-      friendlyId: true,
-      taskIdentifier: true,
-      traceContext: true,
-      runtimeEnvironment: {
-        select: {
-          id: true,
-          type: true,
-          organizationId: true,
-          projectId: true,
-          project: {
-            select: {
-              externalRef: true,
-            },
-          },
-        },
-      },
-    },
-  });
-}
-
-export async function recordRunEvent(
-  runId: string,
-  message: string,
-  options: Omit<TraceEventOptions, "environment" | "taskSlug" | "startTime"> & {
-    duration?: number;
-    parentId?: string;
-    startTime?: Date;
-  }
-): Promise<
-  | {
-      success: true;
-    }
-  | {
-      success: false;
-      code: "RUN_NOT_FOUND" | "FAILED_TO_RECORD_EVENT";
-      error?: unknown;
-    }
-> {
-  try {
-    const foundRun = await findRunForEventCreation(runId);
-
-    if (!foundRun) {
-      logger.error("Failed to find run for event creation", { runId });
-      return {
-        success: false,
-        code: "RUN_NOT_FOUND",
-      };
-    }
-
-    const { attributes, startTime, ...optionsRest } = options;
-
-    await eventRepository.recordEvent(message, {
-      environment: foundRun.runtimeEnvironment,
-      taskSlug: foundRun.taskIdentifier,
-      context: foundRun.traceContext as Record<string, string | undefined>,
-      attributes: {
-        runId: foundRun.friendlyId,
-        ...attributes,
-      },
-      startTime: BigInt((startTime?.getTime() ?? Date.now()) * 1_000_000),
-      ...optionsRest,
-    });
-
-    return {
-      success: true,
-    };
-  } catch (error) {
-    logger.error("Failed to record event for run", {
-      error: error instanceof Error ? error.message : error,
-      runId,
-    });
-
-    return {
-      success: false,
-      code: "FAILED_TO_RECORD_EVENT",
-      error,
-    };
-  }
-}
-
-export async function recordRunDebugLog(
-  runId: string,
-  message: string,
-  options: Omit<TraceEventOptions, "environment" | "taskSlug" | "startTime"> & {
-    duration?: number;
-    parentId?: string;
-    startTime?: Date;
-  }
-): Promise<
-  | {
-      success: true;
-    }
-  | {
-      success: false;
-      code: "RUN_NOT_FOUND" | "FAILED_TO_RECORD_EVENT";
-      error?: unknown;
-    }
-> {
-  return recordRunEvent(runId, message, {
-    ...options,
-    attributes: {
-      ...options?.attributes,
-      isDebug: true,
-    },
-  });
-}
-
 /**
  * Extracts error details from Prisma errors in a type-safe way.
  * Only includes 'code' property for PrismaClientKnownRequestError.