minify and autoDetectExternal (true now)

Author: matt-aitken

packages/cli-v3/src/build/bundle.ts

@@ -180,7 +180,10 @@ async function createBuildOptions(
     options.resolvedConfig.build?.keepNames ??
     options.resolvedConfig.build?.experimental_keepNames ??
     true;
-  const minify = options.resolvedConfig.build?.experimental_minify ?? false;
+  const minify =
+    options.resolvedConfig.build?.minify ??
+    options.resolvedConfig.build?.experimental_minify ??
+    false;
 
   const $buildPlugins = await buildPlugins(options.target, options.resolvedConfig);
 

packages/cli-v3/src/build/externals.ts

@@ -159,11 +159,16 @@ function createExternalsCollector(
           isExternalCache.clear();
         });
 
+        const autoDetectExternal =
+          resolvedConfig.build?.autoDetectExternal ??
+          resolvedConfig.build?.experimental_autoDetectExternal ??
+          true;
+
         build.onEnd(async () => {
           logger.debug("[externals][onEnd] Collected externals", {
             externals,
             maybeExternals,
-            autoDetectExternal: !!resolvedConfig.build?.experimental_autoDetectExternal,
+            autoDetectExternal,
             packageJsonCache: packageJsonCache.size,
             isExternalCache: isExternalCache.size,
           });
@@ -265,7 +270,7 @@ function createExternalsCollector(
           });
         });
 
-        if (resolvedConfig.build?.experimental_autoDetectExternal) {
+        if (autoDetectExternal) {
           build.onResolve(
             { filter: /.*/, namespace: "file" },
             async (args: esbuild.OnResolveArgs): Promise<esbuild.OnResolveResult | undefined> => {

packages/core/src/v3/config.ts

@@ -171,23 +171,24 @@ export type TriggerConfig = {
     external?: string[];
 
     /**
-     * **WARNING: This is an experimental feature and might be removed in a future version.**
+     * This still works but use `autoDetectExternal` instead.
      *
+     * @deprecated (use autoDetectExternal instead)
+     */
+    experimental_autoDetectExternal?: boolean;
+
+    /**
      * Automatically detect dependencies that shouldn't be bundled and mark them as external. For example, native modules.
      *
-     * Turning this on will not affect dependencies that were manually added to the `external` array.
+     * Turn this off if you are having issues and want to manually specify all `external` dependencies.
      *
-     * @default false
-     *
-     * @deprecated (experimental)
+     * @default true
      */
-    experimental_autoDetectExternal?: boolean;
+    autoDetectExternal?: boolean;
 
     /**
      * This still works but use `keepNames` instead.
      *
-     * @default true
-     *
      * @deprecated (use keepNames instead)
      */
     experimental_keepNames?: boolean;
@@ -201,6 +202,13 @@ export type TriggerConfig = {
      */
     keepNames?: boolean;
 
+    /**
+     * This still works but use `minify` instead.
+     *
+     * @deprecated (use minify instead)
+     */
+    experimental_minify?: boolean;
+
     /**
      * **WARNING: This is an experimental feature and might be removed in a future version.**
      *
@@ -211,10 +219,8 @@ export type TriggerConfig = {
      * @link https://esbuild.github.io/api/#minify
      *
      * @default false
-     *
-     * @deprecated (experimental)
      */
-    experimental_minify?: boolean;
+    minify?: boolean;
 
     jsx?: {
       /**