Skip to content

Commit b384dad

Browse files
committed
remove dead code
1 parent f579afb commit b384dad

File tree

5 files changed

+0
-101
lines changed

5 files changed

+0
-101
lines changed

packages/cli-v3/src/entryPoints/dev-run-worker.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -452,18 +452,9 @@ const zodIpc = new ZodIpcConnection({
452452
});
453453
}
454454
},
455-
TASK_RUN_COMPLETED_NOTIFICATION: async () => {
456-
await managedWorkerRuntime.completeWaitpoints([]);
457-
},
458-
WAIT_COMPLETED_NOTIFICATION: async () => {
459-
await managedWorkerRuntime.completeWaitpoints([]);
460-
},
461455
FLUSH: async ({ timeoutInMs }, sender) => {
462456
await flushAll(timeoutInMs);
463457
},
464-
WAITPOINT_CREATED: async ({ wait, waitpoint }) => {
465-
managedWorkerRuntime.associateWaitWithWaitpoint(wait.id, waitpoint.id);
466-
},
467458
WAITPOINT_COMPLETED: async ({ waitpoint }) => {
468459
managedWorkerRuntime.completeWaitpoints([waitpoint]);
469460
},

packages/cli-v3/src/entryPoints/managed-run-worker.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -445,18 +445,9 @@ const zodIpc = new ZodIpcConnection({
445445
});
446446
}
447447
},
448-
TASK_RUN_COMPLETED_NOTIFICATION: async () => {
449-
await managedWorkerRuntime.completeWaitpoints([]);
450-
},
451-
WAIT_COMPLETED_NOTIFICATION: async () => {
452-
await managedWorkerRuntime.completeWaitpoints([]);
453-
},
454448
FLUSH: async ({ timeoutInMs }, sender) => {
455449
await flushAll(timeoutInMs);
456450
},
457-
WAITPOINT_CREATED: async ({ wait, waitpoint }) => {
458-
managedWorkerRuntime.associateWaitWithWaitpoint(wait.id, waitpoint.id);
459-
},
460451
WAITPOINT_COMPLETED: async ({ waitpoint }) => {
461452
managedWorkerRuntime.completeWaitpoints([waitpoint]);
462453
},

packages/cli-v3/src/executions/taskRunProcess.ts

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -278,56 +278,6 @@ export class TaskRunProcess {
278278
return result;
279279
}
280280

281-
taskRunCompletedNotification(completion: TaskRunExecutionResult) {
282-
if (!completion.ok && typeof completion.retry !== "undefined") {
283-
logger.debug(
284-
"Task run completed with error and wants to retry, won't send task run completed notification"
285-
);
286-
return;
287-
}
288-
289-
if (!this._child?.connected || this._isBeingKilled || this._child.killed) {
290-
logger.debug(
291-
"Child process not connected or being killed, can't send task run completed notification"
292-
);
293-
return;
294-
}
295-
296-
this._ipc?.send("TASK_RUN_COMPLETED_NOTIFICATION", {
297-
version: "v2",
298-
completion,
299-
});
300-
}
301-
302-
waitCompletedNotification() {
303-
if (!this._child?.connected || this._isBeingKilled || this._child.killed) {
304-
console.error(
305-
"Child process not connected or being killed, can't send wait completed notification"
306-
);
307-
return;
308-
}
309-
310-
this._ipc?.send("WAIT_COMPLETED_NOTIFICATION", {});
311-
}
312-
313-
waitpointCreated(waitId: string, waitpointId: string) {
314-
if (!this._child?.connected || this._isBeingKilled || this._child.killed) {
315-
console.error(
316-
"Child process not connected or being killed, can't send waitpoint created notification"
317-
);
318-
return;
319-
}
320-
321-
this._ipc?.send("WAITPOINT_CREATED", {
322-
wait: {
323-
id: waitId,
324-
},
325-
waitpoint: {
326-
id: waitpointId,
327-
},
328-
});
329-
}
330-
331281
waitpointCompleted(waitpoint: CompletedWaitpoint) {
332282
if (!this._child?.connected || this._isBeingKilled || this._child.killed) {
333283
console.error(

packages/core/src/v3/runtime/managedRuntimeManager.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,6 @@ export class ManagedRuntimeManager implements RuntimeManager {
146146
});
147147
}
148148

149-
associateWaitWithWaitpoint(waitId: string, waitpointId: string) {
150-
this.resolversByWaitpoint.set(waitpointId, waitId);
151-
}
152-
153149
async completeWaitpoints(waitpoints: CompletedWaitpoint[]): Promise<void> {
154150
await Promise.all(waitpoints.map((waitpoint) => this.completeWaitpoint(waitpoint)));
155151
}

packages/core/src/v3/schemas/messages.ts

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -219,41 +219,12 @@ export const WorkerToExecutorMessageCatalog = {
219219
isWarmStart: z.boolean().optional(),
220220
}),
221221
},
222-
TASK_RUN_COMPLETED_NOTIFICATION: {
223-
message: z.discriminatedUnion("version", [
224-
z.object({
225-
version: z.literal("v1"),
226-
completion: TaskRunExecutionResult,
227-
execution: TaskRunExecution,
228-
}),
229-
z.object({
230-
version: z.literal("v2"),
231-
completion: TaskRunExecutionResult,
232-
}),
233-
]),
234-
},
235-
WAIT_COMPLETED_NOTIFICATION: {
236-
message: z.object({
237-
version: z.literal("v1").default("v1"),
238-
}),
239-
},
240222
FLUSH: {
241223
message: z.object({
242224
timeoutInMs: z.number(),
243225
}),
244226
callback: z.void(),
245227
},
246-
WAITPOINT_CREATED: {
247-
message: z.object({
248-
version: z.literal("v1").default("v1"),
249-
wait: z.object({
250-
id: z.string(),
251-
}),
252-
waitpoint: z.object({
253-
id: z.string(),
254-
}),
255-
}),
256-
},
257228
WAITPOINT_COMPLETED: {
258229
message: z.object({
259230
version: z.literal("v1").default("v1"),

0 commit comments

Comments
 (0)