Fixed metrics, reusing a process counts as a warm start

Author: ericallam

packages/cli-v3/src/entryPoints/dev-run-worker.ts

@@ -273,7 +273,10 @@ const zodIpc = new ZodIpcConnection({
   emitSchema: ExecutorToWorkerMessageCatalog,
   process,
   handlers: {
-    EXECUTE_TASK_RUN: async ({ execution, traceContext, metadata, metrics, env }, sender) => {
+    EXECUTE_TASK_RUN: async (
+      { execution, traceContext, metadata, metrics, env, isWarmStart },
+      sender
+    ) => {
       if (env) {
         populateEnv(env, {
           override: true,
@@ -294,7 +297,7 @@ const zodIpc = new ZodIpcConnection({
 
       resetExecutionEnvironment();
 
-      standardRunTimelineMetricsManager.registerMetricsFromExecution(metrics);
+      standardRunTimelineMetricsManager.registerMetricsFromExecution(metrics, isWarmStart);
 
       if (_isRunning) {
         logError("Worker is already running a task");
@@ -437,6 +440,7 @@ const zodIpc = new ZodIpcConnection({
           tracingSDK,
           consoleInterceptor,
           retries: config.retries,
+          isWarmStart,
         });
 
         try {

packages/cli-v3/src/entryPoints/managed-run-worker.ts

@@ -259,7 +259,7 @@ const zodIpc = new ZodIpcConnection({
         triggerJWT: getEnvVar("TRIGGER_JWT"),
       });
 
-      standardRunTimelineMetricsManager.registerMetricsFromExecution(metrics);
+      standardRunTimelineMetricsManager.registerMetricsFromExecution(metrics, isWarmStart);
 
       console.log(`[${new Date().toISOString()}] Received EXECUTE_TASK_RUN`, execution);
 

packages/core/src/v3/otel/tracingSDK.ts

@@ -74,8 +74,6 @@ class AsyncResourceDetector implements DetectorSync {
       return;
     }
 
-    console.log("resolving async resource detector", attributes);
-
     this._resolved = true;
     this._resolver(attributes);
   }

packages/core/src/v3/runTimelineMetrics/runTimelineMetricsManager.ts

@@ -13,8 +13,11 @@ export class StandardRunTimelineMetricsManager implements RunTimelineMetricsMana
     return this._metrics;
   }
 
-  registerMetricsFromExecution(metrics?: TaskRunExecutionMetrics): void {
-    this.#seedMetricsFromEnvironment();
+  registerMetricsFromExecution(
+    metrics?: TaskRunExecutionMetrics,
+    isWarmStartOverride?: boolean
+  ): void {
+    this.#seedMetricsFromEnvironment(isWarmStartOverride);
 
     if (metrics) {
       metrics.forEach((metric) => {
@@ -35,10 +38,11 @@ export class StandardRunTimelineMetricsManager implements RunTimelineMetricsMana
   }
 
   // TODO: handle this when processKeepAlive is enabled
-  #seedMetricsFromEnvironment() {
+  #seedMetricsFromEnvironment(isWarmStartOverride?: boolean) {
     const forkStartTime = getEnvVar("TRIGGER_PROCESS_FORK_START_TIME");
     const warmStart = getEnvVar("TRIGGER_WARM_START");
-    const isWarmStart = warmStart === "true";
+    const isWarmStart =
+      typeof isWarmStartOverride === "boolean" ? isWarmStartOverride : warmStart === "true";
 
     if (typeof forkStartTime === "string" && !isWarmStart) {
       const forkStartTimeMs = parseInt(forkStartTime, 10);