fix a few things

Author: ericallam

packages/cli-v3/src/build/manifests.ts

@@ -4,6 +4,7 @@ import { createHash } from "node:crypto";
 import { existsSync } from "node:fs";
 import { join } from "node:path";
 import { logger } from "../utilities/logger.js";
+import { sanitizeHashForFilename } from "../utilities/fileSystem.js";
 
 export async function copyManifestToDir(
   manifest: BuildManifest,
@@ -47,14 +48,6 @@ export async function copyManifestToDir(
   return updatedManifest;
 }
 
-/**
- * Sanitizes a hash to be safe for use as a filename.
- * esbuild's hashes are base64-encoded and may contain `/` and `+` characters.
- */
-function sanitizeHashForFilename(hash: string): string {
-  return hash.replace(/\//g, "_").replace(/\+/g, "-");
-}
-
 /**
  * Computes a hash of file contents to use as content-addressable key.
  * This is a fallback for when outputHashes is not available.
@@ -99,7 +92,16 @@ async function copyDirWithStore(
 
       if (existsSync(storePath)) {
         // Create hardlink to store file
-        await link(storePath, destPath);
+        // Fall back to copy if hardlink fails (e.g., on Windows or cross-device)
+        try {
+          await link(storePath, destPath);
+        } catch (linkError) {
+          try {
+            await cp(storePath, destPath);
+          } catch (copyError) {
+            throw linkError; // Rethrow original error if copy also fails
+          }
+        }
       } else {
         // File wasn't in the store - copy normally
         await cp(sourcePath, destPath);

packages/cli-v3/src/utilities/fileSystem.ts

@@ -20,7 +20,7 @@ export async function createFile(
  * Sanitizes a hash to be safe for use as a filename.
  * esbuild's hashes are base64-encoded and may contain `/` and `+` characters.
  */
-function sanitizeHashForFilename(hash: string): string {
+export function sanitizeHashForFilename(hash: string): string {
   return hash.replace(/\//g, "_").replace(/\+/g, "-");
 }
 
@@ -57,14 +57,32 @@ export async function createFileWithStore(
   // Check if content already exists in store by hash
   if (fsSync.existsSync(storePath)) {
     // Create hardlink from build path to store path
-    await fsModule.link(storePath, filePath);
+    // Fall back to copy if hardlink fails (e.g., on Windows or cross-device)
+    try {
+      await fsModule.link(storePath, filePath);
+    } catch (linkError) {
+      try {
+        await fsModule.copyFile(storePath, filePath);
+      } catch (copyError) {
+        throw linkError; // Rethrow original error if copy also fails
+      }
+    }
     return filePath;
   }
 
   // Write to store first (using hash as filename)
   await fsModule.writeFile(storePath, contents);
   // Create hardlink in build directory (with original filename)
-  await fsModule.link(storePath, filePath);
+  // Fall back to copy if hardlink fails (e.g., on Windows or cross-device)
+  try {
+    await fsModule.link(storePath, filePath);
+  } catch (linkError) {
+    try {
+      await fsModule.copyFile(storePath, filePath);
+    } catch (copyError) {
+      throw linkError; // Rethrow original error if copy also fails
+    }
+  }
 
   return filePath;
 }