refactor(webapp): enhance runsRepositoryFactory to accept options for replication and ClickHouse configuration

Author: LeoKaynan

apps/webapp/app/services/runsRepositoryFactory.server.ts

@@ -6,16 +6,19 @@ import { RunsRepository } from "./runsRepository/runsRepository.server";
 export function createRunsRepository(options: {
   clickhouse: ClickHouse;
   prisma: PrismaClient;
+  isReplicationEnabled?: boolean;
+  isClickHouseConfigured?: boolean;
 }): RunsRepository {
-  const isReplicationEnabled = env.RUN_REPLICATION_ENABLED === "1";
-  const isClickHouseConfigured = !!env.RUN_REPLICATION_CLICKHOUSE_URL;
+  const isReplicationEnabled = options.isReplicationEnabled ?? env.RUN_REPLICATION_ENABLED === "1";
+  const isClickHouseConfigured = options.isClickHouseConfigured ?? !!env.RUN_REPLICATION_CLICKHOUSE_URL;
 
   const defaultRepository = isReplicationEnabled && isClickHouseConfigured 
     ? "clickhouse" 
     : "postgres";
 
   return new RunsRepository({
-    ...options,
+    clickhouse: options.clickhouse,
+    prisma: options.prisma,
     defaultRepository,
   });
 }

apps/webapp/test/runsRepositoryFactory.test.ts

@@ -1,7 +1,15 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+import { describe, it, expect, vi } from "vitest";
+
 vi.mock("~/env.server", () => ({
-  env: {},
+  env: {
+    RUN_REPLICATION_ENABLED: "0",
+    RUN_REPLICATION_CLICKHOUSE_URL: undefined,
+    DATABASE_CONNECTION_LIMIT: 10,
+    DATABASE_POOL_TIMEOUT: 60,
+    DATABASE_CONNECTION_TIMEOUT: 20,
+  },
 }));
+
 vi.mock("~/db.server", () => ({
   prisma: {},
   $replica: {},
@@ -12,69 +20,51 @@ import type { ClickHouse } from "@internal/clickhouse";
 import type { PrismaClient } from "@trigger.dev/database";
 
 describe("createRunsRepository", () => {
-  let mockClickhouse: ClickHouse;
-  let mockPrisma: PrismaClient;
-  let originalEnv: Record<string, unknown>;
-
-  beforeEach(async () => {
-    const envModule = await import("~/env.server");
-    originalEnv = { ...envModule.env };
-
-    mockClickhouse = {} as ClickHouse;
-    mockPrisma = {} as PrismaClient;
-  });
-
-  afterEach(async () => {
-    const envModule = await import("~/env.server");
-    Object.assign(envModule.env, originalEnv);
-  });
-
-  it("should default to postgres when RUN_REPLICATION_ENABLED is not set", async () => {
-    const envModule = await import("~/env.server");
-    envModule.env.RUN_REPLICATION_ENABLED = "0";
-    envModule.env.RUN_REPLICATION_CLICKHOUSE_URL = "http://localhost:8123";
+  const mockClickhouse = {} as ClickHouse;
+  const mockPrisma = {} as PrismaClient;
 
+  it("should default to postgres when replication is disabled", () => {
     const repository = createRunsRepository({
       clickhouse: mockClickhouse,
       prisma: mockPrisma,
+      isReplicationEnabled: false,
+      isClickHouseConfigured: true,
     });
 
     expect(repository).toBeDefined();
     expect(repository.listRuns).toBeDefined();
   });
 
-  it("should default to postgres when RUN_REPLICATION_CLICKHOUSE_URL is not set", async () => {
-    const envModule = await import("~/env.server");
-    envModule.env.RUN_REPLICATION_ENABLED = "1";
-    envModule.env.RUN_REPLICATION_CLICKHOUSE_URL = undefined;
-
+  it("should default to postgres when ClickHouse is not configured", () => {
     const repository = createRunsRepository({
       clickhouse: mockClickhouse,
       prisma: mockPrisma,
+      isReplicationEnabled: true,
+      isClickHouseConfigured: false,
     });
 
     expect(repository).toBeDefined();
     expect(repository.listRuns).toBeDefined();
   });
 
-  it("should default to clickhouse when both conditions are met", async () => {
-    const envModule = await import("~/env.server");
-    envModule.env.RUN_REPLICATION_ENABLED = "1";
-    envModule.env.RUN_REPLICATION_CLICKHOUSE_URL = "http://localhost:8123";
-
+  it("should default to clickhouse when both conditions are met", () => {
     const repository = createRunsRepository({
       clickhouse: mockClickhouse,
       prisma: mockPrisma,
+      isReplicationEnabled: true,
+      isClickHouseConfigured: true,
     });
 
     expect(repository).toBeDefined();
     expect(repository.listRuns).toBeDefined();
   });
 
-  it("should create a valid RunsRepository instance", () => {
+  it("should create a valid RunsRepository instance with all required methods", () => {
     const repository = createRunsRepository({
       clickhouse: mockClickhouse,
       prisma: mockPrisma,
+      isReplicationEnabled: false,
+      isClickHouseConfigured: false,
     });
 
     expect(repository.listRuns).toBeDefined();