various coderabbit fixes

Author: ericallam

apps/webapp/app/routes/api.v1.projects.$projectRef.$env.workers.$tagName.ts

@@ -112,7 +112,7 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
     runs: `${$env.APP_ORIGIN}${v3RunsPath(
       { slug: project.organization.slug },
       { slug: project.slug },
-      { slug: env },
+      { slug: runtimeEnv.slug },
       { versions: [currentWorker.version] }
     )}`,
   };

packages/cli-v3/src/commands/install-mcp.ts

@@ -1,4 +1,4 @@
-import { confirm, intro, isCancel, log, multiselect, select, spinner } from "@clack/prompts";
+import { confirm, intro, isCancel, log, multiselect, select } from "@clack/prompts";
 import chalk from "chalk";
 import { Command } from "commander";
 import { extname } from "node:path";
@@ -15,6 +15,7 @@ import {
 } from "../utilities/fileSystem.js";
 import { printStandloneInitialBanner } from "../utilities/initialBanner.js";
 import { VERSION } from "../version.js";
+import { spinner } from "../utilities/windows.js";
 
 const cliVersion = VERSION as string;
 const cliTag = cliVersion.includes("v4-beta") ? "v4-beta" : "latest";
@@ -317,7 +318,7 @@ async function installMcpServerForClient(
     return;
   }
 
-  const clientSpinner = spinner({ indicator: "dots" });
+  const clientSpinner = spinner();
 
   clientSpinner.start(`Installing in ${clientName}`);
 

packages/cli-v3/src/commands/install-rules.ts

@@ -92,7 +92,7 @@ export function configureInstallRulesCommand(program: Command) {
     .addOption(
       new CommandOption(
         "--branch <branch>",
-        "The branch to install the rules from. This is useful if you want to install the rules from a local file."
+        "The branch to install the rules from, the default is main"
       ).hideHelp()
     )
     .addOption(
@@ -152,7 +152,7 @@ type InstallRulesResult = {
 };
 
 export type InstallRulesWizardOptions = {
-  targets?: Array<(typeof targets)[number]>;
+  target?: Array<(typeof targets)[number]>;
   manifestPath?: string;
   branch?: string;
 };

packages/cli-v3/src/commands/mcp.ts

@@ -85,11 +85,15 @@ export async function mcpCommand(options: McpCommandOptions) {
 
   logger.loggerLevel = "none";
 
-  const server = new McpServer({
-    name: serverMetadata.name,
-    version: serverMetadata.version,
-    description: serverMetadata.instructions,
-  });
+  const server = new McpServer(
+    {
+      name: serverMetadata.name,
+      version: serverMetadata.version,
+    },
+    {
+      instructions: serverMetadata.instructions,
+    }
+  );
 
   server.server.oninitialized = async () => {
     fileLogger?.log("initialized mcp command", { options, argv: process.argv });

packages/cli-v3/src/commands/update.ts

@@ -342,11 +342,11 @@ export async function tryResolveTriggerPackageVersion(
     const { packageJson } = await getPackageJson(dirname(resolvedPath), {
       test: (filePath) => {
         // We need to skip any type-marker files
-        if (filePath.includes("dist/commonjs")) {
+        if (filePath.includes(join("dist", "commonjs"))) {
           return false;
         }
 
-        if (filePath.includes("dist/esm")) {
+        if (filePath.includes(join("dist", "esm"))) {
           return false;
         }
 

packages/cli-v3/src/mcp/formatters.ts

@@ -3,7 +3,7 @@ import {
   RetrieveRunResponse,
   RetrieveRunTraceResponseBody,
 } from "@trigger.dev/core/v3/schemas";
-import { CursorPageResponse } from "@trigger.dev/core/v3/zodfetch";
+import type { CursorPageResponse } from "@trigger.dev/core/v3/zodfetch";
 
 export function formatRun(run: RetrieveRunResponse): string {
   const lines: string[] = [];

packages/cli-v3/src/mcp/tools/docs.ts

@@ -1,4 +1,4 @@
-import z from "zod";
+import { z } from "zod";
 import { toolsMetadata } from "../config.js";
 import { toolHandler } from "../utils.js";
 import { performSearch } from "../mintlifyClient.js";

packages/cli-v3/src/mcp/utils.ts

@@ -1,7 +1,6 @@
 import type { CallToolResult, ServerNotification } from "@modelcontextprotocol/sdk/types.js";
-import z from "zod";
+import { z } from "zod";
 import { ToolMeta } from "./types.js";
-import { loadConfig } from "../config.js";
 
 export function respondWithError(error: unknown): CallToolResult {
   return {