Skip to content

Commit fc2b733

Browse files
committed
Switch logs printing to a simple console log in favor of tighter line spacing
1 parent ba49783 commit fc2b733

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

packages/cli-v3/src/commands/deploy.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,7 +1092,7 @@ async function handleNativeBuildServerDeploy({
10921092
case "log": {
10931093
if (record.seq_num === 0) {
10941094
$queuedSpinner.stop("Build started");
1095-
log.message("", { symbol: undefined });
1095+
console.log("│");
10961096
queuedSpinnerStopped = true;
10971097
}
10981098

@@ -1116,7 +1116,13 @@ async function handleNativeBuildServerDeploy({
11161116
? chalkGrey(message)
11171117
: message;
11181118

1119-
log.message(`${formattedTimestamp} ${formattedMessage}`, { symbol: undefined });
1119+
// We use console.log here instead of clack's logger as the current version does not support changing the line spacing.
1120+
// And the logs look verbose with the default spacing.
1121+
// We cannot upgrade because the newer versions introduced some weird issues with the spinner.
1122+
// Ideally, we'd use clack's `taskLog` to only show the recent n lines of logs as they are streamed, but that also seems brittle
1123+
// and has some issues with cursor movements/clearing lines that it shouldn't clear.
1124+
// We can revisit this on future versions of `@clack/prompts`.
1125+
console.log(`│ ${formattedTimestamp} ${formattedMessage}`);
11201126
break;
11211127
}
11221128
case "finalized": {

0 commit comments

Comments
 (0)