#50: * fix bailout tests for PHP JIT.

JIT PHP in tracing mode can compile functions on demand. When memory runs out, JIT crashes with an error because it tries to compile a closure. This code attempts to work around the issue so that the test runs correctly.

So we use:
$function = function(bool $out = true) {
    if($out) echo "Shutdown function called\n";
};

$function(false);

register_shutdown_function($function);

Author: EdmondDantes

run-tests.sh

@@ -16,4 +16,4 @@ else
     TEST_PATH="$BASE_PATH/$1"
 fi
 
-"$PHP_EXECUTABLE" "$RUN_TESTS_PATH" --show-diff -p "$PHP_EXECUTABLE" "$TEST_PATH"
+"$PHP_EXECUTABLE" "$RUN_TESTS_PATH" -d zend_extension=opcache.so -d opcache.enable_cli=1 --show-diff -p "$PHP_EXECUTABLE" "$TEST_PATH"

tests/bailout/003-stack-overflow-simple.phpt

@@ -16,9 +16,13 @@ function deepRecursion($depth = 0) {
     return deepRecursion($depth + 1);
 }
 
-register_shutdown_function(function() {
-    echo "Shutdown function called\n";
-});
+$function = function(bool $out = true) {
+    if($out) echo "Shutdown function called\n";
+};
+
+$function(false);
+
+register_shutdown_function($function);
 
 echo "Before spawn\n";
 
@@ -39,4 +43,4 @@ Before stack overflow
 Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
 
 Warning: Graceful shutdown mode was started in %s on line %d
-Shutdown function called
+Shutdown function called

tests/bailout/004-stack-overflow-nested.phpt

@@ -16,21 +16,25 @@ function deepRecursion($depth = 0) {
     return deepRecursion($depth + 1);
 }
 
-register_shutdown_function(function() {
-    echo "Shutdown function called\n";
-});
+$function = function(bool $out = true) {
+    if($out) echo "Shutdown function called\n";
+};
+
+$function(false);
+
+register_shutdown_function($function);
 
 echo "Before spawn\n";
 
 spawn(function() {
     echo "Outer async started\n";
-    
+
     spawn(function() {
         echo "Inner async started\n";
         deepRecursion();
         echo "Inner async after stack overflow (should not reach)\n";
     });
-    
+
     echo "Outer async continues\n";
 });
 
@@ -47,4 +51,4 @@ Inner async started
 Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
 
 Warning: Graceful shutdown mode was started in %s on line %d
-Shutdown function called
+Shutdown function called

tests/bailout/006-memory-exhaustion-multiple-coroutines.phpt

@@ -14,9 +14,13 @@ memory_limit=2M
 
 use function Async\spawn;
 
-register_shutdown_function(function() {
-    echo "Shutdown function called\n";
-});
+$function = function(bool $out = true) {
+    if($out) echo "Shutdown function called\n";
+};
+
+$function(false);
+
+register_shutdown_function($function);
 
 echo "Before spawn\n";
 
@@ -50,4 +54,4 @@ Coroutine 2 started
 Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
 
 Warning: Graceful shutdown mode was started in %s on line %d
-Shutdown function called
+Shutdown function called

tests/bailout/007-stack-overflow-with-suspend.phpt

@@ -20,9 +20,13 @@ function deepRecursionWithSuspend($depth = 0) {
     return deepRecursionWithSuspend($depth + 1);
 }
 
-register_shutdown_function(function() {
-    echo "Shutdown function called\n";
-});
+$function = function(bool $out = true) {
+    if($out) echo "Shutdown function called\n";
+};
+
+$function(false);
+
+register_shutdown_function($function);
 
 echo "Before spawn\n";
 
@@ -48,4 +52,4 @@ Other coroutine running
 Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
 
 Warning: Graceful shutdown mode was started in %s on line %d
-Shutdown function called
+Shutdown function called

tests/bailout/011-stack-overflow-during-await.phpt

@@ -17,9 +17,13 @@ function deepRecursion($depth = 0) {
     return deepRecursion($depth + 1);
 }
 
-register_shutdown_function(function() {
-    echo "Shutdown function called\n";
-});
+$function = function(bool $out = true) {
+    if($out) echo "Shutdown function called\n";
+};
+
+$function(false);
+
+register_shutdown_function($function);
 
 echo "Before spawn\n";
 
@@ -43,4 +47,4 @@ Coroutine started
 Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
 
 Warning: Graceful shutdown mode was started in %s on line %d
-Shutdown function called
+Shutdown function called

tests/bailout/014-stack-overflow-with-finally.phpt

@@ -25,9 +25,18 @@ echo "Before scope\n";
 
 $scope = new Scope();
 
-$scope->onFinally(function() {
-    echo "Finally handler executed\n";
-});
+$finally = function($x = false, $out = true) {
+    if($out) {
+        echo "Finally handler executed\n";
+    }
+};
+
+// JIT PHP in tracing mode can compile functions on demand. When memory runs out,
+// JIT crashes with an error because it tries to compile a closure.
+// This code attempts to work around the issue so that the test runs correctly.
+$finally(false, false);
+
+$scope->onFinally($finally);
 
 $coroutine = $scope->spawn(function() {
     echo "Before stack overflow\n";
@@ -48,4 +57,4 @@ Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d by
 
 Warning: Graceful shutdown mode was started in %s on line %d
 Shutdown function called
-Finally handler executed
+Finally handler executed