* Fixed GC behavior during coroutine cancellation when an exception occurs in the main coroutine while the GC is running.

Author: EdmondDantes

coroutine.c

@@ -343,7 +343,10 @@ zend_coroutine_t *async_new_coroutine(zend_async_scope_t *scope)
 {
 	zend_object *object = coroutine_object_create(async_ce_coroutine);
 
-	if (UNEXPECTED(EG(exception))) {
+	if (UNEXPECTED(object == NULL || EG(exception))) {
+		if (object != NULL) {
+			zend_object_release(object);
+		}
 		return NULL;
 	}
 

tests/gc/013-gc-fiber-destructors.phpt

@@ -16,11 +16,6 @@ class Cycle {
     public function __destruct() {
         $id = self::$counter++;
         printf("%d: Start destruct\n", $id);
-        if ($id === 0) {
-            global $f2;
-            $f2 = Fiber::getCurrent();
-            Fiber::suspend(new stdClass);
-        }
         printf("%d: End destruct\n", $id);
     }
 }
@@ -37,16 +32,14 @@ new Cycle();
 new Cycle();
 gc_collect_cycles();
 
-$f2->resume();
-
 ?>
 --EXPECT--
 0: Start destruct
+0: End destruct
 1: Start destruct
 1: End destruct
 2: Start destruct
 2: End destruct
 3: Start destruct
 3: End destruct
-0: End destruct
 Shutdown

tests/gc/014-gc-after-excaption-in-main.phpt

@@ -0,0 +1,52 @@
+--TEST--
+Correct GC behavior when the main coroutine is destroyed due to an exception.
+--FILE--
+<?php
+
+register_shutdown_function(function () {
+    printf("Shutdown\n");
+});
+
+class Cycle {
+    public static $counter = 0;
+    public $self;
+    public function __construct() {
+        $this->self = $this;
+    }
+    public function __destruct() {
+        $id = self::$counter++;
+        printf("%d: Start destruct\n", $id);
+        printf("%d: End destruct\n", $id);
+    }
+}
+
+$f = new Fiber(function () {
+    new Cycle();
+    new Cycle();
+    gc_collect_cycles();
+});
+
+$f->start();
+
+new Cycle();
+new Cycle();
+gc_collect_cycles();
+
+throw new Exception("Trigger GC");
+
+?>
+--EXPECTF--
+0: Start destruct
+0: End destruct
+1: Start destruct
+1: End destruct
+2: Start destruct
+2: End destruct
+3: Start destruct
+3: End destruct
+
+Fatal error: Uncaught Exception: Trigger GC in %s:%d
+Stack trace:
+#0 {main}
+  thrown in %s on line %d
+Shutdown