Fix coroutine scope tracking race condition

  Move scope reference assignment from async_new_coroutine() to scope_before_coroutine_enqueue()
  to ensure coroutines are added to scope->coroutines array before scope is set. This prevents
  crashes when coroutines finish between creation and enqueue.

  Fixes assertion failures: "Scope should be empty before disposal"

Author: EdmondDantes

async_API.c

@@ -106,18 +106,12 @@ zend_coroutine_t *spawn(zend_async_scope_t *scope, zend_object *scope_provider,
 
 	zend_apply_current_filename_and_line(&coroutine->coroutine.filename, &coroutine->coroutine.lineno);
 
-	zval options;
-	ZVAL_UNDEF(&options);
-	if (!scope->before_coroutine_enqueue(&coroutine->coroutine, scope, &options)) {
-		zval_ptr_dtor(&options);
-		coroutine->coroutine.event.dispose(&coroutine->coroutine.event);
-		return NULL;
-	}
-	zval_ptr_dtor(&options);
-
 	const bool is_spawn_strategy =
 			scope_provider != NULL && instanceof_function(scope_provider->ce, async_ce_spawn_strategy);
 
+	zval options;
+	ZVAL_UNDEF(&options);
+
 	// call SpawnStrategy::beforeCoroutineEnqueue
 	if (is_spawn_strategy) {
 		zval coroutine_zval, scope_zval;

coroutine.c

@@ -337,7 +337,16 @@ zend_coroutine_t *async_new_coroutine(zend_async_scope_t *scope)
 	}
 
 	async_coroutine_t *coroutine = (async_coroutine_t *) ZEND_ASYNC_OBJECT_TO_EVENT(object);
-	coroutine->coroutine.scope = scope;
+
+	// Add the coroutine to the scope before calling the enqueue hook
+	zval options;
+	ZVAL_UNDEF(&options);
+	if (!scope->before_coroutine_enqueue(&coroutine->coroutine, scope, &options)) {
+		zval_ptr_dtor(&options);
+		coroutine->coroutine.event.dispose(&coroutine->coroutine.event);
+		return NULL;
+	}
+	zval_ptr_dtor(&options);
 
 	return &coroutine->coroutine;
 }