From f027829fb2e92d490d10cb29048684c48bcb6e64 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Tue, 23 Sep 2025 12:55:46 -0400 Subject: [PATCH 1/2] Respect ChatOptions.Instructions in HuggingFaceClient.GetResponseAsync --- .../HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs b/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs index 30be420..36626a1 100644 --- a/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs +++ b/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs @@ -34,6 +34,13 @@ async Task IChatClient.GetResponseAsync(IEnumerable m } prompt.AppendLine(); } + + if (options?.Instructions is { } instructions) + { + AppendRole(ChatRole.System); + prompt.Append(instructions).AppendLine(); + } + AppendRole(ChatRole.Assistant); void AppendRole(ChatRole role) => prompt.Append("<|").Append(role.Value).Append("|>"); From a3cdf9c0f4bb4ee58c2ea64f80afe54ef2c58945 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 11 Dec 2025 10:53:17 -0500 Subject: [PATCH 2/2] Address feedback --- src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs b/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs index 36626a1..5fd4f8d 100644 --- a/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs +++ b/src/libs/HuggingFace/Extensions/HuggingFaceApi.ChatClient.cs @@ -35,10 +35,10 @@ async Task IChatClient.GetResponseAsync(IEnumerable m prompt.AppendLine(); } - if (options?.Instructions is { } instructions) + if (!string.IsNullOrWhiteSpace(options?.Instructions)) { AppendRole(ChatRole.System); - prompt.Append(instructions).AppendLine(); + prompt.Append(options?.Instructions).AppendLine(); } AppendRole(ChatRole.Assistant);