From e24ca8993b084652579bd0f4a2df577ae5f9155a Mon Sep 17 00:00:00 2001 From: Ignacio Tomas Crespo Date: Tue, 1 Jul 2025 14:26:10 -0300 Subject: [PATCH] merged changes from PR https://github.com/rnmapbox/maps/pull/3869 --- .../com/rnmapbox/rnmbx/modules/RNMBXLocationModule.kt | 4 ++-- .../java/com/rnmapbox/rnmbx/modules/RNMBXOfflineModule.kt | 2 +- .../com/rnmapbox/rnmbx/NativeRNMBXLocationModuleSpec.java | 8 ++++++++ src/specs/NativeRNMBXLocationModule.ts | 2 ++ 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXLocationModule.kt b/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXLocationModule.kt index 7c87fc2dd4..4093ee1d22 100644 --- a/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXLocationModule.kt +++ b/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXLocationModule.kt @@ -132,12 +132,12 @@ class RNMBXLocationModule(reactContext: ReactApplicationContext) : } @ReactMethod - fun addListener(eventName: String?) { + override fun addListener(eventName: String?) { // Required for rn built in EventEmitter Calls. } @ReactMethod - fun removeListeners(count: Int?) { + override fun removeListeners(count: Double) { // Required for rn built in EventEmitter Calls. } diff --git a/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXOfflineModule.kt b/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXOfflineModule.kt index bbc97f895f..efab5f74d7 100644 --- a/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXOfflineModule.kt +++ b/android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXOfflineModule.kt @@ -125,7 +125,7 @@ class RNMBXOfflineModule(private val mReactContext: ReactApplicationContext) : } @ReactMethod - fun removeListeners(count: Int?) { + fun removeListeners(count: Double) { // Remove upstream listeners, stop unnecessary background tasks } diff --git a/android/src/main/old-arch/com/rnmapbox/rnmbx/NativeRNMBXLocationModuleSpec.java b/android/src/main/old-arch/com/rnmapbox/rnmbx/NativeRNMBXLocationModuleSpec.java index e5db5cbba2..e5a1618a10 100644 --- a/android/src/main/old-arch/com/rnmapbox/rnmbx/NativeRNMBXLocationModuleSpec.java +++ b/android/src/main/old-arch/com/rnmapbox/rnmbx/NativeRNMBXLocationModuleSpec.java @@ -65,4 +65,12 @@ protected final void emitOnLocationUpdate(ReadableMap value) { @ReactMethod @DoNotStrip public abstract void setLocationEventThrottle(double throttle); + + @ReactMethod + @DoNotStrip + public abstract void addListener(String eventName); + + @ReactMethod + @DoNotStrip + public abstract void removeListeners(double count); } diff --git a/src/specs/NativeRNMBXLocationModule.ts b/src/specs/NativeRNMBXLocationModule.ts index 363d56b770..eb7d3d1b8d 100644 --- a/src/specs/NativeRNMBXLocationModule.ts +++ b/src/specs/NativeRNMBXLocationModule.ts @@ -24,6 +24,8 @@ export interface Spec extends TurboModule { getLastKnownLocation(): Promise simulateHeading(changesPerSecond: number, increment: number): void setLocationEventThrottle(throttle: number): void + addListener(eventName: string): void; + removeListeners(count: number): void; readonly onLocationUpdate: EventEmitter }