Skip to content

Commit a2a7b82

Browse files
authored
Merge pull request #3 from unidev-platform/build-upates
HTTP clients build fixes
2 parents 4c3ecbc + 34cd62c commit a2a7b82

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

apache-http-client/src/main/java/com/unidev/httpclient/apache/HTTPClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ protected RequestConfig.Builder buildRequestConfig() {
117117
}
118118

119119
/**
120-
* Create default HTTPClient with random user agent & no proxy
120+
* Create default HTTPClient with random user agent and no proxy
121121
*/
122122
public void init(List<String> userAgents) {
123123
if (!CollectionUtils.isEmpty(userAgents)) {

build.gradle

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ subprojects {
3232

3333
testCompileOnly "org.projectlombok:lombok:${lombokVersion}"
3434
testAnnotationProcessor "org.projectlombok:lombok:${lombokVersion}"
35+
36+
testImplementation 'org.mockito:mockito-all:1.10.19'
37+
testImplementation 'org.hamcrest:hamcrest-all:1.3'
38+
testImplementation 'org.assertj:assertj-core:3.9.1'
39+
40+
testImplementation "org.junit.jupiter:junit-jupiter:${junitJupiterVersion}"
3541
}
3642

3743
tasks.named('test') {

gradle.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ httpclientVersion=4.5.13
22
httpmimeVersion=4.5.13
33
httpcoreVresion=4.4.10
44
lombokVersion=1.18.24
5+
junitJupiterVersion=5.9.1

phantom-js/src/test/java/com/unidev/httpclient/phantomjs/PhantomJSClientTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.unidev.httpclient.phantomjs;
22

33
import com.unidev.platform.Processes;
4-
import com.unidev.httpclient.apache.PhantomJSClient;
54
import org.junit.jupiter.api.BeforeEach;
65
import org.junit.jupiter.api.Test;
76

0 commit comments

Comments
 (0)