feat(uniond): reuse libwasmvm release artifacts (#4062)

Author: hussein-aitlahcen

tools/libwasmvm/libwasmvm.nix

@@ -1,4 +1,30 @@
-_: {
+_:
+let
+  # TODO: populate when needed
+  hashes = {
+    "1.5.2" = {
+      "x86_64-linux" = "sha256-5mCjjvspMLNO5vawuxJzCtzLBAtqtwG4+C80RTpCauc=";
+      "aarch64-linux" = "sha256-54siTBWWSBejt1pA5ZiCtNDgb9BVs5UU1hZGaJzvjG4=";
+      "aarch64-darwin" = "";
+    };
+    "2.1.2" = {
+      "x86_64-linux" = "sha256-WOH2v6ie45DLmrxppbwSYCmkl/4J3TmfOKgtDYb+le8=";
+      "aarch64-linux" = "sha256-CIHFtGPoniKbBjcOnilhrsClxjZ3LVFCxo01FWRGSmY=";
+      "aarch64-darwin" = "";
+    };
+    "2.1.3" = {
+      "x86_64-linux" = "sha256-jasIQ0pf5Xpvu8uAQXlLw8MYRtMfj/X7NT7nTg/NMJM=";
+      "aarch64-linux" = "sha256-+upOFTkOBG0sqEQcIaiNulb5oDY/ksXZQBXfCsbaHy0=";
+      "aarch64-darwin" = "";
+    };
+    "2.2.1" = {
+      "x86_64-linux" = "sha256-s711XvrA/znAG1m4EQ+WHEiqPrk1iAcdemKCcMwfIyY=";
+      "aarch64-linux" = "sha256-umy122sUomXIVWMmwEWICQjbmx0v+11KqfCawJskzsw=";
+      "aarch64-darwin" = "";
+    };
+  };
+in
+{
   perSystem =
     {
       pkgs,
@@ -12,144 +38,33 @@ _: {
       ...
     }:
     let
-      throwBadSystem = throw "libwasmvm cannot be built on system `${system}`";
-
-      CARGO_BUILD_TARGET =
-        if system == "aarch64-linux" then
-          "aarch64-unknown-linux-musl"
-        else if system == "x86_64-linux" then
-          "x86_64-unknown-linux-musl"
-        else if system == "aarch64-darwin" then
-          "aarch64-apple-darwin"
-        else if system == "x86_64-darwin" then
-          "x86_64-apple-darwin"
-        else
-          throwBadSystem;
-
-      rustToolchain-2024-01-27 = rust.mkNightly {
-        channel = "nightly-2024-01-27";
-        targets = [ CARGO_BUILD_TARGET ];
-      };
-      rustToolchain-1-77 = rust.mkNightly {
-        channel = "1.77.0";
-        targets = [ CARGO_BUILD_TARGET ];
-      };
-      rustToolchain-1-82 = rust.mkNightly {
-        channel = "1.82.0";
-        targets = [ CARGO_BUILD_TARGET ];
-      };
-
-      mkLibwasmvm_v1 =
-        wasmvm:
+      fetchReleaseArtifact =
+        { version }:
         let
-          attrs =
-            {
-              inherit CARGO_BUILD_TARGET;
-              pname = "libwasmvm";
-              version = wasmvm.rev;
-              buildInputs = [ rustToolchain-2024-01-27 ];
-              src = "${wasmvm}/libwasmvm";
-              installCargoArtifactsMode = "use-zstd";
-            }
-            // (
-              if pkgs.stdenv.isLinux then
-                {
-                  cargoExtraArgs = "--locked --offline --example=wasmvmstatic";
-                  installPhaseCommand = ''
-                    mkdir -p $out/lib
-                    mv target/${CARGO_BUILD_TARGET}/release/examples/libwasmvmstatic.a $out/lib/libwasmvm.${builtins.head (pkgs.lib.strings.splitString "-" system)}.a
-                  '';
-                }
-              else if pkgs.stdenv.isDarwin then
-                {
-                  # non-static dylib build on macOS
-                  cargoExtraArgs = "--locked --offline";
-                  installPhaseCommand = ''
-                    mkdir -p $out/lib
-                    mv target/${CARGO_BUILD_TARGET}/release/deps/libwasmvm.dylib $out/lib/libwasmvm.dylib
-                  '';
-                }
-              else
-                throwBadSystem
-            );
-          craneLib = crane.lib.overrideToolchain rustToolchain-2024-01-27;
+          prefix = builtins.head (pkgs.lib.strings.splitString "-" system);
+          artifact = pkgs.fetchurl {
+            # TODO: incompatible with darwin we need to cut the `muslc` prefix
+            url = "https://github.com/CosmWasm/wasmvm/releases/download/v${version}/libwasmvm_muslc.${prefix}.a";
+            hash = hashes.${version}.${system};
+          };
         in
-        craneLib.buildPackage (
-          attrs
-          // {
-            cargoArtifacts = craneLib.buildDepsOnly attrs;
-          }
-        );
-      mkLibwasmvm_v2 =
-        wasmvm: rustToolChain:
-        let
-          attrs =
-            {
-              inherit CARGO_BUILD_TARGET;
-              pname = "libwasmvm";
-              version = wasmvm.rev;
-              buildInputs = [ rustToolChain ];
-              src = "${wasmvm}/libwasmvm";
-              installCargoArtifactsMode = "use-zstd";
-            }
-            // (
-              if pkgs.stdenv.isLinux then
-                {
-                  cargoExtraArgs = "--locked --offline --example=wasmvmstatic";
-                  installPhaseCommand = ''
-                    mkdir -p $out/lib
-                    mv target/${CARGO_BUILD_TARGET}/release/examples/libwasmvmstatic.a $out/lib/libwasmvm.${builtins.head (pkgs.lib.strings.splitString "-" system)}.a
-                  '';
-                }
-              else if pkgs.stdenv.isDarwin then
-                {
-                  # non-static dylib build on macOS
-                  cargoExtraArgs = "--locked --offline";
-                  installPhaseCommand = ''
-                    mkdir -p $out/lib
-                    mv target/${CARGO_BUILD_TARGET}/release/deps/libwasmvm.dylib $out/lib/libwasmvm.dylib
-                  '';
-                }
-              else
-                throwBadSystem
-            );
-          craneLib = crane.lib.overrideToolchain rustToolChain;
-        in
-        craneLib.buildPackage (
-          attrs
-          // {
-            cargoArtifacts = craneLib.buildDepsOnly attrs;
-          }
-        );
-      wasmvm-1_5_2 = pkgs.fetchFromGitHub {
-        owner = "CosmWasm";
-        repo = "wasmvm";
-        rev = "v1.5.2";
-        hash = "sha256-3KJq5jFllFSqlm85/iRWYMhu99iuokvR3Ib9Gq3gIjc=";
+        pkgs.runCommand "libwasmvm-${version}-${system}" { } ''
+          mkdir -p $out/lib
+          cp ${artifact} $out/lib/libwasmvm.${prefix}.a
+        '';
+    in
+    {
+      packages.libwasmvm-1_5_2 = fetchReleaseArtifact {
+        version = "1.5.2";
       };
-      wasmvm-2_1_2 = pkgs.fetchFromGitHub {
-        owner = "CosmWasm";
-        repo = "wasmvm";
-        rev = "v2.1.2";
-        hash = "sha256-Y3BVRR2T5MLOtXdPK38W8MX8etIuqGcTjvxkaEOyvVM=";
+      packages.libwasmvm-2_1_2 = fetchReleaseArtifact {
+        version = "2.1.2";
       };
-      wasmvm-2_1_3 = pkgs.fetchFromGitHub {
-        owner = "CosmWasm";
-        repo = "wasmvm";
-        rev = "v2.1.3";
-        hash = "sha256-gYrK2EHhXnearJgLX38O6NLI6TfoGtpzA9be/7S/0ZU=";
+      packages.libwasmvm-2_1_3 = fetchReleaseArtifact {
+        version = "2.1.3";
       };
-      wasmvm-2_2_1 = pkgs.fetchFromGitHub {
-        owner = "CosmWasm";
-        repo = "wasmvm";
-        rev = "v2.2.1";
-        hash = "sha256-HA/YPdE1yy2/vfiQWOTE0z75agYZL/kWTvpXKyKbfLk=";
+      packages.libwasmvm-2_2_1 = fetchReleaseArtifact {
+        version = "2.2.1";
       };
-    in
-    {
-      packages.libwasmvm-1_5_2 = mkLibwasmvm_v1 wasmvm-1_5_2;
-      packages.libwasmvm-2_1_2 = mkLibwasmvm_v2 wasmvm-2_1_2 rustToolchain-1-77;
-      packages.libwasmvm-2_1_3 = mkLibwasmvm_v2 wasmvm-2_1_3 rustToolchain-1-82;
-      packages.libwasmvm-2_2_1 = mkLibwasmvm_v2 wasmvm-2_2_1 rustToolchain-1-82;
     };
 }