chore(appv2-movement): fixed comments

Signed-off-by: Kaan Caglan <caglankaan@gmail.com>

Author: Caglankaan

app2/src/lib/services/aptos/clients.ts

@@ -27,10 +27,11 @@ export const getPublicClient = (chain: Chain) =>
     if (chain.rpc_type !== "aptos") {
       throw new NoAptosChainError({ chain })
     }
+    const rpcUrl = chain.getRpcUrl("rpc")
     const aptosClient = yield* Effect.try({
       try: () => {
         const config = new AptosConfig({
-          fullnode: "https://aptos.testnet.bardock.movementlabs.xyz/v1",
+          fullnode: rpcUrl.toString(),
           network: Network.TESTNET
         })
         return new Aptos(config)
@@ -46,10 +47,12 @@ export const getWalletClient = (chain: Chain) =>
       throw new NoAptosChainError({ chain })
     }
 
+    const rpcUrl = chain.getRpcUrl("rpc")
+
     const aptosClient = yield* Effect.try({
       try: () => {
         const config = new AptosConfig({
-          fullnode: "https://aptos.testnet.bardock.movementlabs.xyz/v1",
+          fullnode: rpcUrl.toString(),
           network: Network.TESTNET
         })
         const aptos = new Aptos(config)

app2/src/lib/services/shared/quote-token.ts

@@ -85,7 +85,7 @@ export const getQuoteToken = (
     if (destinationChain.rpc_type === "aptos") {
       console.info("destinationChain is aptos")
       let network: Network
-      let rpcUrl: string
+      // let rpcUrl: string
 
       const rpc = yield* destinationChain
         .requireRpcUrl("rpc")
@@ -94,17 +94,15 @@ export const getQuoteToken = (
       console.info("rpc: ", rpc.origin)
       if (channel.destination_chain_id === "250") {
         network = Network.TESTNET
-        rpcUrl = "https://aptos.testnet.bardock.movementlabs.xyz/v1"
+        // rpcUrl = "https://aptos.testnet.bardock.movementlabs.xyz/v1"
       } else {
         return yield* Effect.fail(
           new GetQuoteError({ cause: `Unsupported Aptos network: ${channel.destination_chain_id}` })
         )
       }
 
-      // const config = new AptosConfig({ network, fullnode: rpc.origin+"/v1" }); //TODO: rpc.origin is coming without "/v1" at the end, discuss this later
-      //And also this rpc.origin returns:
-      // :5173/transfer?source=union-testnet-9&destination=250&asset=0x6d756e6f:1 Access to XMLHttpRequest at 'https://rpc.250.movement.chain.kitchen/v1/accounts/0x80a825c8878d4e22f459f76e581cb477d82f0222e136b06f01ad146e2ae9ed84/module/ibc_app' from origin 'http://localhost:5173' has been blocked by CORS policy: Request header field x-aptos-typescript-sdk-origin-method is not allowed by Access-Control-Allow-Headers in preflight response.
-      const config = new AptosConfig({ network, fullnode: rpcUrl })
+      const config = new AptosConfig({ network, fullnode: rpc.origin + "/v1" }) //TODO: rpc.origin is coming without "/v1" at the end, discuss this later
+
       const aptosClient = new Aptos(config)
 
       const output = yield* Effect.tryPromise({

app2/src/lib/services/shared/salt.ts

@@ -10,3 +10,12 @@ export const generateSalt = Effect.sync(() => {
   crypto.getRandomValues(rawSalt)
   return toHex(rawSalt) as Hex
 })
+
+/**
+ * Effect that generates cryptographically secure random salts
+ * used to prevent transfer hash collisions
+ */
+export const generateSaltAptos = Effect.sync(() => {
+  const saltHex = new Uint8Array(14)
+  return toHex(saltHex)
+})

app2/src/lib/services/transfer-ucs03-aptos/quote-token.ts

@@ -3,7 +3,7 @@ import type { Hash, WaitForTransactionReceiptErrorType, WriteContractErrorType }
 import { WaitForTransactionReceiptError, WriteContractError } from "./errors.ts"
 import { getPublicClient } from "../aptos/clients.ts"
 import { getAccount } from "$lib/services/transfer-ucs03-aptos/account.ts"
-import { generateSalt } from "./salt.ts"
+import { generateSaltAptos } from "$lib/services/shared"
 import type { Chain } from "$lib/schema/chain.ts"
 import type { ValidTransfer } from "$lib/schema/transfer-args.ts"
 
@@ -15,7 +15,7 @@ export const submitTransfer = (_chain: Chain, transfer: ValidTransfer["args"]) =
     const account = yield* Effect.flatMap(getAccount, account =>
       account ? Effect.succeed(account) : Effect.fail(new Error("No account connected"))
     )
-    const salt = yield* generateSalt
+    const salt = yield* generateSaltAptos
 
     const walletPayload = {
       function: `${transfer.ucs03address}::ibc_app::transfer`,