Skip to content

Commit 00f3f5f

Browse files
committed
Change VersionCommand to Picocli
1 parent 5e86b01 commit 00f3f5f

File tree

2 files changed

+13
-22
lines changed

2 files changed

+13
-22
lines changed

src/main/java/org/utplsql/cli/UtplsqlPicocliCommand.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
@CommandLine.Command(
66
name = "utplsql",
77
description = "utPLSQL cli",
8-
subcommands = { RunPicocliCommand.class })
8+
subcommands = {
9+
RunPicocliCommand.class,
10+
VersionInfoCommand.class
11+
})
912
public class UtplsqlPicocliCommand {
1013

1114
}

src/main/java/org/utplsql/cli/VersionInfoCommand.java

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,30 @@
11
package org.utplsql.cli;
22

33

4-
import com.beust.jcommander.Parameter;
5-
import com.beust.jcommander.Parameters;
64
import org.utplsql.api.JavaApiVersionInfo;
75
import org.utplsql.api.Version;
86
import org.utplsql.api.db.DefaultDatabaseInformation;
97
import org.utplsql.api.exception.UtPLSQLNotInstalledException;
8+
import picocli.CommandLine.Command;
9+
import picocli.CommandLine.Parameters;
1010

1111
import javax.sql.DataSource;
1212
import java.sql.Connection;
1313
import java.sql.SQLException;
14-
import java.util.ArrayList;
15-
import java.util.List;
1614

17-
@Parameters(separators = "=", commandDescription = "prints version information of cli, java-api and - if connection is given - database utPLSQL framework")
15+
@Command( name = "info", description = "prints version information of cli, java-api and - if connection is given - database utPLSQL framework")
1816
public class VersionInfoCommand implements ICommand {
1917

20-
@Parameter(
21-
converter = ConnectionInfo.ConnectionStringConverter.class,
22-
variableArity = true,
23-
description = ConnectionInfo.COMMANDLINE_PARAM_DESCRIPTION)
24-
private List<ConnectionInfo> connectionInfoList = new ArrayList<>();
25-
26-
private ConnectionInfo getConnectionInfo() {
27-
if ( connectionInfoList != null && connectionInfoList.size() > 0 )
28-
return connectionInfoList.get(0);
29-
else
30-
return null;
31-
}
18+
@Parameters(description = ConnectionInfo.COMMANDLINE_PARAM_DESCRIPTION, arity = "0..1")
19+
private String connectionString;
3220

3321
public int run() {
3422

3523
System.out.println(CliVersionInfo.getInfo());
3624
System.out.println(JavaApiVersionInfo.getInfo());
3725

3826
try {
39-
writeUtPlsqlVersion(getConnectionInfo());
27+
writeUtPlsqlVersion(connectionString);
4028
}
4129
catch (SQLException e) {
4230
e.printStackTrace();
@@ -46,10 +34,10 @@ public int run() {
4634
return 0;
4735
}
4836

49-
private void writeUtPlsqlVersion( ConnectionInfo ci ) throws SQLException {
50-
if ( ci != null ) {
37+
private void writeUtPlsqlVersion( String connectString ) throws SQLException {
38+
if ( connectString != null ) {
5139

52-
DataSource dataSource = DataSourceProvider.getDataSource(ci, 1);
40+
DataSource dataSource = DataSourceProvider.getDataSource(connectString, 1);
5341

5442
try (Connection con = dataSource.getConnection()) {
5543
Version v = new DefaultDatabaseInformation().getUtPlsqlFrameworkVersion(con);

0 commit comments

Comments
 (0)