Skip to content

Commit d13ae5b

Browse files
committed
Extract functionality to interface
1 parent 60997d7 commit d13ae5b

File tree

4 files changed

+20
-5
lines changed

4 files changed

+20
-5
lines changed
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
package org.utplsql.cli;
2+
3+
import org.utplsql.api.TestRunner;
4+
import org.utplsql.api.reporter.Reporter;
5+
6+
import java.util.List;
7+
8+
public interface IRunCommand extends ICommand {
9+
10+
TestRunner newTestRunner(List<Reporter> reporterList);
11+
12+
List<ReporterOptions> getReporterOptionsList();
13+
}

src/main/java/org/utplsql/cli/RunCommand.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
* @author pesse
3838
*/
3939
@Parameters(separators = "=", commandDescription = "run tests")
40-
public class RunCommand implements ICommand {
40+
public class RunCommand implements ICommand, IRunCommand {
4141

4242
private static final Logger logger = LoggerFactory.getLogger(RunCommand.class);
4343

@@ -258,7 +258,8 @@ private void checkForCompatibility( Version utPlSqlVersion ) {
258258

259259
}
260260

261-
TestRunner newTestRunner( List<Reporter> reporterList) {
261+
@Override
262+
public TestRunner newTestRunner( List<Reporter> reporterList) {
262263

263264
final File baseDir = new File("").getAbsoluteFile();
264265

@@ -437,7 +438,8 @@ private ReporterManager getReporterManager() {
437438
return reporterManager;
438439
}
439440

440-
List<ReporterOptions> getReporterOptionsList() {
441+
@Override
442+
public List<ReporterOptions> getReporterOptionsList() {
441443
return getReporterManager().getReporterOptionsList();
442444
}
443445
}

src/test/java/org/utplsql/cli/RunCommandIssue20Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class RunCommandIssue20Test {
2121

2222
@Test
2323
void runLoop() {
24-
RunCommand runCmd = TestHelper.createRunCommand(
24+
IRunCommand runCmd = TestHelper.createRunCommand(
2525
TestHelper.getConnectionString(),
2626
"-p=TEST_BETWNSTR.normal_case",
2727
"-f=ut_documentation_reporter");

src/test/java/org/utplsql/cli/TestHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class TestHelper {
2525
sPass = EnvironmentVariableUtil.getEnvValue("DB_PASS", "app");
2626
}
2727

28-
static RunCommand createRunCommand(String... args) {
28+
static IRunCommand createRunCommand(String... args) {
2929
RunCommand runCmd = new RunCommand();
3030

3131
JCommander.newBuilder()

0 commit comments

Comments
 (0)