diff --git a/tests/Pools/Adapter/SwooleTest.php b/tests/Pools/Adapter/SwooleTest.php index 9434d11..2864272 100644 --- a/tests/Pools/Adapter/SwooleTest.php +++ b/tests/Pools/Adapter/SwooleTest.php @@ -103,13 +103,13 @@ public function testSwooleCoroutineRaceCondition(): void // Assertions inside coroutine context $this->assertEmpty($errors, 'Errors occurred: ' . implode(', ', $errors)); - $this->assertEquals(10, $successCount, 'All 10 coroutines should successfully complete'); + $this->assertSame(10, $successCount, 'All 10 coroutines should successfully complete'); // Pool should be full again after all connections are reclaimed - $this->assertEquals(5, $pool->count(), 'Pool should have all 5 connections back'); + $this->assertSame(5, $pool->count(), 'Pool should have all 5 connections back'); // Should only create exactly pool size connections (no race conditions with new implementation) - $this->assertEquals(5, $connectionCounter, 'Should create exactly 5 connections (pool size)'); + $this->assertSame(5, $connectionCounter, 'Should create exactly 5 connections (pool size)'); }); } @@ -163,14 +163,14 @@ public function testSwooleCoroutineHighConcurrency(): void } // All requests should succeed with proper retry logic - $this->assertEquals($totalRequests, $successCount, "All {$totalRequests} requests should succeed"); - $this->assertEquals(0, $errorCount, 'No errors should occur with proper concurrency handling'); + $this->assertSame($totalRequests, $successCount, "All {$totalRequests} requests should succeed"); + $this->assertSame(0, $errorCount, 'No errors should occur with proper concurrency handling'); // Pool should be full again - $this->assertEquals(3, $pool->count(), 'Pool should have all 3 connections back'); + $this->assertSame(3, $pool->count(), 'Pool should have all 3 connections back'); // Should only create 3 connections (pool size) - $this->assertEquals(3, $connectionCounter, 'Should only create 3 connections (pool size)'); + $this->assertSame(3, $connectionCounter, 'Should only create 3 connections (pool size)'); }); } @@ -286,14 +286,14 @@ public function testSwooleCoroutineIdleConnectionReuse(): void } // Assertions inside coroutine context - $this->assertEquals(3, $connectionCounter, 'Should only create 3 connections total'); + $this->assertSame(3, $connectionCounter, 'Should only create 3 connections total'); $this->assertCount(3, $connectionIds['first'], 'First wave should have 3 connections'); $this->assertCount(3, $connectionIds['second'], 'Second wave should have 3 connections'); // Second wave should reuse connections from first wave sort($connectionIds['first']); sort($connectionIds['second']); - $this->assertEquals($connectionIds['first'], $connectionIds['second'], 'Second wave should reuse same connection IDs'); + $this->assertSame($connectionIds['first'], $connectionIds['second'], 'Second wave should reuse same connection IDs'); }); } @@ -347,10 +347,10 @@ public function testSwooleCoroutineStressTest(): void } // Assertions inside coroutine context - $this->assertEquals($totalRequests, $successCount, "All {$totalRequests} requests should succeed"); - $this->assertEquals(0, $errorCount, 'No errors should occur'); - $this->assertEquals(10, $connectionCounter, 'Should create exactly 10 connections (pool size)'); - $this->assertEquals(10, $pool->count(), 'Pool should have all connections back'); + $this->assertSame($totalRequests, $successCount, "All {$totalRequests} requests should succeed"); + $this->assertSame(0, $errorCount, 'No errors should occur'); + $this->assertSame(10, $connectionCounter, 'Should create exactly 10 connections (pool size)'); + $this->assertSame(10, $pool->count(), 'Pool should have all connections back'); }); } } diff --git a/tests/Pools/Scopes/ConnectionTestScope.php b/tests/Pools/Scopes/ConnectionTestScope.php index 7cb4a5d..cffa3d1 100644 --- a/tests/Pools/Scopes/ConnectionTestScope.php +++ b/tests/Pools/Scopes/ConnectionTestScope.php @@ -25,11 +25,11 @@ public function testConnectionGetID(): void { $this->execute(function (): void { $this->setUpConnection(); - $this->assertEquals(null, $this->connectionObject->getID()); + $this->assertSame('', $this->connectionObject->getID()); $this->connectionObject->setID('test'); - $this->assertEquals('test', $this->connectionObject->getID()); + $this->assertSame('test', $this->connectionObject->getID()); }); } @@ -37,11 +37,11 @@ public function testConnectionSetID(): void { $this->execute(function (): void { $this->setUpConnection(); - $this->assertEquals(null, $this->connectionObject->getID()); + $this->assertSame('', $this->connectionObject->getID()); $this->assertInstanceOf(Connection::class, $this->connectionObject->setID('test')); - $this->assertEquals('test', $this->connectionObject->getID()); + $this->assertSame('test', $this->connectionObject->getID()); }); } @@ -49,7 +49,7 @@ public function testConnectionGetResource(): void { $this->execute(function (): void { $this->setUpConnection(); - $this->assertEquals('x', $this->connectionObject->getResource()); + $this->assertSame('x', $this->connectionObject->getResource()); }); } @@ -57,11 +57,11 @@ public function testConnectionSetResource(): void { $this->execute(function (): void { $this->setUpConnection(); - $this->assertEquals('x', $this->connectionObject->getResource()); + $this->assertSame('x', $this->connectionObject->getResource()); $this->assertInstanceOf(Connection::class, $this->connectionObject->setResource('y')); - $this->assertEquals('y', $this->connectionObject->getResource()); + $this->assertSame('y', $this->connectionObject->getResource()); }); } @@ -92,7 +92,7 @@ public function testConnectionGetPool(): void } $this->assertInstanceOf(Pool::class, $pool); - $this->assertEquals('test', $pool->getName()); + $this->assertSame('test', $pool->getName()); }); } @@ -101,23 +101,23 @@ public function testConnectionReclaim(): void $this->execute(function (): void { $pool = new Pool($this->getAdapter(), 'test', 2, fn () => 'x'); - $this->assertEquals(2, $pool->count()); + $this->assertSame(2, $pool->count()); $connection1 = $pool->pop(); - $this->assertEquals(1, $pool->count()); + $this->assertSame(1, $pool->count()); $connection2 = $pool->pop(); - $this->assertEquals(0, $pool->count()); + $this->assertSame(0, $pool->count()); $this->assertInstanceOf(Pool::class, $connection1->reclaim()); - $this->assertEquals(1, $pool->count()); + $this->assertSame(1, $pool->count()); $this->assertInstanceOf(Pool::class, $connection2->reclaim()); - $this->assertEquals(2, $pool->count()); + $this->assertSame(2, $pool->count()); }); } @@ -139,28 +139,28 @@ public function testConnectionDestroy(): void return $i <= 2 ? 'x' : 'y'; }); - $this->assertEquals(2, $object->count()); + $this->assertSame(2, $object->count()); $connection1 = $object->pop(); $connection2 = $object->pop(); - $this->assertEquals(0, $object->count()); + $this->assertSame(0, $object->count()); - $this->assertEquals('x', $connection1->getResource()); - $this->assertEquals('x', $connection2->getResource()); + $this->assertSame('x', $connection1->getResource()); + $this->assertSame('x', $connection2->getResource()); $connection1->destroy(); $connection2->destroy(); - $this->assertEquals(2, $object->count()); + $this->assertSame(2, $object->count()); $connection1 = $object->pop(); $connection2 = $object->pop(); - $this->assertEquals(0, $object->count()); + $this->assertSame(0, $object->count()); - $this->assertEquals('y', $connection1->getResource()); - $this->assertEquals('y', $connection2->getResource()); + $this->assertSame('y', $connection1->getResource()); + $this->assertSame('y', $connection2->getResource()); }); } } diff --git a/tests/Pools/Scopes/GroupTestScope.php b/tests/Pools/Scopes/GroupTestScope.php index bd37d65..f32738b 100644 --- a/tests/Pools/Scopes/GroupTestScope.php +++ b/tests/Pools/Scopes/GroupTestScope.php @@ -64,17 +64,17 @@ public function testGroupReset(): void $this->setUpGroup(); $this->groupObject->add(new Pool($this->getAdapter(), 'test', 5, fn () => 'x')); - $this->assertEquals(5, $this->groupObject->get('test')->count()); + $this->assertSame(5, $this->groupObject->get('test')->count()); $this->groupObject->get('test')->pop(); $this->groupObject->get('test')->pop(); $this->groupObject->get('test')->pop(); - $this->assertEquals(2, $this->groupObject->get('test')->count()); + $this->assertSame(2, $this->groupObject->get('test')->count()); $this->groupObject->reclaim(); - $this->assertEquals(5, $this->groupObject->get('test')->count()); + $this->assertSame(5, $this->groupObject->get('test')->count()); }); } @@ -84,11 +84,11 @@ public function testGroupReconnectAttempts(): void $this->setUpGroup(); $this->groupObject->add(new Pool($this->getAdapter(), 'test', 5, fn () => 'x')); - $this->assertEquals(3, $this->groupObject->get('test')->getReconnectAttempts()); + $this->assertSame(3, $this->groupObject->get('test')->getReconnectAttempts()); $this->groupObject->setReconnectAttempts(5); - $this->assertEquals(5, $this->groupObject->get('test')->getReconnectAttempts()); + $this->assertSame(5, $this->groupObject->get('test')->getReconnectAttempts()); }); } @@ -98,11 +98,11 @@ public function testGroupReconnectSleep(): void $this->setUpGroup(); $this->groupObject->add(new Pool($this->getAdapter(), 'test', 5, fn () => 'x')); - $this->assertEquals(1, $this->groupObject->get('test')->getReconnectSleep()); + $this->assertSame(1, $this->groupObject->get('test')->getReconnectSleep()); $this->groupObject->setReconnectSleep(2); - $this->assertEquals(2, $this->groupObject->get('test')->getReconnectSleep()); + $this->assertSame(2, $this->groupObject->get('test')->getReconnectSleep()); }); } @@ -118,23 +118,23 @@ public function testGroupUse(): void $this->groupObject->add($pool2); $this->groupObject->add($pool3); - $this->assertEquals(1, $pool1->count()); - $this->assertEquals(1, $pool2->count()); - $this->assertEquals(1, $pool3->count()); + $this->assertSame(1, $pool1->count()); + $this->assertSame(1, $pool2->count()); + $this->assertSame(1, $pool3->count()); // @phpstan-ignore argument.type $this->groupObject->use(['pool1', 'pool3'], function ($one, $three) use ($pool1, $pool2, $pool3): void { - $this->assertEquals('1', $one); - $this->assertEquals('3', $three); + $this->assertSame('1', $one); + $this->assertSame('3', $three); - $this->assertEquals(0, $pool1->count()); - $this->assertEquals(1, $pool2->count()); - $this->assertEquals(0, $pool3->count()); + $this->assertSame(0, $pool1->count()); + $this->assertSame(1, $pool2->count()); + $this->assertSame(0, $pool3->count()); }); - $this->assertEquals(1, $pool1->count()); - $this->assertEquals(1, $pool2->count()); - $this->assertEquals(1, $pool3->count()); + $this->assertSame(1, $pool1->count()); + $this->assertSame(1, $pool2->count()); + $this->assertSame(1, $pool3->count()); }); } } diff --git a/tests/Pools/Scopes/PoolTestScope.php b/tests/Pools/Scopes/PoolTestScope.php index 1a21eab..d427107 100644 --- a/tests/Pools/Scopes/PoolTestScope.php +++ b/tests/Pools/Scopes/PoolTestScope.php @@ -26,7 +26,7 @@ public function testPoolGetName(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals('test', $this->poolObject->getName()); + $this->assertSame('test', $this->poolObject->getName()); }); } @@ -34,7 +34,7 @@ public function testPoolGetSize(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(5, $this->poolObject->getSize()); + $this->assertSame(5, $this->poolObject->getSize()); }); } @@ -42,7 +42,7 @@ public function testPoolGetReconnectAttempts(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(3, $this->poolObject->getReconnectAttempts()); + $this->assertSame(3, $this->poolObject->getReconnectAttempts()); }); } @@ -50,11 +50,11 @@ public function testPoolSetReconnectAttempts(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(3, $this->poolObject->getReconnectAttempts()); + $this->assertSame(3, $this->poolObject->getReconnectAttempts()); $this->poolObject->setReconnectAttempts(20); - $this->assertEquals(20, $this->poolObject->getReconnectAttempts()); + $this->assertSame(20, $this->poolObject->getReconnectAttempts()); }); } @@ -62,7 +62,7 @@ public function testPoolGetReconnectSleep(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(1, $this->poolObject->getReconnectSleep()); + $this->assertSame(1, $this->poolObject->getReconnectSleep()); }); } @@ -70,11 +70,11 @@ public function testPoolSetReconnectSleep(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(1, $this->poolObject->getReconnectSleep()); + $this->assertSame(1, $this->poolObject->getReconnectSleep()); $this->poolObject->setReconnectSleep(20); - $this->assertEquals(20, $this->poolObject->getReconnectSleep()); + $this->assertSame(20, $this->poolObject->getReconnectSleep()); }); } @@ -82,7 +82,7 @@ public function testPoolGetRetryAttempts(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(3, $this->poolObject->getRetryAttempts()); + $this->assertSame(3, $this->poolObject->getRetryAttempts()); }); } @@ -90,11 +90,11 @@ public function testPoolSetRetryAttempts(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(3, $this->poolObject->getRetryAttempts()); + $this->assertSame(3, $this->poolObject->getRetryAttempts()); $this->poolObject->setRetryAttempts(20); - $this->assertEquals(20, $this->poolObject->getRetryAttempts()); + $this->assertSame(20, $this->poolObject->getRetryAttempts()); }); } @@ -102,7 +102,7 @@ public function testPoolGetRetrySleep(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(1, $this->poolObject->getRetrySleep()); + $this->assertSame(1, $this->poolObject->getRetrySleep()); }); } @@ -110,11 +110,11 @@ public function testPoolSetRetrySleep(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(1, $this->poolObject->getRetrySleep()); + $this->assertSame(1, $this->poolObject->getRetrySleep()); $this->poolObject->setRetrySleep(20); - $this->assertEquals(20, $this->poolObject->getRetrySleep()); + $this->assertSame(20, $this->poolObject->getRetrySleep()); }); } @@ -122,14 +122,14 @@ public function testPoolPop(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); $connection = $this->poolObject->pop(); - $this->assertEquals(4, $this->poolObject->count()); + $this->assertSame(4, $this->poolObject->count()); $this->assertInstanceOf(Connection::class, $connection); - $this->assertEquals('x', $connection->getResource()); + $this->assertSame('x', $connection->getResource()); // Pop remaining 4 connections $this->poolObject->pop(); @@ -146,13 +146,13 @@ public function testPoolUse(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); $this->poolObject->use(function ($resource): void { - $this->assertEquals(4, $this->poolObject->count()); - $this->assertEquals('x', $resource); + $this->assertSame(4, $this->poolObject->count()); + $this->assertSame('x', $resource); }); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); }); } @@ -160,18 +160,18 @@ public function testPoolPush(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); $connection = $this->poolObject->pop(); - $this->assertEquals(4, $this->poolObject->count()); + $this->assertSame(4, $this->poolObject->count()); $this->assertInstanceOf(Connection::class, $connection); - $this->assertEquals('x', $connection->getResource()); + $this->assertSame('x', $connection->getResource()); $this->assertInstanceOf(Pool::class, $this->poolObject->push($connection)); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); }); } @@ -179,15 +179,15 @@ public function testPoolCount(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); $connection = $this->poolObject->pop(); - $this->assertEquals(4, $this->poolObject->count()); + $this->assertSame(4, $this->poolObject->count()); $this->poolObject->push($connection); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); }); } @@ -195,17 +195,17 @@ public function testPoolReclaim(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); $this->poolObject->pop(); $this->poolObject->pop(); $this->poolObject->pop(); - $this->assertEquals(2, $this->poolObject->count()); + $this->assertSame(2, $this->poolObject->count()); $this->poolObject->reclaim(); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); }); } @@ -219,7 +219,7 @@ public function testPoolIsEmpty(): void $this->poolObject->pop(); $this->poolObject->pop(); - $this->assertEquals(true, $this->poolObject->isEmpty()); + $this->assertSame(true, $this->poolObject->isEmpty()); }); } @@ -227,15 +227,15 @@ public function testPoolIsFull(): void { $this->execute(function (): void { $this->setUpPool(); - $this->assertEquals(true, $this->poolObject->isFull()); + $this->assertSame(true, $this->poolObject->isFull()); $connection = $this->poolObject->pop(); - $this->assertEquals(false, $this->poolObject->isFull()); + $this->assertSame(false, $this->poolObject->isFull()); $this->poolObject->push($connection); - $this->assertEquals(true, $this->poolObject->isFull()); + $this->assertSame(true, $this->poolObject->isFull()); $this->poolObject->pop(); $this->poolObject->pop(); @@ -243,11 +243,11 @@ public function testPoolIsFull(): void $this->poolObject->pop(); $this->poolObject->pop(); - $this->assertEquals(false, $this->poolObject->isFull()); + $this->assertSame(false, $this->poolObject->isFull()); $this->poolObject->reclaim(); - $this->assertEquals(true, $this->poolObject->isFull()); + $this->assertSame(true, $this->poolObject->isFull()); $this->poolObject->pop(); $this->poolObject->pop(); @@ -255,7 +255,7 @@ public function testPoolIsFull(): void $this->poolObject->pop(); $this->poolObject->pop(); - $this->assertEquals(false, $this->poolObject->isFull()); + $this->assertSame(false, $this->poolObject->isFull()); }); } @@ -294,27 +294,27 @@ public function testPoolDestroy(): void return $i <= 2 ? 'x' : 'y'; }); - $this->assertEquals(2, $object->count()); + $this->assertSame(2, $object->count()); $connection1 = $object->pop(); $connection2 = $object->pop(); - $this->assertEquals(0, $object->count()); + $this->assertSame(0, $object->count()); - $this->assertEquals('x', $connection1->getResource()); - $this->assertEquals('x', $connection2->getResource()); + $this->assertSame('x', $connection1->getResource()); + $this->assertSame('x', $connection2->getResource()); $object->destroy(); - $this->assertEquals(2, $object->count()); + $this->assertSame(2, $object->count()); $connection1 = $object->pop(); $connection2 = $object->pop(); - $this->assertEquals(0, $object->count()); + $this->assertSame(0, $object->count()); - $this->assertEquals('y', $connection1->getResource()); - $this->assertEquals('y', $connection2->getResource()); + $this->assertSame('y', $connection1->getResource()); + $this->assertSame('y', $connection2->getResource()); }); } @@ -338,7 +338,7 @@ public function testPoolTelemetry(): void } }; - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); $allocate(3, function () use ($telemetry): void { /** @var object{values: array} $openGauge */ @@ -347,12 +347,12 @@ public function testPoolTelemetry(): void $activeGauge = $telemetry->gauges['pool.connection.active.count']; /** @var object{values: array} $idleGauge */ $idleGauge = $telemetry->gauges['pool.connection.idle.count']; - $this->assertEquals([1, 2, 3], $openGauge->values); - $this->assertEquals([1, 2, 3], $activeGauge->values); - $this->assertEquals([0, 0, 0], $idleGauge->values); + $this->assertSame([1, 2, 3], $openGauge->values); + $this->assertSame([1, 2, 3], $activeGauge->values); + $this->assertSame([0, 0, 0], $idleGauge->values); }); - $this->assertEquals(5, $this->poolObject->count()); + $this->assertSame(5, $this->poolObject->count()); $allocate(1, function () use ($telemetry): void { /** @var object{values: array} $openGauge */ @@ -361,9 +361,9 @@ public function testPoolTelemetry(): void $activeGauge = $telemetry->gauges['pool.connection.active.count']; /** @var object{values: array} $idleGauge */ $idleGauge = $telemetry->gauges['pool.connection.idle.count']; - $this->assertEquals([1, 2, 3, 3, 3, 3, 3], $openGauge->values); - $this->assertEquals([1, 2, 3, 2, 1, 0, 1], $activeGauge->values); - $this->assertEquals([0, 0, 0, 1, 2, 3, 2], $idleGauge->values); + $this->assertSame([1, 2, 3, 3, 3, 3, 3], $openGauge->values); + $this->assertSame([1, 2, 3, 2, 1, 0, 1], $activeGauge->values); + $this->assertSame([0, 0, 0, 1, 2, 3, 2], $idleGauge->values); }); }); }