From 61a18444ba5e92dd9bc8a97e7528a3ff782f6e3f Mon Sep 17 00:00:00 2001 From: Igor Sheludko Date: Thu, 25 Sep 2025 18:59:53 +0200 Subject: [PATCH 1/2] Avoid pollution of Node's cflags by deps/ncrypto/unofficial.gni --- deps/ncrypto/unofficial.gni | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/deps/ncrypto/unofficial.gni b/deps/ncrypto/unofficial.gni index bfd0d1090a4bac..403b1452486ae5 100644 --- a/deps/ncrypto/unofficial.gni +++ b/deps/ncrypto/unofficial.gni @@ -8,10 +8,12 @@ import("$node_v8_path/gni/v8.gni") # The actual configurations are put inside a template in unofficial.gni to # prevent accidental edits from contributors. template("ncrypto_gn_build") { - config("ncrypto_config") { + config("ncrypto_external_config") { include_dirs = [ "." ] + } + config("ncrypto_internal_config") { cflags = [ - "-Wno-deprecated-declarations", + # "-Wno-deprecated-declarations", "-Wno-pessimizing-move", "-Wno-shadow", "-Wno-unused-variable", @@ -27,7 +29,8 @@ template("ncrypto_gn_build") { source_set(target_name) { forward_variables_from(invoker, "*") - public_configs = [ ":ncrypto_config" ] + configs += [ ":ncrypto_internal_config" ] + public_configs = [ ":ncrypto_external_config" ] sources = gypi_values.ncrypto_sources deps = [ "$node_openssl_path" ] } From 1139d84905ca4c10cc6162e6b97d3295e9435446 Mon Sep 17 00:00:00 2001 From: Igor Sheludko Date: Tue, 7 Oct 2025 14:45:58 +0200 Subject: [PATCH 2/2] cleanup --- deps/ncrypto/unofficial.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/ncrypto/unofficial.gni b/deps/ncrypto/unofficial.gni index 403b1452486ae5..14b0d4b8b224c4 100644 --- a/deps/ncrypto/unofficial.gni +++ b/deps/ncrypto/unofficial.gni @@ -13,7 +13,7 @@ template("ncrypto_gn_build") { } config("ncrypto_internal_config") { cflags = [ - # "-Wno-deprecated-declarations", + "-Wno-deprecated-declarations", "-Wno-pessimizing-move", "-Wno-shadow", "-Wno-unused-variable",