Refactored code

Author: pokki-deploy

src/main/java/in/erail/amazon/lambda/AWSLambda.java

@@ -6,6 +6,7 @@
 import com.google.common.base.Strings;
 import com.google.common.io.ByteStreams;
 import in.erail.glue.Glue;
+import in.erail.model.Event;
 import in.erail.service.RESTService;
 import io.reactivex.Single;
 import io.reactivex.schedulers.Schedulers;
@@ -16,7 +17,6 @@
 import java.io.OutputStream;
 import java.io.OutputStreamWriter;
 import in.erail.model.RequestEvent;
-import in.erail.model.ResponseEvent;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
@@ -69,11 +69,11 @@ public Single<String> handleMessage(JsonObject pRequest) {
             .just(pRequest)
             .subscribeOn(Schedulers.computation())
             .map(this::convertBodyToBase64)
-            .map(reqJson -> reqJson.mapTo(RequestEvent.class))
+            .map(reqJson -> reqJson.mapTo(getService().getRequestEventClass()))
             .doOnSuccess(this::populateSystemProperties)
-            .flatMapMaybe(req -> getService().handleEvent(req))
-            .toSingle(new ResponseEvent())
-            .map(resp -> JsonObject.mapFrom(resp))
+            .flatMapMaybe(req -> getService().handleEvent(getService().createEvent(req)))
+            .toSingle(new Event())
+            .map(resp -> JsonObject.mapFrom(resp.getResponse()))
             .map(this::sanatizeResponse)
             .map(respJson -> respJson.toString());
   }

src/main/java/in/erail/amazon/lambda/service/ProxyService.java

@@ -1,6 +1,7 @@
 package in.erail.amazon.lambda.service;
 
 import com.google.common.base.Joiner;
+import in.erail.model.Event;
 import in.erail.model.RequestEvent;
 import in.erail.model.ResponseEvent;
 import in.erail.server.Server;
@@ -76,12 +77,14 @@ protected String generateURL(RequestEvent pRequest) {
     return sb.toString();
   }
 
-  public MaybeSource<ResponseEvent> process(Maybe<RequestEvent> pRequest) {
+  public MaybeSource<Event> process(Maybe<Event> pRequest) {
     return pRequest.flatMap(this::handle);
   }
 
-  public Maybe<ResponseEvent> handle(RequestEvent proxyRequest) {
+  public Maybe<Event> handle(Event pEvent) {
 
+    RequestEvent proxyRequest = pEvent.getRequest();
+    
     //Build Request
     HttpRequest<Buffer> clientRequest = getWebClient().requestAbs(proxyRequest.getHttpMethod(), generateURL(proxyRequest));
 
@@ -101,24 +104,24 @@ public Maybe<ResponseEvent> handle(RequestEvent proxyRequest) {
     return clientRequest
             .rxSendBuffer(Buffer.buffer(body))
             .map((resp) -> {
-              ResponseEvent event = new ResponseEvent();
+              ResponseEvent responseEvent = pEvent.getResponse();
 
               //Add Headers
               Optional
                       .ofNullable(resp.headers())
                       .orElse(MultiMap.caseInsensitiveMultiMap())
                       .entries()
                       .stream()
-                      .forEach((t) -> event.addHeader(t.getKey(), t.getValue()));
+                      .forEach((t) -> responseEvent.addHeader(t.getKey(), t.getValue()));
 
-              event.setStatusCode(resp.statusCode());
-              event.setIsBase64Encoded(true);
+              responseEvent.setStatusCode(resp.statusCode());
+              responseEvent.setIsBase64Encoded(true);
 
               Optional
                       .ofNullable(resp.body())
-                      .ifPresent(b -> event.setBody(b.getBytes()));
+                      .ifPresent(b -> responseEvent.setBody(b.getBytes()));
 
-              return event;
+              return pEvent;
             })
             .doOnSuccess(e -> getLog().debug(() -> e.toString()))
             .toMaybe();

src/main/java/in/erail/service/HelloService.java

@@ -1,8 +1,7 @@
 package in.erail.service;
 
 import com.google.common.net.MediaType;
-import in.erail.model.RequestEvent;
-import in.erail.model.ResponseEvent;
+import in.erail.model.Event;
 import io.reactivex.Maybe;
 import io.reactivex.MaybeSource;
 import io.vertx.core.json.JsonArray;
@@ -19,14 +18,14 @@ public HelloService() {
     mHelloData.add("S5");
   }
 
-  
   @Override
-  public MaybeSource<ResponseEvent> process(Maybe<RequestEvent> pRequest) {
-      return Maybe.just(new ResponseEvent()
-              .setBody(getHelloData().toString().getBytes())
-              .setMediaType(MediaType.JSON_UTF_8));
+  public MaybeSource<Event> process(Maybe<Event> pEvent) {
+    return pEvent.doOnSuccess(e -> e
+            .getResponse()
+            .setBody(getHelloData().toString().getBytes())
+            .setMediaType(MediaType.JSON_UTF_8));
   }
-  
+
   public JsonArray getHelloData() {
     return mHelloData;
   }