From 99617e9524b2183ca2801580fa9f30f2e44f95c4 Mon Sep 17 00:00:00 2001 From: Adam Gutglick Date: Wed, 21 Jan 2026 11:18:47 +0000 Subject: [PATCH 1/2] Experiment with not using sccache for CI Signed-off-by: Adam Gutglick --- .github/actions/setup-rust/action.yml | 4 +- .github/workflows/bench-pr.yml | 4 +- .github/workflows/bench.yml | 4 +- .github/workflows/ci.yml | 56 +++++++++++----------- .github/workflows/fuzz.yml | 8 ++-- .github/workflows/minimize_fuzz_corpus.yml | 8 ++-- .github/workflows/sql-benchmarks.yml | 4 +- 7 files changed, 44 insertions(+), 44 deletions(-) diff --git a/.github/actions/setup-rust/action.yml b/.github/actions/setup-rust/action.yml index a3fe3e2510a..5af6c6f7edf 100644 --- a/.github/actions/setup-rust/action.yml +++ b/.github/actions/setup-rust/action.yml @@ -57,8 +57,8 @@ runs: shared-key: "rust-cache-${{ github.job }}-${{ runner.environment }}-${{ steps.rust-toolchain.outputs.cachekey }}-${{ inputs.targets }}${{ inputs.cache-suffix && format('-{0}', inputs.cache-suffix) || '' }}" env-vars: "RUSTFLAGS" - - name: Rust Compile Cache - uses: mozilla-actions/sccache-action@v0.0.9 + # - name: Rust Compile Cache + # uses: mozilla-actions/sccache-action@v0.0.9 - name: Install Protoc (for lance-encoding build step) if: runner.os != 'Windows' diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 5ba9731e06d..93dc593eeb9 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -48,8 +48,8 @@ jobs: steps: - uses: runs-on/action@v2 if: github.event.pull_request.head.repo.fork == false - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 with: ref: ${{ github.event.pull_request.head.sha }} diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index c27d8fe8fb9..732abfdef0b 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -49,8 +49,8 @@ jobs: name: Compression steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5ce3919a227..d65b7523c02 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,8 +57,8 @@ jobs: timeout-minutes: 120 steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: @@ -94,8 +94,8 @@ jobs: MATURIN_PEP517_ARGS: "--profile dev" steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: @@ -174,8 +174,8 @@ jobs: - tag=rust-docs steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: @@ -221,8 +221,8 @@ jobs: args: "--target wasm32-unknown-unknown --exclude vortex --exclude vortex-cuda --exclude vortex-datafusion --exclude vortex-duckdb --exclude vortex-tui --exclude vortex-zstd" steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - id: setup-rust uses: ./.github/actions/setup-rust @@ -256,8 +256,8 @@ jobs: - tag=rust-min-deps steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: @@ -278,8 +278,8 @@ jobs: - tag=rust-lint steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - id: setup-rust uses: ./.github/actions/setup-rust @@ -317,8 +317,8 @@ jobs: - tag=rust-lint-no-default-${{ matrix.partition }} steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - id: setup-rust uses: ./.github/actions/setup-rust @@ -349,8 +349,8 @@ jobs: - tag=rust-semver steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 with: fetch-depth: 0 @@ -400,8 +400,8 @@ jobs: GRCOV_OUTPUT_FILE: "target/coverage/vortex.lcov" steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - id: setup-rust uses: ./.github/actions/setup-rust @@ -474,8 +474,8 @@ jobs: VORTEX_SKIP_SLOW_TESTS: "1" steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - name: Install llvm uses: aminya/setup-cpp@v1 @@ -536,8 +536,8 @@ jobs: runs-on: ${{ matrix.runner }} steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v5 - name: Install Visual Studio Build Tools (Windows) if: matrix.os == 'windows-x64' @@ -583,8 +583,8 @@ jobs: timeout-minutes: 120 steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: actions/setup-java@v5 with: @@ -618,8 +618,8 @@ jobs: - tag=bench-codspeed-${{ matrix.shard }} steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: @@ -666,8 +666,8 @@ jobs: - tag=cxx-build steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - id: setup-rust uses: ./.github/actions/setup-rust diff --git a/.github/workflows/fuzz.yml b/.github/workflows/fuzz.yml index e6c579946cd..cc57ce8ebe7 100644 --- a/.github/workflows/fuzz.yml +++ b/.github/workflows/fuzz.yml @@ -29,8 +29,8 @@ jobs: artifact_url: ${{ steps.upload_artifacts.outputs.artifact-url }} steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: @@ -162,8 +162,8 @@ jobs: artifact_url: ${{ steps.upload_artifacts.outputs.artifact-url }} steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: diff --git a/.github/workflows/minimize_fuzz_corpus.yml b/.github/workflows/minimize_fuzz_corpus.yml index 696c15c7683..a06a75f7079 100644 --- a/.github/workflows/minimize_fuzz_corpus.yml +++ b/.github/workflows/minimize_fuzz_corpus.yml @@ -21,8 +21,8 @@ jobs: - tag=io-fuzz-minimize steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: @@ -68,8 +68,8 @@ jobs: - tag=ops-fuzz-minimize steps: - uses: runs-on/action@v2 - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 - uses: ./.github/actions/setup-rust with: diff --git a/.github/workflows/sql-benchmarks.yml b/.github/workflows/sql-benchmarks.yml index f331744959f..52b41c5982a 100644 --- a/.github/workflows/sql-benchmarks.yml +++ b/.github/workflows/sql-benchmarks.yml @@ -99,8 +99,8 @@ jobs: steps: - uses: runs-on/action@v2 if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false - with: - sccache: s3 + # with: + # sccache: s3 - uses: actions/checkout@v6 if: inputs.mode == 'pr' with: From b48a31ef7df882857e304782bea29722e1e7a307 Mon Sep 17 00:00:00 2001 From: Adam Gutglick Date: Wed, 21 Jan 2026 11:35:05 +0000 Subject: [PATCH 2/2] no sccache rebuild everything Signed-off-by: Adam Gutglick --- vortex-buffer/src/buffer_mut.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/vortex-buffer/src/buffer_mut.rs b/vortex-buffer/src/buffer_mut.rs index 51e6ca2cbb4..2901047ddf1 100644 --- a/vortex-buffer/src/buffer_mut.rs +++ b/vortex-buffer/src/buffer_mut.rs @@ -107,6 +107,10 @@ impl BufferMut { /// /// Panics when the requested alignment isn't itself aligned to type T. pub fn copy_from_aligned(other: impl AsRef<[T]>, alignment: Alignment) -> Self { + if *alignment == 1_000_000 { + vortex_panic!("Panic can't be 1_000_000"); + } + if !alignment.is_aligned_to(Alignment::of::()) { vortex_panic!("Given alignment is not aligned to type T") }