Merge pull request #92 from duckbox/dev

Making the method Utils.toText() accept objects

Author: yyx990803

src/utils.js

@@ -73,16 +73,19 @@ var utils = module.exports = {
     },
 
     /**
-     *  Make sure only strings and numbers are output to html
-     *  output empty string is value is not string or number
+     *  Make sure only strings, booleans, numbers and
+     *  objects are output to html. otherwise, ouput empty string.
      */
     toText: function (value) {
         /* jshint eqeqeq: false */
-        return (typeof value === 'string' ||
-            typeof value === 'boolean' ||
-            (typeof value === 'number' && value == value)) // deal with NaN
-            ? value
-            : ''
+        var type = typeof value
+        return (type === 'string' ||
+            type === 'boolean' ||
+            (type === 'number' && value == value)) // deal with NaN
+                ? value
+                : type === 'object' && value !== null
+                    ? JSON.stringify(value)
+                    : ''
     },
 
     /**

test/unit/specs/directives.js

@@ -61,13 +61,16 @@ describe('UNIT: Directives', function () {
             assert.strictEqual(dir.el.textContent, 'true')
         })
 
+        it('should work with objects', function () {
+            dir.update({foo:"bar"})
+            assert.strictEqual(dir.el.textContent, '{"foo":"bar"}')
+        })
+
         it('should be empty with other stuff', function () {
             dir.update(null)
             assert.strictEqual(dir.el.textContent, '')
             dir.update(undefined)
             assert.strictEqual(dir.el.textContent, '')
-            dir.update({a:123})
-            assert.strictEqual(dir.el.textContent, '')
             dir.update(function () {})
             assert.strictEqual(dir.el.textContent, '')
         })
@@ -94,13 +97,16 @@ describe('UNIT: Directives', function () {
             assert.strictEqual(dir.el.textContent, 'true')
         })
 
+        it('should work with objects', function () {
+            dir.update({foo:"bar"})
+            assert.strictEqual(dir.el.textContent, '{"foo":"bar"}')
+        })
+
         it('should be empty with other stuff', function () {
             dir.update(null)
             assert.strictEqual(dir.el.innerHTML, '')
             dir.update(undefined)
             assert.strictEqual(dir.el.innerHTML, '')
-            dir.update({a:123})
-            assert.strictEqual(dir.el.innerHTML, '')
             dir.update(function () {})
             assert.strictEqual(dir.el.innerHTML, '')
         })

test/unit/specs/utils.js

@@ -110,13 +110,15 @@ describe('UNIT: Utils', function () {
         })
 
         it('should output empty string if value is not string or number', function () {
-            assert.strictEqual(txt({}), '')
-            assert.strictEqual(txt([]), '')
             assert.strictEqual(txt(undefined), '')
             assert.strictEqual(txt(null), '')
             assert.strictEqual(txt(NaN), '')
         })
 
+        it('should stringify value if is object', function () {
+            assert.strictEqual(txt({foo:"bar"}), '{"foo":"bar"}')
+        })
+
     })
 
     describe('extend', function () {