default bracketed paste mode ON, add context menu (#2639)

We were too conservative by defaulting ignorebrackedpastemode in
xterm.js to true. it should have been set to false. this solves issues
with pasting multi-line strings into zsh, claude code, etc.

add a new context menu option to more easily disable if you're in a
weird ssh session or a REPL that doesn't support bracketedpaste.

Author: sawka

frontend/app/view/term/term-model.ts

@@ -55,11 +55,13 @@ export class TermViewModel implements ViewModel {
     fontSizeAtom: jotai.Atom<number>;
     termThemeNameAtom: jotai.Atom<string>;
     termTransparencyAtom: jotai.Atom<number>;
+    termBPMAtom: jotai.Atom<boolean>;
     noPadding: jotai.PrimitiveAtom<boolean>;
     endIconButtons: jotai.Atom<IconButtonDecl[]>;
     shellProcFullStatus: jotai.PrimitiveAtom<BlockControllerRuntimeStatus>;
     shellProcStatus: jotai.Atom<string>;
     shellProcStatusUnsubFn: () => void;
+    termBPMUnsubFn: () => void;
     isCmdController: jotai.Atom<boolean>;
     isRestarting: jotai.PrimitiveAtom<boolean>;
     searchAtoms?: SearchAtoms;
@@ -204,6 +206,7 @@ export class TermViewModel implements ViewModel {
             return true;
         });
         this.filterOutNowsh = jotai.atom(false);
+        this.termBPMAtom = getOverrideConfigAtom(blockId, "term:allowbracketedpaste");
         this.termThemeNameAtom = useBlockAtom(blockId, "termthemeatom", () => {
             return jotai.atom<string>((get) => {
                 return get(getOverrideConfigAtom(this.blockId, "term:theme")) ?? DefaultTermTheme;
@@ -313,6 +316,12 @@ export class TermViewModel implements ViewModel {
             const fullStatus = get(this.shellProcFullStatus);
             return fullStatus?.shellprocstatus ?? "init";
         });
+        this.termBPMUnsubFn = globalStore.sub(this.termBPMAtom, () => {
+            if (this.termRef.current?.terminal) {
+                const allowBPM = globalStore.get(this.termBPMAtom) ?? true;
+                this.termRef.current.terminal.options.ignoreBracketedPasteMode = !allowBPM;
+            }
+        });
     }
 
     getShellIntegrationIconButton(get: jotai.Getter): IconButtonDecl | null {
@@ -447,6 +456,9 @@ export class TermViewModel implements ViewModel {
         if (this.shellProcStatusUnsubFn) {
             this.shellProcStatusUnsubFn();
         }
+        if (this.termBPMUnsubFn) {
+            this.termBPMUnsubFn();
+        }
     }
 
     giveFocus(): boolean {
@@ -579,6 +591,7 @@ export class TermViewModel implements ViewModel {
         const termThemeKeys = Object.keys(termThemes);
         const curThemeName = globalStore.get(getBlockMetaKeyAtom(this.blockId, "term:theme"));
         const defaultFontSize = globalStore.get(getSettingsKeyAtom("term:fontsize")) ?? 12;
+        const defaultAllowBracketedPaste = globalStore.get(getSettingsKeyAtom("term:allowbracketedpaste")) ?? true;
         const transparencyMeta = globalStore.get(getBlockMetaKeyAtom(this.blockId, "term:transparency"));
         const blockData = globalStore.get(this.blockAtom);
         const overrideFontSize = blockData?.meta?.["term:fontsize"];
@@ -674,6 +687,45 @@ export class TermViewModel implements ViewModel {
             label: "Transparency",
             submenu: transparencySubMenu,
         });
+        const allowBracketedPaste = blockData?.meta?.["term:allowbracketedpaste"];
+        fullMenu.push({
+            label: "Allow Bracketed Paste Mode",
+            submenu: [
+                {
+                    label: "Default (" + (defaultAllowBracketedPaste ? "On" : "Off") + ")",
+                    type: "checkbox",
+                    checked: allowBracketedPaste == null,
+                    click: () => {
+                        RpcApi.SetMetaCommand(TabRpcClient, {
+                            oref: WOS.makeORef("block", this.blockId),
+                            meta: { "term:allowbracketedpaste": null },
+                        });
+                    },
+                },
+                {
+                    label: "On",
+                    type: "checkbox",
+                    checked: allowBracketedPaste === true,
+                    click: () => {
+                        RpcApi.SetMetaCommand(TabRpcClient, {
+                            oref: WOS.makeORef("block", this.blockId),
+                            meta: { "term:allowbracketedpaste": true },
+                        });
+                    },
+                },
+                {
+                    label: "Off",
+                    type: "checkbox",
+                    checked: allowBracketedPaste === false,
+                    click: () => {
+                        RpcApi.SetMetaCommand(TabRpcClient, {
+                            oref: WOS.makeORef("block", this.blockId),
+                            meta: { "term:allowbracketedpaste": false },
+                        });
+                    },
+                },
+            ],
+        });
         fullMenu.push({ type: "separator" });
         fullMenu.push({
             label: "Force Restart Controller",

frontend/app/view/term/term.tsx

@@ -245,7 +245,6 @@ const TerminalView = ({ blockId, model }: ViewComponentProps<TermViewModel>) =>
         const fullConfig = globalStore.get(atoms.fullConfigAtom);
         const termThemeName = globalStore.get(model.termThemeNameAtom);
         const termTransparency = globalStore.get(model.termTransparencyAtom);
-        const termBPMAtom = getOverrideConfigAtom(blockId, "term:allowbracketedpaste");
         const termMacOptionIsMetaAtom = getOverrideConfigAtom(blockId, "term:macoptionismeta");
         const [termTheme, _] = computeTheme(fullConfig, termThemeName, termTransparency);
         let termScrollback = 2000;
@@ -261,7 +260,7 @@ const TerminalView = ({ blockId, model }: ViewComponentProps<TermViewModel>) =>
         if (termScrollback > 50000) {
             termScrollback = 50000;
         }
-        const termAllowBPM = globalStore.get(termBPMAtom) ?? false;
+        const termAllowBPM = globalStore.get(model.termBPMAtom) ?? true;
         const termMacOptionIsMeta = globalStore.get(termMacOptionIsMetaAtom) ?? false;
         const wasFocused = model.termRef.current != null && globalStore.get(model.nodeModel.isFocused);
         const termWrap = new TermWrap(

pkg/blockcontroller/shellcontroller.go

@@ -204,6 +204,7 @@ func (sc *ShellController) resetTerminalState(logCtx context.Context) {
 	buf.WriteString("\x1b[?25h")                     // show cursor
 	buf.WriteString("\x1b[?1000l")                   // disable mouse tracking
 	buf.WriteString("\x1b[?1007l")                   // disable alternate scroll mode
+	buf.WriteString("\x1b[?2004l")                   // disable bracketed paste mode
 	buf.WriteString(shellutil.FormatOSC(16162, "R")) // OSC 16162 "R" - disable alternate screen mode (only if active), reset "shell integration" status.
 	buf.WriteString("\r\n\r\n")
 	err := HandleAppendBlockFile(sc.BlockId, wavebase.BlockFile_Term, buf.Bytes())