feat: add url config to css parser (#10229)

Author: stormslowly

crates/node_binding/binding.d.ts

@@ -1621,6 +1621,7 @@ export interface RawCssAutoGeneratorOptions {
 
 export interface RawCssAutoParserOptions {
   namedExports?: boolean
+  url?: boolean
 }
 
 export interface RawCssExtractPluginOption {
@@ -1649,10 +1650,12 @@ export interface RawCssModuleGeneratorOptions {
 
 export interface RawCssModuleParserOptions {
   namedExports?: boolean
+  url?: boolean
 }
 
 export interface RawCssParserOptions {
   namedExports?: boolean
+  url?: boolean
 }
 
 export interface RawDllEntryPluginOptions {

crates/node_binding/src/raw_options/raw_module/mod.rs

@@ -409,12 +409,14 @@ impl From<RawAssetParserDataUrlOptions> for AssetParserDataUrlOptions {
 #[napi(object)]
 pub struct RawCssParserOptions {
   pub named_exports: Option<bool>,
+  pub url: Option<bool>,
 }
 
 impl From<RawCssParserOptions> for CssParserOptions {
   fn from(value: RawCssParserOptions) -> Self {
     Self {
       named_exports: value.named_exports,
+      url: value.url,
     }
   }
 }
@@ -423,12 +425,14 @@ impl From<RawCssParserOptions> for CssParserOptions {
 #[napi(object)]
 pub struct RawCssAutoParserOptions {
   pub named_exports: Option<bool>,
+  pub url: Option<bool>,
 }
 
 impl From<RawCssAutoParserOptions> for CssAutoParserOptions {
   fn from(value: RawCssAutoParserOptions) -> Self {
     Self {
       named_exports: value.named_exports,
+      url: value.url,
     }
   }
 }
@@ -437,12 +441,14 @@ impl From<RawCssAutoParserOptions> for CssAutoParserOptions {
 #[napi(object)]
 pub struct RawCssModuleParserOptions {
   pub named_exports: Option<bool>,
+  pub url: Option<bool>,
 }
 
 impl From<RawCssModuleParserOptions> for CssModuleParserOptions {
   fn from(value: RawCssModuleParserOptions) -> Self {
     Self {
       named_exports: value.named_exports,
+      url: value.url,
     }
   }
 }

crates/rspack/src/builder/mod.rs

@@ -1731,16 +1731,19 @@ impl ModuleOptionsBuilder {
     if css {
       let css_parser_options = ParserOptions::Css(CssParserOptions {
         named_exports: Some(true),
+        url: Some(true),
       });
       parser.insert("css".to_string(), css_parser_options.clone());
 
       let css_auto_parser_options = ParserOptions::CssAuto(CssAutoParserOptions {
         named_exports: Some(true),
+        url: Some(true),
       });
       parser.insert("css/auto".to_string(), css_auto_parser_options);
 
       let css_module_parser_options = ParserOptions::CssModule(CssModuleParserOptions {
         named_exports: Some(true),
+        url: Some(true),
       });
       parser.insert("css/module".to_string(), css_module_parser_options);
 

crates/rspack_core/src/options/module.rs

@@ -286,18 +286,21 @@ pub struct AssetParserDataUrlOptions {
 #[derive(Debug, Clone, MergeFrom)]
 pub struct CssParserOptions {
   pub named_exports: Option<bool>,
+  pub url: Option<bool>,
 }
 
 #[cacheable]
 #[derive(Debug, Clone, MergeFrom)]
 pub struct CssAutoParserOptions {
   pub named_exports: Option<bool>,
+  pub url: Option<bool>,
 }
 
 impl From<CssParserOptions> for CssAutoParserOptions {
   fn from(value: CssParserOptions) -> Self {
     Self {
       named_exports: value.named_exports,
+      url: value.url,
     }
   }
 }
@@ -306,12 +309,14 @@ impl From<CssParserOptions> for CssAutoParserOptions {
 #[derive(Debug, Clone, MergeFrom)]
 pub struct CssModuleParserOptions {
   pub named_exports: Option<bool>,
+  pub url: Option<bool>,
 }
 
 impl From<CssParserOptions> for CssModuleParserOptions {
   fn from(value: CssParserOptions) -> Self {
     Self {
       named_exports: value.named_exports,
+      url: value.url,
     }
   }
 }

crates/rspack_plugin_css/src/parser_and_generator/mod.rs

@@ -80,6 +80,7 @@ pub struct CssParserAndGenerator {
   pub exports_only: bool,
   pub named_exports: bool,
   pub es_module: bool,
+  pub url: bool,
   #[cacheable(with=AsOption<AsMap<AsCacheable, AsVec>>)]
   pub exports: Option<CssExports>,
   pub local_names: Option<FxHashMap<String, String>>,
@@ -168,6 +169,10 @@ impl ParserAndGenerator for CssParserAndGenerator {
           if request.trim().is_empty() {
             continue;
           }
+          if !self.url {
+            continue;
+          }
+
           let request = replace_module_request_prefix(
             request,
             &mut diagnostics,

crates/rspack_plugin_css/src/plugin/impl_plugin_for_css_plugin.rs

@@ -488,6 +488,7 @@ impl Plugin for CssPlugin {
           named_exports: p.named_exports.expect("should have named_exports"),
           es_module: g.es_module.expect("should have es_module"),
           hot: false,
+          url: p.url.expect("should have url"),
         }) as Box<dyn ParserAndGenerator>
       }),
     );
@@ -516,6 +517,7 @@ impl Plugin for CssPlugin {
           named_exports: p.named_exports.expect("should have named_exports"),
           es_module: g.es_module.expect("should have es_module"),
           hot: false,
+          url: p.url.expect("should have url"),
         }) as Box<dyn ParserAndGenerator>
       }),
     );
@@ -544,6 +546,7 @@ impl Plugin for CssPlugin {
           named_exports: p.named_exports.expect("should have named_exports"),
           es_module: g.es_module.expect("should have es_module"),
           hot: false,
+          url: p.url.expect("should have url"),
         }) as Box<dyn ParserAndGenerator>
       }),
     );

packages/rspack-test-tools/tests/defaultsCases/experiments/future-defaults.js

@@ -41,15 +41,15 @@ module.exports = {
 		+           Object {
 		+             "descriptionData": Object {
 		+               "type": "module",
-		+             },
+		@@ ... @@
 		+             "resolve": Object {
 		+               "fullySpecified": true,
 		+             },
 		+           },
 		+         ],
 		+         "type": "webassembly/async",
 		+       },
-		+       Object {
+		@@ ... @@
 		+         "resolve": Object {
 		+           "fullySpecified": true,
 		+           "preferRelative": true,
@@ -72,6 +72,8 @@ module.exports = {
 		+           "preferRelative": true,
 		+         },
 		+         "type": "css",
+		+       },
+		+       Object {
 		@@ ... @@
 		+       "css": Object {
 		+         "esModule": true,
@@ -94,20 +96,21 @@ module.exports = {
 		+       },
 		+       "css": Object {
 		+         "namedExports": true,
-		@@ ... @@
+		+         "url": true,
+		+       },
 		+       "css/auto": Object {
 		+         "namedExports": true,
-		+       },
+		+         "url": true,
+		@@ ... @@
 		+       "css/module": Object {
 		+         "namedExports": true,
+		+         "url": true,
 		@@ ... @@
 		+         "css",
 		@@ ... @@
 		-     "charset": true,
 		+     "charset": false,
 		@@ ... @@
-		+           "...",
-		+         ],
 		+       },
 		+       "css-import": Object {
 		+         "conditionNames": Array [
@@ -120,7 +123,8 @@ module.exports = {
 		+         ],
 		+         "mainFields": Array [
 		+           "style",
-		@@ ... @@
+		+           "...",
+		+         ],
 		+         "mainFiles": Array [],
 		+         "preferRelative": true,
 	`)

packages/rspack/src/config/adapter.ts

@@ -607,7 +607,8 @@ function getRawCssParserOptions(
 	parser: CssParserOptions
 ): RawCssParserOptions | RawCssAutoParserOptions | RawCssModuleParserOptions {
 	return {
-		namedExports: parser.namedExports
+		namedExports: parser.namedExports,
+		url: parser.url
 	};
 }
 

packages/rspack/src/config/defaults.ts

@@ -344,14 +344,17 @@ const applyModuleDefaults = (
 		F(module.parser, "css", () => ({}));
 		assertNotNill(module.parser.css);
 		D(module.parser.css, "namedExports", true);
+		D(module.parser.css, "url", true);
 
 		F(module.parser, "css/auto", () => ({}));
 		assertNotNill(module.parser["css/auto"]);
 		D(module.parser["css/auto"], "namedExports", true);
+		D(module.parser["css/auto"], "url", true);
 
 		F(module.parser, "css/module", () => ({}));
 		assertNotNill(module.parser["css/module"]);
 		D(module.parser["css/module"], "namedExports", true);
+		D(module.parser["css/module"], "url", true);
 
 		// IGNORE(module.generator): already check to align in 2024.6.27
 		F(module.generator, "css", () => ({}));

packages/rspack/src/config/types.ts

@@ -962,6 +962,7 @@ export type AssetParserOptions = {
 };
 
 export type CssParserNamedExports = boolean;
+export type CssParserUrl = boolean;
 
 /** Options object for `css` modules. */
 export type CssParserOptions = {
@@ -970,6 +971,12 @@ export type CssParserOptions = {
 	 * @default true
 	 * */
 	namedExports?: CssParserNamedExports;
+
+	/**
+	 * Allow to enable/disables handling the CSS functions url.
+	 * @default true
+	 * */
+	url?: CssParserUrl;
 };
 
 /** Options object for `css/auto` modules. */
@@ -979,6 +986,12 @@ export type CssAutoParserOptions = {
 	 * @default true
 	 * */
 	namedExports?: CssParserNamedExports;
+
+	/**
+	 * Allow to enable/disables handling the CSS functions url.
+	 * @default true
+	 * */
+	url?: CssParserUrl;
 };
 
 /** Options object for `css/module` modules. */
@@ -988,6 +1001,12 @@ export type CssModuleParserOptions = {
 	 * @default true
 	 * */
 	namedExports?: CssParserNamedExports;
+
+	/**
+	 * Allow to enable/disables handling the CSS functions url.
+	 * @default true
+	 * */
+	url?: CssParserUrl;
 };
 
 type ExportsPresence = "error" | "warn" | "auto" | false;