refactor: render runtime module identifier by runtime template (#12360)

* refactor: render runtime module name by runtime template

* refactor: render runtime module name by runtime template

* refactor: render runtime module name by runtime template

Author: LingyuCoder

crates/rspack_binding_api/src/module.rs

@@ -3,7 +3,7 @@ use std::{any::TypeId, cell::RefCell, ptr::NonNull, sync::Arc};
 
 use napi::{CallContext, JsObject, JsString, JsSymbol, NapiRaw};
 use napi_derive::napi;
-use rspack_collections::{IdentifierMap, UkeyMap};
+use rspack_collections::{Identifier, IdentifierMap, UkeyMap};
 use rspack_core::{
   BindingCell, BuildMeta, BuildMetaDefaultObject, BuildMetaExportsType, Compilation, CompilerId,
   FactoryMeta, LibIdentOptions, Module as _, ModuleIdentifier, RuntimeModuleStage, SourceType,
@@ -765,7 +765,7 @@ pub struct JsAddingRuntimeModule {
 impl From<JsAddingRuntimeModule> for RuntimeModuleFromJs {
   fn from(value: JsAddingRuntimeModule) -> Self {
     Self {
-      name: value.name,
+      id: Identifier::from(value.name),
       full_hash: value.full_hash,
       dependent_hash: value.dependent_hash,
       isolate: value.isolate,

crates/rspack_binding_api/src/plugins/interceptor.rs

@@ -1347,7 +1347,7 @@ impl CompilationRuntimeModule for CompilationRuntimeModuleTap {
         name: module
           .name()
           .as_str()
-          .cow_replace("webpack/runtime/", "")
+          .cow_replace(compilation.runtime_template.runtime_module_prefix(), "")
           .into_owned(),
       },
       chunk: ChunkWrapper::new(*chunk_ukey, compilation),

crates/rspack_core/src/runtime_template.rs

@@ -231,6 +231,10 @@ impl RuntimeTemplate {
   pub fn render_runtime_variable(&self, runtime_variable: &RuntimeVariable) -> String {
     runtime_variable_to_string(runtime_variable, &self.compiler_options)
   }
+
+  pub fn runtime_module_prefix(&self) -> &'static str {
+    "webpack/runtime/"
+  }
 }
 
 fn to_string(val: &Operand, runtime_globals: &Map<String, Value>) -> String {

crates/rspack_plugin_css/src/plugin/impl_plugin_for_css_plugin.rs

@@ -13,7 +13,7 @@ use rspack_core::{
   CompilationContentHash, CompilationId, CompilationParams, CompilationRenderManifest,
   CompilationRuntimeRequirementInTree, CompilerCompilation, DependencyType, ManifestAssetType,
   Module, ModuleGraph, ModuleType, ParserAndGenerator, PathData, Plugin, PublicPath,
-  RenderManifestEntry, RuntimeGlobals, SelfModuleFactory, SourceType,
+  RenderManifestEntry, RuntimeGlobals, RuntimeModuleExt, SelfModuleFactory, SourceType,
   get_css_chunk_filename_template,
   rspack_sources::{
     BoxSource, CachedSource, ConcatSource, RawStringSource, ReplaceSource, Source, SourceExt,
@@ -332,7 +332,10 @@ async fn runtime_requirements_in_tree(
     runtime_requirements_mut.insert(RuntimeGlobals::HAS_OWN_PROPERTY);
     runtime_requirements_mut.insert(RuntimeGlobals::MODULE_FACTORIES_ADD_ONLY);
     runtime_requirements_mut.insert(RuntimeGlobals::MAKE_NAMESPACE_OBJECT);
-    compilation.add_runtime_module(chunk_ukey, Box::<CssLoadingRuntimeModule>::default())?;
+    compilation.add_runtime_module(
+      chunk_ukey,
+      CssLoadingRuntimeModule::new(&compilation.runtime_template).boxed(),
+    )?;
   }
 
   Ok(None)

crates/rspack_plugin_css/src/runtime/mod.rs

@@ -3,7 +3,7 @@ use std::{borrow::Cow, ptr::NonNull};
 use rspack_collections::Identifier;
 use rspack_core::{
   BooleanMatcher, ChunkGroupOrderKey, ChunkUkey, Compilation, CrossOriginLoading, RuntimeGlobals,
-  RuntimeModule, RuntimeModuleStage, compile_boolean_matcher, impl_runtime_module,
+  RuntimeModule, RuntimeModuleStage, RuntimeTemplate, compile_boolean_matcher, impl_runtime_module,
 };
 use rspack_plugin_runtime::{
   CreateLinkData, LinkPrefetchData, LinkPreloadData, RuntimeModuleChunkWrapper, RuntimePlugin,
@@ -18,13 +18,17 @@ pub struct CssLoadingRuntimeModule {
   chunk: Option<ChunkUkey>,
 }
 
-impl Default for CssLoadingRuntimeModule {
-  fn default() -> Self {
-    Self::with_default(Identifier::from("webpack/runtime/css_loading"), None)
+impl CssLoadingRuntimeModule {
+  pub fn new(runtime_template: &RuntimeTemplate) -> Self {
+    Self::with_default(
+      Identifier::from(format!(
+        "{}css_loading",
+        runtime_template.runtime_module_prefix()
+      )),
+      None,
+    )
   }
-}
 
-impl CssLoadingRuntimeModule {
   fn template_id(&self, id: TemplateId) -> String {
     let base_id = self.id.to_string();
 

crates/rspack_plugin_esm_library/src/render.rs

@@ -254,7 +254,7 @@ impl EsmLibraryPlugin {
       if !compilation
         .chunk_graph
         .get_chunk_runtime_modules_iterable(chunk_ukey)
-        .any(|m| m.contains(EXPORT_REQUIRE_RUNTIME_MODULE_ID.as_str()))
+        .any(|m| m.contains(EXPORT_REQUIRE_RUNTIME_MODULE_ID))
         && tree_runtime_requirements.contains(RuntimeGlobals::REQUIRE)
       {
         export_specifiers.insert(Cow::Owned(

crates/rspack_plugin_extract_css/src/plugin.rs

@@ -535,6 +535,7 @@ async fn runtime_requirement_in_tree(
     compilation.add_runtime_module(
       chunk_ukey,
       Box::new(GetChunkFilenameRuntimeModule::new(
+        &compilation.runtime_template,
         "css",
         "mini-css",
         SOURCE_TYPE[0],
@@ -565,6 +566,7 @@ async fn runtime_requirement_in_tree(
     compilation.add_runtime_module(
       chunk_ukey,
       Box::new(CssLoadingRuntimeModule::new(
+        &compilation.runtime_template,
         *chunk_ukey,
         self.options.attributes.clone(),
         self.options.link_type.clone(),

crates/rspack_plugin_extract_css/src/runtime.rs

@@ -1,10 +1,10 @@
 use std::ptr::NonNull;
 
 use itertools::Itertools;
-use rspack_collections::UkeySet;
+use rspack_collections::{Identifier, UkeySet};
 use rspack_core::{
   BooleanMatcher, ChunkUkey, Compilation, RuntimeGlobals, RuntimeModule, RuntimeModuleStage,
-  compile_boolean_matcher, impl_runtime_module,
+  RuntimeTemplate, compile_boolean_matcher, impl_runtime_module,
 };
 use rspack_error::Result;
 use rspack_plugin_runtime::{
@@ -18,6 +18,7 @@ use crate::plugin::{InsertType, SOURCE_TYPE};
 #[impl_runtime_module]
 #[derive(Debug)]
 pub(crate) struct CssLoadingRuntimeModule {
+  id: Identifier,
   chunk: ChunkUkey,
   attributes: FxHashMap<String, String>,
   link_type: Option<String>,
@@ -26,12 +27,22 @@ pub(crate) struct CssLoadingRuntimeModule {
 
 impl CssLoadingRuntimeModule {
   pub(crate) fn new(
+    runtime_template: &RuntimeTemplate,
     chunk: ChunkUkey,
     attributes: FxHashMap<String, String>,
     link_type: Option<String>,
     insert: InsertType,
   ) -> Self {
-    Self::with_default(chunk, attributes, link_type, insert)
+    Self::with_default(
+      Identifier::from(format!(
+        "{}css loading",
+        runtime_template.runtime_module_prefix()
+      )),
+      chunk,
+      attributes,
+      link_type,
+      insert,
+    )
   }
 
   fn get_css_chunks(&self, compilation: &Compilation) -> UkeySet<ChunkUkey> {
@@ -68,7 +79,7 @@ enum TemplateId {
 #[async_trait::async_trait]
 impl RuntimeModule for CssLoadingRuntimeModule {
   fn name(&self) -> rspack_collections::Identifier {
-    "webpack/runtime/css loading".into()
+    self.id
   }
 
   fn stage(&self) -> RuntimeModuleStage {

crates/rspack_plugin_hmr/src/hot_module_replacement.rs

@@ -1,5 +1,5 @@
 use rspack_collections::Identifier;
-use rspack_core::{Compilation, RuntimeModule, impl_runtime_module};
+use rspack_core::{Compilation, RuntimeModule, RuntimeTemplate, impl_runtime_module};
 use rspack_util::test::is_hot_test;
 
 #[impl_runtime_module]
@@ -8,9 +8,12 @@ pub struct HotModuleReplacementRuntimeModule {
   id: Identifier,
 }
 
-impl Default for HotModuleReplacementRuntimeModule {
-  fn default() -> Self {
-    Self::with_default(Identifier::from("webpack/runtime/hot_module_replacement"))
+impl HotModuleReplacementRuntimeModule {
+  pub fn new(runtime_template: &RuntimeTemplate) -> Self {
+    Self::with_default(Identifier::from(format!(
+      "{}hot_module_replacement",
+      runtime_template.runtime_module_prefix()
+    )))
   }
 }
 

crates/rspack_plugin_hmr/src/lib.rs

@@ -459,7 +459,7 @@ async fn additional_tree_runtime_requirements(
   runtime_requirements.insert(RuntimeGlobals::MODULE_CACHE);
   compilation.add_runtime_module(
     chunk_ukey,
-    HotModuleReplacementRuntimeModule::default().boxed(),
+    HotModuleReplacementRuntimeModule::new(&compilation.runtime_template).boxed(),
   )?;
 
   Ok(())