refactor: rename webpack reexport vars to Rspack format (#12263)

* refactor: rename webpack reexport vars to Rspack format

* fix: spacing

Author: chenjiahan

crates/rspack_core/src/dependency/runtime_template.rs

@@ -556,15 +556,15 @@ pub fn import_statement(
   }
 
   let import_content = format!(
-    "/* import */{opt_declaration}{import_var} = {}({module_id_expr});\n",
+    "/* import */ {opt_declaration}{import_var} = {}({module_id_expr});\n",
     RuntimeGlobals::REQUIRE
   );
   if matches!(exports_type, ExportsType::Dynamic) {
     runtime_requirements.insert(RuntimeGlobals::COMPAT_GET_DEFAULT_EXPORT);
     return (
       import_content,
       format!(
-        "/* import */{opt_declaration}{import_var}_default = /*#__PURE__*/{}({import_var});\n",
+        "/* import */ {opt_declaration}{import_var}_default = /*#__PURE__*/{}({import_var});\n",
         RuntimeGlobals::COMPAT_GET_DEFAULT_EXPORT,
       ),
     );

crates/rspack_core/src/external_module.rs

@@ -361,7 +361,7 @@ impl ExternalModule {
           chunk_init_fragments.push(
             NormalInitFragment::new(
               format!(
-                "import {{ createRequire as __rspack_external_createRequire }} from \"{}\";\n{} __rspack_external_createRequire_require = __rspack_external_createRequire({}.url);\n",
+                "import {{ createRequire as __rspack_createRequire }} from \"{}\";\n{} __rspack_createRequire_require = __rspack_createRequire({}.url);\n",
                 if need_prefix { "node:module" } else { "module" },
                 if compilation.options.output.environment.supports_const() {
                   "const"
@@ -386,7 +386,7 @@ impl ExternalModule {
             ("undefined".to_string(), String::new())
           };
           format!(
-            "{} = __rspack_external_createRequire_require({}){};",
+            "{} = __rspack_createRequire_require({}){};",
             get_namespace_object_export(concatenation_scope, supports_const),
             request,
             specifiers

crates/rspack_plugin_javascript/src/dependency/esm/esm_export_imported_specifier_dependency.rs

@@ -531,7 +531,7 @@ impl ESMExportImportedSpecifierDependency {
       }
       ExportMode::Unused(ExportModeUnused { name }) => ctxt.init_fragments.push(
         NormalInitFragment::new(
-          to_normal_comment(&format!("unused ESM reexport {name}")),
+          to_normal_comment(&format!("unused reexport {name}")),
           InitFragmentStage::StageESMExports,
           1,
           InitFragmentKey::unique(),
@@ -701,8 +701,7 @@ impl ESMExportImportedSpecifierDependency {
           let key = render_used_name(used_name.as_ref());
 
           if checked {
-            let key =
-              InitFragmentKey::ESMImport(format!("ESM reexport (checked) {import_var} {name}"));
+            let key = InitFragmentKey::ESMImport(format!("reexport (checked) {import_var} {name}"));
             let runtime_condition = if self.weak() {
               RuntimeCondition::Boolean(false)
             } else if let Some(connection) = mg.connection_by_dependency_id(self.id()) {
@@ -772,25 +771,25 @@ impl ESMExportImportedSpecifierDependency {
         // TODO: modern, need runtimeTemplate support https://github.com/webpack/webpack/blob/1f99ad6367f2b8a6ef17cce0e058f7a67fb7db18/lib/dependencies/HarmonyExportImportedSpecifierDependency.js#L1104-L1106
         let mut content = format!(
           r"
-/* ESM reexport (unknown) */ var __WEBPACK_REEXPORT_OBJECT__ = {{}};
-/* ESM reexport (unknown) */ for( var __WEBPACK_IMPORT_KEY__ in {import_var}) "
+/* reexport */ var __rspack_reexport = {{}};
+/* reexport */ for( var __rspack_import_key in {import_var}) "
         );
 
         if ignored.len() > 1 {
           content += &format!(
-            "if({}.indexOf(__WEBPACK_IMPORT_KEY__) < 0) ",
+            "if({}.indexOf(__rspack_import_key) < 0) ",
             serde_json::to_string(&ignored).expect("should serialize to array")
           );
         } else if let Some(item) = ignored.iter().next() {
           content += &format!(
-            "if(__WEBPACK_IMPORT_KEY__ !== {}) ",
+            "if(__rspack_import_key !== {}) ",
             serde_json::to_string(item).expect("should serialize to string")
           );
         }
-        content += "__WEBPACK_REEXPORT_OBJECT__[__WEBPACK_IMPORT_KEY__] =";
+        content += "__rspack_reexport[__rspack_import_key] =";
         // TODO should decide if `modern` is true
         content +=
-          &format!("function(key) {{ return {import_var}[key]; }}.bind(0, __WEBPACK_IMPORT_KEY__)");
+          &format!("function(key) {{ return {import_var}[key]; }}.bind(0, __rspack_import_key)");
         runtime_requirements.insert(RuntimeGlobals::EXPORTS);
         runtime_requirements.insert(RuntimeGlobals::DEFINE_PROPERTY_GETTERS);
 
@@ -802,7 +801,7 @@ impl ESMExportImportedSpecifierDependency {
         ctxt.init_fragments.push(
           NormalInitFragment::new(
             format!(
-              "{content}\n/* ESM reexport (unknown) */ {}({}, __WEBPACK_REEXPORT_OBJECT__);\n",
+              "{content}\n/* reexport */ {}({}, __rspack_reexport);\n",
               RuntimeGlobals::DEFINE_PROPERTY_GETTERS,
               exports_name
             ),

crates/rspack_plugin_javascript/src/parser_plugin/api_plugin.rs

@@ -198,7 +198,7 @@ impl JavascriptParserPlugin for APIPlugin {
       API_NON_REQUIRE => {
         let content = if self.options.module {
           parser.build_info.need_create_require = true;
-          "__rspack_external_createRequire_require".into()
+          "__rspack_createRequire_require".into()
         } else {
           "require".into()
         };

crates/rspack_plugin_javascript/src/plugin/api_plugin.rs

@@ -45,7 +45,7 @@ async fn render_module_content(
     init_fragments.push(
       NormalInitFragment::new(
         format!(
-          "import {{ createRequire as __rspack_external_createRequire }} from \"{}\";\n{} __rspack_external_createRequire_require = __rspack_external_createRequire({}.url);\n",
+          "import {{ createRequire as __rspack_createRequire }} from \"{}\";\n{} __rspack_createRequire_require = __rspack_createRequire({}.url);\n",
           if need_prefix { "node:module" } else { "module" },
           if compilation.options.output.environment.supports_const() {
             "const"

tests/rspack-test/builtinCases/plugin-asset/asset-advanced/__snapshots__/output.snap.txt

@@ -3,7 +3,7 @@
 (self["webpackChunkwebpack"] = self["webpackChunkwebpack"] || []).push([["main"], {
 "./index.js": (function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 __webpack_require__.r(__webpack_exports__);
-/* import */var _images_file_svg__rspack_import_0 = __webpack_require__("./images/file.svg");
+/* import */ var _images_file_svg__rspack_import_0 = __webpack_require__("./images/file.svg");
 
 
 const container = document.createElement("div");

tests/rspack-test/builtinCases/plugin-asset/asset-simple/__snapshots__/output.snap.txt

@@ -3,9 +3,9 @@
 (self["webpackChunkwebpack"] = self["webpackChunkwebpack"] || []).push([["main"], {
 "./index.js": (function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 __webpack_require__.r(__webpack_exports__);
-/* import */var _images_file_png__rspack_import_0 = __webpack_require__("./images/file.png");
-/* import */var _images_file_jpg__rspack_import_1 = __webpack_require__("./images/file.jpg");
-/* import */var _images_file_svg__rspack_import_2 = __webpack_require__("./images/file.svg");
+/* import */ var _images_file_png__rspack_import_0 = __webpack_require__("./images/file.png");
+/* import */ var _images_file_jpg__rspack_import_1 = __webpack_require__("./images/file.jpg");
+/* import */ var _images_file_svg__rspack_import_2 = __webpack_require__("./images/file.svg");
 
 
 

tests/rspack-test/builtinCases/plugin-asset/asset-source/__snapshots__/output.snap.txt

@@ -3,7 +3,7 @@
 (self["webpackChunkwebpack"] = self["webpackChunkwebpack"] || []).push([["main"], {
 "./index.js": (function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 __webpack_require__.r(__webpack_exports__);
-/* import */var _data_txt__rspack_import_0 = __webpack_require__("./data.txt");
+/* import */ var _data_txt__rspack_import_0 = __webpack_require__("./data.txt");
 
 
 console.log(_data_txt__rspack_import_0);

tests/rspack-test/builtinCases/plugin-css-modules/modules-composes/__snapshots__/output.snap.txt

@@ -48,7 +48,7 @@
 (self["webpackChunkwebpack"] = self["webpackChunkwebpack"] || []).push([["main"], {
 "./index.js": (function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 __webpack_require__.r(__webpack_exports__);
-/* import */var _style_module_css__rspack_import_0 = __webpack_require__("./style.module.css");
+/* import */ var _style_module_css__rspack_import_0 = __webpack_require__("./style.module.css");
 
 
 

tests/rspack-test/builtinCases/plugin-css-modules/modules-ident-name/__snapshots__/output.snap.txt

@@ -10,7 +10,7 @@
 (self["webpackChunkwebpack"] = self["webpackChunkwebpack"] || []).push([["main"], {
 "./index.js": (function (__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 __webpack_require__.r(__webpack_exports__);
-/* import */var _style_module_css__rspack_import_0 = __webpack_require__("./style.module.css");
+/* import */ var _style_module_css__rspack_import_0 = __webpack_require__("./style.module.css");
 
 
 console.log(_style_module_css__rspack_import_0);