Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Commit 408332d

Browse files
mpetrunicjdevcsavkosnikoulaiAlex
authored
fix!: remove non read-only ens methods (#6084)
* fix!: remove non read-only ens methods Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> * fix integration tests Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> * fix tests * fix tests * remove unnecessary tests * increase coverage * fix changelog * skip internal provider test for now --------- Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com> Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
1 parent 8c5ea34 commit 408332d

File tree

21 files changed

+1380
-2157
lines changed

21 files changed

+1380
-2157
lines changed

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1465,6 +1465,7 @@ should use 4.0.1-alpha.0 for testing.
14651465
### Breaking Changes
14661466

14671467
- dropped support for NodeJs@14
1468+
- removed non read-only methods from ens package
14681469

14691470
### Added
14701471

‎packages/web3-eth-ens/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,3 +83,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
8383
- Bug fix of `checkNetwork` in ENS (#5988)
8484

8585
## [Unreleased]
86+
87+
### Removed
88+
89+
- Removed non read-only methods (#6084)

‎packages/web3-eth-ens/src/abi/ens/ENSRegistry.ts‎

Lines changed: 0 additions & 211 deletions
Original file line numberDiff line numberDiff line change
@@ -17,36 +17,6 @@ along with web3.js. If not, see <http://www.gnu.org/licenses/>.
1717

1818
// https://github.com/ensdomains/ens-contracts/blob/master/contracts/registry/ENSRegistry.sol
1919
export const ENSRegistryAbi = [
20-
{
21-
inputs: [],
22-
stateMutability: 'nonpayable',
23-
type: 'constructor',
24-
},
25-
{
26-
anonymous: false,
27-
inputs: [
28-
{
29-
indexed: true,
30-
internalType: 'address',
31-
name: 'owner',
32-
type: 'address',
33-
},
34-
{
35-
indexed: true,
36-
internalType: 'address',
37-
name: 'operator',
38-
type: 'address',
39-
},
40-
{
41-
indexed: false,
42-
internalType: 'bool',
43-
name: 'approved',
44-
type: 'bool',
45-
},
46-
],
47-
name: 'ApprovalForAll',
48-
type: 'event',
49-
},
5020
{
5121
anonymous: false,
5222
inputs: [
@@ -91,25 +61,6 @@ export const ENSRegistryAbi = [
9161
name: 'NewResolver',
9262
type: 'event',
9363
},
94-
{
95-
anonymous: false,
96-
inputs: [
97-
{
98-
indexed: true,
99-
internalType: 'bytes32',
100-
name: 'node',
101-
type: 'bytes32',
102-
},
103-
{
104-
indexed: false,
105-
internalType: 'uint64',
106-
name: 'ttl',
107-
type: 'uint64',
108-
},
109-
],
110-
name: 'NewTTL',
111-
type: 'event',
112-
},
11364
{
11465
anonymous: false,
11566
inputs: [
@@ -210,168 +161,6 @@ export const ENSRegistryAbi = [
210161
stateMutability: 'view',
211162
type: 'function',
212163
},
213-
{
214-
inputs: [
215-
{
216-
internalType: 'address',
217-
name: 'operator',
218-
type: 'address',
219-
},
220-
{
221-
internalType: 'bool',
222-
name: 'approved',
223-
type: 'bool',
224-
},
225-
],
226-
name: 'setApprovalForAll',
227-
outputs: [],
228-
stateMutability: 'nonpayable',
229-
type: 'function',
230-
},
231-
{
232-
inputs: [
233-
{
234-
internalType: 'bytes32',
235-
name: 'node',
236-
type: 'bytes32',
237-
},
238-
{
239-
internalType: 'address',
240-
name: 'owner',
241-
type: 'address',
242-
},
243-
],
244-
name: 'setOwner',
245-
outputs: [],
246-
stateMutability: 'nonpayable',
247-
type: 'function',
248-
},
249-
{
250-
inputs: [
251-
{
252-
internalType: 'bytes32',
253-
name: 'node',
254-
type: 'bytes32',
255-
},
256-
{
257-
internalType: 'address',
258-
name: 'owner',
259-
type: 'address',
260-
},
261-
{
262-
internalType: 'address',
263-
name: 'resolver',
264-
type: 'address',
265-
},
266-
{
267-
internalType: 'uint64',
268-
name: 'ttl',
269-
type: 'uint64',
270-
},
271-
],
272-
name: 'setRecord',
273-
outputs: [],
274-
stateMutability: 'nonpayable',
275-
type: 'function',
276-
},
277-
{
278-
inputs: [
279-
{
280-
internalType: 'bytes32',
281-
name: 'node',
282-
type: 'bytes32',
283-
},
284-
{
285-
internalType: 'address',
286-
name: 'resolver',
287-
type: 'address',
288-
},
289-
],
290-
name: 'setResolver',
291-
outputs: [],
292-
stateMutability: 'nonpayable',
293-
type: 'function',
294-
},
295-
{
296-
inputs: [
297-
{
298-
internalType: 'bytes32',
299-
name: 'node',
300-
type: 'bytes32',
301-
},
302-
{
303-
internalType: 'bytes32',
304-
name: 'label',
305-
type: 'bytes32',
306-
},
307-
{
308-
internalType: 'address',
309-
name: 'owner',
310-
type: 'address',
311-
},
312-
],
313-
name: 'setSubnodeOwner',
314-
outputs: [
315-
{
316-
internalType: 'bytes32',
317-
name: '',
318-
type: 'bytes32',
319-
},
320-
],
321-
stateMutability: 'nonpayable',
322-
type: 'function',
323-
},
324-
{
325-
inputs: [
326-
{
327-
internalType: 'bytes32',
328-
name: 'node',
329-
type: 'bytes32',
330-
},
331-
{
332-
internalType: 'bytes32',
333-
name: 'label',
334-
type: 'bytes32',
335-
},
336-
{
337-
internalType: 'address',
338-
name: 'owner',
339-
type: 'address',
340-
},
341-
{
342-
internalType: 'address',
343-
name: 'resolver',
344-
type: 'address',
345-
},
346-
{
347-
internalType: 'uint64',
348-
name: 'ttl',
349-
type: 'uint64',
350-
},
351-
],
352-
name: 'setSubnodeRecord',
353-
outputs: [],
354-
stateMutability: 'nonpayable',
355-
type: 'function',
356-
},
357-
{
358-
inputs: [
359-
{
360-
internalType: 'bytes32',
361-
name: 'node',
362-
type: 'bytes32',
363-
},
364-
{
365-
internalType: 'uint64',
366-
name: 'ttl',
367-
type: 'uint64',
368-
},
369-
],
370-
name: 'setTTL',
371-
outputs: [],
372-
stateMutability: 'nonpayable',
373-
type: 'function',
374-
},
375164
{
376165
inputs: [
377166
{

0 commit comments

Comments
 (0)