Skip to content

Commit 37b8829

Browse files
committed
Address Spring Security 6 migration changes
- JavaEE -> JakartaEE - logback upgrade
1 parent c1d5726 commit 37b8829

File tree

60 files changed

+99
-125
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+99
-125
lines changed

build.gradle

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ buildscript {
2727

2828
//Libraries
2929
webauthn4jVersion = '0.21.0.RELEASE'
30-
springSecurityVersion = '5.8.2'
30+
springSecurityVersion = '6.0.2'
3131
hibernateValidatorVersion = '6.2.5.Final'
3232
thymeleafVersion = '3.0.4.RELEASE'
3333
modelMapperVersion = '3.1.1'
@@ -45,12 +45,6 @@ buildscript {
4545
// When stable version is released, and Spring Boot BOM includes it, this need to be removed.
4646
seleniumVersion = '4.8.1'
4747

48-
// To make the test pass without errors NoClassDefFoundError in samples/fido-server-conformance-test-app
49-
// There is a compatibility issue between the versions of SLF4J/Logback used by webauthn4j and the versions used by Spring Boot 2.7.x
50-
// There are breaking change in th SLF4J 2.x branche ("SLF4J API version 2.0.0 relies on the ServiceLoader mechanism to find its logging backend"
51-
// and no any more on the StaticLoggerBinder see https://www.slf4j.org/manual.html).
52-
// When upgrading to Spring Boot 3.x branche, this constant will have to be removed.
53-
logbackSpringBoot27xCompatibilityVersion = '1.2.11'
5448
}
5549

5650
repositories {
@@ -235,7 +229,7 @@ configure(sampleAppProjects) {
235229
configure(allJavaProjects) {
236230
apply plugin: 'org.owasp.dependencycheck'
237231

238-
sourceCompatibility = 1.8
232+
sourceCompatibility = 17
239233

240234
tasks.withType(JavaCompile) {
241235
options.compilerArgs << "-Xlint:unchecked"

samples/fido-server-conformance-test-app/build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ dependencies {
4040
implementation("org.slf4j:jcl-over-slf4j")
4141
implementation("org.modelmapper:modelmapper")
4242
implementation('org.flywaydb:flyway-core')
43-
//We have to force the use of this dependency
44-
runtimeOnly("ch.qos.logback:logback-classic:$logbackSpringBoot27xCompatibilityVersion"){
45-
force = true
46-
}
4743
runtimeOnly('com.h2database:h2')
4844
runtimeOnly('com.mysql:mysql-connector-j')
4945
runtimeOnly("org.lazyluke:log4jdbc-remix")

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/FidoServerAssertionOptionsEndpointFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
3030
import org.springframework.util.Assert;
3131

32-
import javax.servlet.http.HttpServletRequest;
32+
import jakarta.servlet.http.HttpServletRequest;
3333
import java.io.IOException;
3434
import java.io.InputStream;
3535
import java.io.UncheckedIOException;

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/FidoServerAssertionResultEndpointFailureHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
import org.springframework.security.core.AuthenticationException;
2121
import org.springframework.security.web.authentication.AuthenticationFailureHandler;
2222

23-
import javax.servlet.http.HttpServletRequest;
24-
import javax.servlet.http.HttpServletResponse;
23+
import jakarta.servlet.http.HttpServletRequest;
24+
import jakarta.servlet.http.HttpServletResponse;
2525
import java.io.IOException;
2626

2727
public class FidoServerAssertionResultEndpointFailureHandler implements AuthenticationFailureHandler {

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/FidoServerAssertionResultEndpointFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
import org.springframework.security.web.util.matcher.RequestMatcher;
3838
import org.springframework.util.Assert;
3939

40-
import javax.servlet.http.HttpServletRequest;
41-
import javax.servlet.http.HttpServletResponse;
40+
import jakarta.servlet.http.HttpServletRequest;
41+
import jakarta.servlet.http.HttpServletResponse;
4242
import java.io.IOException;
4343
import java.io.InputStream;
4444
import java.io.UncheckedIOException;

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/FidoServerAssertionResultEndpointSuccessHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
import org.springframework.security.core.Authentication;
2121
import org.springframework.security.web.authentication.AuthenticationSuccessHandler;
2222

23-
import javax.servlet.http.HttpServletRequest;
24-
import javax.servlet.http.HttpServletResponse;
23+
import jakarta.servlet.http.HttpServletRequest;
24+
import jakarta.servlet.http.HttpServletResponse;
2525
import java.io.IOException;
2626

2727
public class FidoServerAssertionResultEndpointSuccessHandler implements AuthenticationSuccessHandler {

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/FidoServerAttestationOptionsEndpointFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
3030
import org.springframework.util.Assert;
3131

32-
import javax.servlet.http.HttpServletRequest;
32+
import jakarta.servlet.http.HttpServletRequest;
3333
import java.io.IOException;
3434
import java.io.InputStream;
3535
import java.io.UncheckedIOException;

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/FidoServerAttestationResultEndpointFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import org.springframework.security.core.userdetails.UsernameNotFoundException;
3333
import org.springframework.util.Assert;
3434

35-
import javax.servlet.http.HttpServletRequest;
35+
import jakarta.servlet.http.HttpServletRequest;
3636
import java.io.IOException;
3737
import java.io.InputStream;
3838
import java.io.UncheckedIOException;

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/ServerEndpointFilterBase.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
import org.springframework.util.Assert;
2828
import org.springframework.web.filter.GenericFilterBean;
2929

30-
import javax.servlet.FilterChain;
31-
import javax.servlet.ServletException;
32-
import javax.servlet.ServletRequest;
33-
import javax.servlet.ServletResponse;
34-
import javax.servlet.http.HttpServletRequest;
35-
import javax.servlet.http.HttpServletResponse;
30+
import jakarta.servlet.FilterChain;
31+
import jakarta.servlet.ServletException;
32+
import jakarta.servlet.ServletRequest;
33+
import jakarta.servlet.ServletResponse;
34+
import jakarta.servlet.http.HttpServletRequest;
35+
import jakarta.servlet.http.HttpServletResponse;
3636
import java.io.IOException;
3737

3838
public abstract class ServerEndpointFilterBase extends GenericFilterBean {

samples/fido-server-conformance-test-app/src/main/java/com/webauthn4j/springframework/security/fido/server/endpoint/ServerEndpointFilterUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.springframework.security.authentication.InsufficientAuthenticationException;
2828
import org.springframework.security.core.AuthenticationException;
2929

30-
import javax.servlet.http.HttpServletResponse;
30+
import jakarta.servlet.http.HttpServletResponse;
3131
import java.io.IOException;
3232

3333
class ServerEndpointFilterUtil {

0 commit comments

Comments
 (0)