Skip to content

sort query args before queuing URLs #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ikreymer merged 5 commits into from
Dec 8, 2025
Merged

sort query args before queuing URLs #935

ikreymer merged 5 commits into from
Dec 8, 2025
+38 −1

Conversation

@ikreymer
Copy link
Member

@ikreymer ikreymer commented Dec 5, 2025

  • use 'normalize-url' package to avoid differently sorted query args that are the same url
  • configure other options, such as keeping www. and trailing slashes, only using this for query arg sorting

@ikreymer
- use 'normalize-url' package to avoid differently sorted query args
0b0f29a 
- configure other options, such as keeping www. and trailing slashes, only using this
for query arg sorting
@ikreymer ikreymer requested a review from tw4l December 5, 2025 18:14
@socket-security
Copy link

socket-security bot commented Dec 5, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addednpm/​normalize-url@​8.1.010010010081100

View full report

tw4l
tw4l approved these changes Dec 8, 2025
View reviewed changes
@ikreymer ikreymer merged commit 4a703cd into main Dec 8, 2025
7 of 8 checks passed
@ikreymer ikreymer deleted the add-normalize-url branch December 8, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tw4l tw4l tw4l approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikreymer @tw4l