不可变的成员变量增加 final 修饰符

Author: Eric-Lee-Handyman

src/main/java/com/wechat/pay/contrib/apache/httpclient/WechatPayUploadHttpPost.java

@@ -10,7 +10,7 @@
 
 public class WechatPayUploadHttpPost extends HttpPost {
 
-    private String meta;
+    private final String meta;
 
     private WechatPayUploadHttpPost(URI uri, String meta) {
         super(uri);

src/test/java/com/wechat/pay/contrib/apache/httpclient/AutoUpdateVerifierTest.java

@@ -28,17 +28,16 @@
 
 public class AutoUpdateVerifierTest {
 
-    private static String mchId = ""; // 商户号
-    private static String mchSerialNo = ""; // 商户证书序列号
-    private static String apiV3Key = ""; // api密钥
     // 你的商户私钥
-    private static String privateKey = "-----BEGIN PRIVATE KEY-----\n"
+    private static final String privateKey = "-----BEGIN PRIVATE KEY-----\n"
             + "-----END PRIVATE KEY-----\n";
-
     //测试AutoUpdateCertificatesVerifier的verify方法参数
-    private static String serialNumber = "";
-    private static String message = "";
-    private static String signature = "";
+    private static final String serialNumber = "";
+    private static final String message = "";
+    private static final String signature = "";
+    private static final String mchId = ""; // 商户号
+    private static final String mchSerialNo = ""; // 商户证书序列号
+    private static final String apiV3Key = ""; // api密钥
     private CloseableHttpClient httpClient;
     private AutoUpdateCertificatesVerifier verifier;
 

src/test/java/com/wechat/pay/contrib/apache/httpclient/HttpClientBuilderTest.java

@@ -29,19 +29,19 @@
 
 public class HttpClientBuilderTest {
 
-    private static String mchId = "1900009191"; // 商户号
-    private static String mchSerialNo = "1DDE55AD98ED71D6EDD4A4A16996DE7B47773A8C"; // 商户证书序列号
-    private static String requestBody = "{\n"
+    private static final String mchId = "1900009191"; // 商户号
+    private static final String mchSerialNo = "1DDE55AD98ED71D6EDD4A4A16996DE7B47773A8C"; // 商户证书序列号
+    private static final String requestBody = "{\n"
             + "    \"stock_id\": \"9433645\",\n"
             + "    \"stock_creator_mchid\": \"1900006511\",\n"
             + "    \"out_request_no\": \"20190522_001中文11\",\n"
             + "    \"appid\": \"wxab8acb865bb1637e\"\n"
             + "}";
     // 你的商户私钥
-    private static String privateKey = "-----BEGIN PRIVATE KEY-----\n"
+    private static final String privateKey = "-----BEGIN PRIVATE KEY-----\n"
             + "-----END PRIVATE KEY-----";
     // 你的微信支付平台证书
-    private static String certificate = "-----BEGIN CERTIFICATE-----\n"
+    private static final String certificate = "-----BEGIN CERTIFICATE-----\n"
             + "-----END CERTIFICATE-----";
     private CloseableHttpClient httpClient;
 

src/test/java/com/wechat/pay/contrib/apache/httpclient/RsaCryptoTest.java

@@ -24,11 +24,11 @@
 
 public class RsaCryptoTest {
 
-    private static String mchId = ""; // 商户号
-    private static String mchSerialNo = ""; // 商户证书序列号
-    private static String apiV3Key = ""; // api密钥
+    private static final String mchId = ""; // 商户号
+    private static final String mchSerialNo = ""; // 商户证书序列号
+    private static final String apiV3Key = ""; // api密钥
     // 你的商户私钥
-    private static String privateKey = "-----BEGIN PRIVATE KEY-----\n"
+    private static final String privateKey = "-----BEGIN PRIVATE KEY-----\n"
             + "-----END PRIVATE KEY-----\n";
 
     private CloseableHttpClient httpClient;