Skip to content

Conversation

@adids1221
Copy link

@adids1221 adids1221 commented Dec 1, 2025

Description

Adds iconBackground property support to backButton options, matching the functionality available for rightButtons and leftButtons.
This enables circular and rounded background shapes behind the back button icon, consistent with regular button styling.

Changes:

  • Added iconBackground?: IconBackgroundOptions; to OptionsTopBarBackButton TypeScript interface
  • Android: Parse and merge iconBackground in BackButton class, apply via ButtonPresenter.applyNavigationIcon()
  • iOS: Add iconBackground property to RNNBackButtonOptions, parse and merge, render using RNNIconDrawer

Technical Details:

  • Android: Reuses existing IconBackgroundDrawable infrastructure via applyIconBackgroundDrawable() method
  • iOS: Uses RNNIconDrawer directly (simpler approach, no need for full icon creator system)
  • Both platforms support: color, disabledColor, cornerRadius, width, height properties

Changelog

BackButton - Added iconBackground property support. Back button icons can now display circular or rounded backgrounds matching the styling of regular navigation buttons.

Additional info

MADS-4884

@adids1221
Copy link
Author

@markdevocht, should I merge master already?
Or wait for the Shai Hulud fix?

Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks @adids1221!
Could you add a visual of some sort describing what you need?
Also, please be sure to add at least one visual (e2e) test to cover this use case 🙏🏻

@markdevocht @gosha212 let's discuss whether this is the right approach (=API) once we understand the use case better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants