Skip to content

Commit fabcecb

Browse files
committed
Use better names
1 parent 2e551c5 commit fabcecb

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

WordPress/Classes/ViewRelated/Aztec/Media/MediaProgressCoordinator.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ public class MediaProgressCoordinator: NSObject {
3434

3535
private static var mediaProgressObserverContext = 0
3636

37-
private lazy var bgTaskTracker: MediaUploadBackgroundTracker? = mediaUploadBackgroundTracker()
38-
3937
deinit {
4038
mediaGlobalProgress?.removeObserver(self, forKeyPath: #keyPath(Progress.fractionCompleted))
4139
}
@@ -77,7 +75,7 @@ public class MediaProgressCoordinator: NSObject {
7775

7876
let objectID = TaggedManagedObjectID(media)
7977
Task {
80-
await bgTaskTracker?.track(progress: progress, media: objectID)
78+
await mediaUploadBackgroundTaskScheduler()?.scheduleTask(for: objectID, progress: progress)
8179
}
8280
}
8381

WordPress/Classes/ViewRelated/Aztec/Media/MediaUploadBackgroundTracker.swift renamed to WordPress/Classes/ViewRelated/Aztec/Media/MediaUploadBackgroundTaskScheduler.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,23 @@ import Combine
44
import WordPressShared
55

66
// This protocol is used to hide the `@available(iOS 26.0, *)` check.
7-
protocol MediaUploadBackgroundTracker {
7+
protocol MediaUploadBackgroundTaskScheduler {
88

9-
func track(progress: Progress, media: TaggedManagedObjectID<Media>) async
9+
func scheduleTask(for media: TaggedManagedObjectID<Media>, progress: Progress) async
1010

1111
}
1212

13-
func mediaUploadBackgroundTracker() -> MediaUploadBackgroundTracker? {
13+
func mediaUploadBackgroundTaskScheduler() -> MediaUploadBackgroundTaskScheduler? {
1414
if #available(iOS 26.0, *) {
15-
ConcreteMediaUploadBackgroundTracker.shared
15+
ConcreteMediaUploadBackgroundTaskScheduler.shared
1616
} else {
1717
nil
1818
}
1919
}
2020

2121
@available(iOS 26.0, *)
2222
/// Utilize `BGContinuedProcessingTask` to show the uploading media activity.
23-
private actor ConcreteMediaUploadBackgroundTracker: MediaUploadBackgroundTracker {
23+
private actor ConcreteMediaUploadBackgroundTaskScheduler: MediaUploadBackgroundTaskScheduler {
2424
struct Item {
2525
// Please note: all media query needs to be done in the main context, due to the current upload media implementation.
2626
var media: TaggedManagedObjectID<Media>
@@ -47,7 +47,7 @@ private actor ConcreteMediaUploadBackgroundTracker: MediaUploadBackgroundTracker
4747
}
4848

4949
// Since this type works with `BGTaskScheduler.shared`, it only makes sense for the type to also be a singleton.
50-
static let shared = ConcreteMediaUploadBackgroundTracker()
50+
static let shared = ConcreteMediaUploadBackgroundTaskScheduler()
5151

5252
// We only use one `BGContinuedProcessingTask` for all uploads. When adding new media during uploading, the new ones
5353
// will be added to the existing task.
@@ -80,7 +80,7 @@ private actor ConcreteMediaUploadBackgroundTracker: MediaUploadBackgroundTracker
8080

8181
}
8282

83-
func track(progress: Progress, media: TaggedManagedObjectID<Media>) async {
83+
func scheduleTask(for media: TaggedManagedObjectID<Media>, progress: Progress) async {
8484
observeCoreDataChanges()
8585

8686
let item = Item(media: media, progress: progress)

0 commit comments

Comments
 (0)