fix(vscode): language server error when formatting models with Unsupported fields (#1558)

Author: ymc9

packages/schema/src/language-server/zmodel-formatter.ts

@@ -105,7 +105,19 @@ export class ZModelFormatter extends AbstractFormatter {
     }
 
     private getFieldTypeLength(field: ast.DataModelField) {
-        let length = (field.type.type || field.type.reference?.$refText)!.length;
+        let length: number;
+
+        if (field.type.type) {
+            length = field.type.type.length;
+        } else if (field.type.reference) {
+            length = field.type.reference.$refText.length;
+        } else if (field.type.unsupported) {
+            const name = `Unsupported("${field.type.unsupported.value.value}")`;
+            length = name.length;
+        } else {
+            // we shouldn't get here
+            length = 1;
+        }
 
         if (field.type.optional) {
             length += 1;

tests/integration/tests/cli/format.test.ts

@@ -22,7 +22,7 @@ describe('CLI format test', () => {
         const model = `
         datasource db {provider="sqlite" url="file:./dev.db"}
         generator client {provider = "prisma-client-js"}
-        model Post {id Int @id() @default(autoincrement())users User[]}`;
+        model Post {id Int @id() @default(autoincrement())users User[]foo Unsupported("foo")}`;
 
         const formattedModel = `
 datasource db {
@@ -35,6 +35,7 @@ generator client {
 model Post {
     id Int @id() @default(autoincrement())
     users User[]
+    foo Unsupported("foo")
 }`;
         // set up schema
         fs.writeFileSync('schema.zmodel', model, 'utf-8');
@@ -48,7 +49,7 @@ model Post {
         const model = `
         datasource db {provider="sqlite" url="file:./dev.db"}
         generator client {provider = "prisma-client-js"}
-        model Post {id Int @id() @default(autoincrement())users User[]}`;
+        model Post {id Int @id() @default(autoincrement())users User[]foo Unsupported("foo")}`;
 
         const formattedModel = `
 datasource db {
@@ -59,8 +60,9 @@ generator client {
     provider = "prisma-client-js"
 }
 model Post {
-    id    Int    @id() @default(autoincrement())
+    id    Int                @id() @default(autoincrement())
     users User[]
+    foo   Unsupported("foo")
 }`;
         // set up schema
         fs.writeFileSync('schema.zmodel', model, 'utf-8');