drivers: input: bflb IR RX #100600
Open
drivers: input: bflb IR RX #100600
+549
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add binding and nodes for bflb,irx Signed-off-by: Camille BAUD <mail@massdriver.space>
zephyrbot
added
area: Boards/SoCs
area: RISCV
zephyrbot
requested review from
edersondisouza,
fabiobaltieri,
fkokosinski,
josuah,
katsuster,
kgugala,
masz-nordic,
mgielda,
nordic-krch,
npitre,
tgorochowik and
ycsin
Will be replaced when approved Signed-off-by: Camille BAUD <mail@massdriver.space>
Enable the gates for IRX Signed-off-by: Camille BAUD <mail@massdriver.space>
Introduces a driver for the IR receiver on BFLB socs Signed-off-by: Camille BAUD <mail@massdriver.space>
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
the
DNM (manifest)
|
ycsin
reviewed
Dec 9, 2025
Comment on lines
+663
to
+664
| /* enable IR clock routing */ | ||
| regval |= (1 << 22); |
Member
There was a problem hiding this comment.
isn't it better to guard these with kconfig so that they don't get clocked when they aren't enabled?
Comment on lines
+290
to
+294
| if (cfg->protocol < PW) { | ||
| bflb_irx_isr_handle_prot(data->dev); | ||
| } else { | ||
| bflb_irx_isr_handle_pw(data->dev); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (cfg->protocol < PW) { | |
| bflb_irx_isr_handle_prot(data->dev); | |
| } else { | |
| bflb_irx_isr_handle_pw(data->dev); | |
| } | |
| if (cfg->protocol == PW) { | |
| bflb_irx_isr_handle_pw(data->dev); | |
| } else { | |
| bflb_irx_isr_handle_prot(data->dev); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce BFLB IR rx peripheral. It does similar things to the vishay vs1838b driver and can in fact use the specific diode as input (and it works great, tested with that on bl60x and bl70x), but as a dedicated peripheral. It can measure Pulse Width additionally.