Conversation
Wallet, deploy and mint test. Editor helper not working
update to enable editor calls reading json body correctly
Deploying sequence-unity with
|
| Latest commit: |
d6c513c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f36b804.sequence-unity.pages.dev |
| Branch Preview URL: | https://feature-sidekick.sequence-unity.pages.dev |
There was a problem hiding this comment.
MenuName should be "Sequence/SidekickConfig" - this way it lives with our other scriptable objects (including the others in this PR)
There was a problem hiding this comment.
This should probably live somewhere else 😉
There was a problem hiding this comment.
If we want to ship this to users, it should go somewhere in the Packages folder
There was a problem hiding this comment.
I wonder if maybe "Sequence/" is a better menu item path for these - this way we can leave "Sequence Dev" for us. What do you think?
There was a problem hiding this comment.
What should the path be? I tried http://localhost:8080/ but received the following error:
"Sidekick path not set or invalid: http://localhost:8080/"
There was a problem hiding this comment.
This logic is repeated a few times - consider using a helper function
There was a problem hiding this comment.
Unlike the other mint functions, you didn't wrap these in an EditorApplication.delayCall. Should you have?
There was a problem hiding this comment.
Let's put this in StringExtensions for further re-usability
There was a problem hiding this comment.
What is this used for?
| catch (HttpRequestException e) | ||
| { | ||
| throw; | ||
| } |
|
Great demo! Some great ideas in here too. Lots of really good stuff for us to build off of in the future. Left some comments and questions for you to help with readability and integration. |
There was a problem hiding this comment.
These tasks/API calls would be much easier to integrate (and less error prone) if the methods took in objects as parameters instead of json (same goes for returning)
Fixes to scripts locations
2 participants
Wallet, deploy and mint test. Editor helper not working
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: