feat: Add query_step to ContextCommandPipeline #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds a query_step method to ContextCommandPipeline, enabling pipelines to dispatch queries in addition to commands. This enhances the pipeline pattern by allowing mixed command and query dispatching within the same pipeline.
Changes:
- Added
query_stepmethod toContextCommandPipelinethat delegates to the basestepmethod with a query-specific dispatcher - Introduced a separate
__query_dispatcher(LazyDispatcher with QueryBus) for handling query dispatching - Updated test to demonstrate query_step functionality with a query handler
- Updated documentation to document the new
query_stepdecorator - Updated type annotations to be more specific (using
ContextCommandPipelineinstead of genericContextPipeline) - Updated various dependencies to their latest versions
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cq/_core/pipetools.py | Added query_step method and __query_dispatcher attribute to support query dispatching in pipelines |
| tests/test_context_command_pipeline.py | Updated test to demonstrate mixed command and query dispatching, removed unused import |
| docs/guides/pipeline.md | Added documentation for query_step, improved type annotations |
| uv.lock | Updated multiple dependencies to latest versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.