Skip to content

feat: Determine need redeploy #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Jan 28, 2026
+8 −4
Merged

feat: Determine need redeploy #4722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/trigger/serializers/task_source_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,20 @@ def edit(self, instance: Dict, with_valid=True):
if not trigger:
raise serializers.ValidationError(_('Trigger not found'))
task_source_trigger_edit_field_list = ['name', 'desc', 'trigger_type', 'trigger_setting', 'meta']
trigger_deploy_edit_field_list = ['trigger_type', 'trigger_setting']

need_redeploy = any(field in instance for field in trigger_deploy_edit_field_list)

for field in task_source_trigger_edit_field_list:
if field in valid_data:
setattr(trigger, field, valid_data.get(field))
trigger.save()

if trigger.is_active:
deploy(ToolModelSerializer(trigger).data, **{})
else:
undeploy(TriggerModelSerializer(trigger).data, **{})
if need_redeploy:
if trigger.is_active:
deploy(ToolModelSerializer(trigger).data, **{})
else:
undeploy(TriggerModelSerializer(trigger).data, **{})

return self.one()

Expand Down