Skip to content

fix: Trigger must have at least one task #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Jan 28, 2026
+8 −1
Merged

fix: Trigger must have at least one task #4725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/trigger/serializers/trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ def insert(self, instance, with_valid=True):
raise AppApiException(500, _('Trigger task can not be empty'))

if trigger_model.is_active:

deploy(TriggerModelSerializer(trigger_model).data, **{})
return TriggerResponse(trigger_model).data

Expand Down Expand Up @@ -516,6 +515,10 @@ def edit(self, instance: Dict, with_valid=True):
trigger_tasks = instance.get('trigger_task')

if trigger_tasks is not None:
# 检查是否为空列表
if not trigger_tasks:
raise serializers.ValidationError(_('Trigger must have at least one task'))

is_active_map = TriggerSerializer.batch_get_source_active_status(trigger_tasks)

trigger_task_model_list = [TriggerTask(
Expand All @@ -531,6 +534,10 @@ def edit(self, instance: Dict, with_valid=True):
TriggerTask.objects.filter(trigger_id=trigger_id).delete()

TriggerTask.objects.bulk_create(trigger_task_model_list)
else:
# 用户没提交 trigger_task 字段，确保数据库中有 task
if not TriggerTask.objects.filter(trigger_id=trigger_id).exists():
raise serializers.ValidationError(_('Trigger must have at least one task'))

# 重新部署触发器任务
if need_redeploy:
Expand Down